Skip to content

homogeneous nucleation of droplets & expansion chamber examples (Clare's branch) #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Jan 7, 2025

No description provided.

Comment on lines +85 to +86
builder.add_dynamic(AmbientThermodynamics())
builder.add_dynamic(Condensation())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add here the seeding dynamic (after renaming it as injection?). Inside the seeding dynamic, the super-droplet injection rate function would need to receive additional argument: an environment instance which can be queried for T and S with env[T].

},
)
# mean diameter 316nm, standard deviation 257nm
# not sure how to interpret the standard deviation given in the paper
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which paper? :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,19 @@
"""
constant rate formulation (for tests)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the unit tests have not been yet committed

@slayoo
Copy link
Member Author

slayoo commented Jan 7, 2025

Perhaps we could also add a hello-world example (or a tests) referring to the "Clouds in a glass of beer" book:
image
:)

@slayoo
Copy link
Member Author

slayoo commented Jan 7, 2025

Thank you @claresinger and @AgnieszkaZaba for today's discussion. Here's a record of the points we mentioned:

  • the arXiv paper uses a Normal distribution rather than Lognormal - perhaps worth adding to PySDM
  • a new ExpansionChamber environment (featuring perfect gas expansion, but not featuring hydrostatics) instead of using Parcel would help in making the code readable
  • an Injection (or differently named) base-class could be best to derive from two dynamics: Seeding and HomogeneousNucleation
  • could we construct a simple adaptive substepping logic by comparing the nucleation rate and the timestep?
  • test idea: J_homogeneous table from S&P
  • test idea: long vs. short timestep
  • test idea: S_max for short vs. long timestep

@claresinger
Copy link
Collaborator

Thank you @slayoo and @AgnieszkaZaba!

  • an Injection (or differently named) base-class could be best to derive from two dynamics: Seeding and HomogeneousNucleation

Would NewParticleFormation be a good name? This is the phrasing used to describe homogeneous nucleation of other species (not water) to form aerosol in the atmosphere. Or maybe something like ParticleCreation or SuperParticleFormation?

@claresinger claresinger self-assigned this Jan 7, 2025
@slayoo
Copy link
Member Author

slayoo commented Jan 7, 2025

@claresinger, thank you for the new test!
Since it was me who opened the PR, we do not have write access to your branch that is associated with this PR (just tried pushing a commit with the pdoc CI sorted out). Could you please open a new PR from the same branch?

@claresinger
Copy link
Collaborator

closing to open a new PR (so that the editing privileges transfer properly, since it is my branch)

@claresinger claresinger closed this Jan 7, 2025
@claresinger
Copy link
Collaborator

See #1492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants