-
Notifications
You must be signed in to change notification settings - Fork 46
homogeneous nucleation of droplets & expansion chamber examples (Clare's branch) #1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mimic the princeton expansion chamber
… match Fig 4 in the manuscript
builder.add_dynamic(AmbientThermodynamics()) | ||
builder.add_dynamic(Condensation()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add here the seeding dynamic (after renaming it as injection?). Inside the seeding dynamic, the super-droplet injection rate function would need to receive additional argument: an environment instance which can be queried for T and S with env[T]
.
}, | ||
) | ||
# mean diameter 316nm, standard deviation 257nm | ||
# not sure how to interpret the standard deviation given in the paper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which paper? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,19 @@ | |||
""" | |||
constant rate formulation (for tests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the unit tests have not been yet committed
Thank you @claresinger and @AgnieszkaZaba for today's discussion. Here's a record of the points we mentioned:
|
Thank you @slayoo and @AgnieszkaZaba!
Would |
@claresinger, thank you for the new test! |
closing to open a new PR (so that the editing privileges transfer properly, since it is my branch) |
See #1492 |
No description provided.