Update nearest_neighbours.py for weights=distance

yishiouchen · web-flow · commit 332e07f6b53c · 2025-09-05T15:11:54.000-07:00
The Mul operator created in line 141 converts distances (node[0]) from OnnxTopK_11 to negative values. The Mul operator is followed by a Max operator, which turns any negative value to 1e-6, so distances lose their effect in the downstream operation. I think this Mul operator should be removed, and node[0] can be connected to the Max operator directly.  

Signed-off-by: yishiouchen &lt;yi-shiou.chen@3ds.com&gt;
diff --git a/skl2onnx/operator_converters/nearest_neighbours.py b/skl2onnx/operator_converters/nearest_neighbours.py
@@ -138,7 +138,7 @@ def onnx_nearest_neighbors_indices_k(
         if keep_distances:
             return (
                 node[1],
-                OnnxMul(node[0], np.array([-1], dtype=dtype), op_version=op_version),
+                node[0]
             )
     if keep_distances:
         return (node[1], node[0])

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ def onnx_nearest_neighbors_indices_k(`
`138`	`138`	`if keep_distances:`
`139`	`139`	`return (`
`140`	`140`	`node[1],`
`141`		`- OnnxMul(node[0], np.array([-1], dtype=dtype), op_version=op_version),`
	`141`	`+ node[0]`
`142`	`142`	`)`
`143`	`143`	`if keep_distances:`
`144`	`144`	`return (node[1], node[0])`