refactor: Apply suggestion from @copilot

-
  #245 (comment)
-
  #245 (comment)

Author: gerardo-navarro

lib/omniauth/strategies/saml.rb

@@ -184,8 +184,6 @@ def valid_slo_relay_state?(relay_state)
       end
 
       def call_slo_relay_state_validator(validator, relay_state)
-        arity = validator.arity
-
         return validator.call if validator.arity.zero?
         return validator.call(relay_state) if validator.arity == 1
         validator.call(relay_state, request)

spec/omniauth/strategies/saml_spec.rb

@@ -332,7 +332,7 @@
       subject(:post_slo_response) { post "/auth/saml/slo", params, opts }
 
       context "when relay state is relative" do
-        let(:params) {super().merge(RelayState: "/signed-out")}
+        let(:params) { super().merge(RelayState: "/signed-out") }
 
         it "redirects to the relaystate" do
           post_slo_response
@@ -343,7 +343,7 @@
       end
 
       context "when relay state is an absolute https URL" do
-        let(:params) {super().merge(RelayState: "https://example.com/")}
+        let(:params) { super().merge(RelayState: "https://example.com/") }
 
         it "redirects without a location header" do
           post_slo_response
@@ -357,31 +357,31 @@
         let(:saml_options) { super().merge(slo_default_relay_state: '/signed-out') }
 
         context "when response relay state is valid" do
-          let(:params) {super().merge(RelayState: "/safe/logout")}
+          let(:params) { super().merge(RelayState: "/safe/logout") }
 
-          it {is_expected.to be_redirect.and have_attributes(location: '/safe/logout') }
+          it { is_expected.to be_redirect.and have_attributes(location: '/safe/logout') }
         end
 
         context "when response relay state is invalid" do
-          let(:params) {super().merge(RelayState: "javascript:alert(1)")}
+          let(:params) { super().merge(RelayState: "javascript:alert(1)") }
 
-          it {is_expected.to be_redirect.and have_attributes(location: '/signed-out') }
+          it { is_expected.to be_redirect.and have_attributes(location: '/signed-out') }
         end
       end
 
       context 'when slo_default_relay_state is blank' do
         let(:saml_options) { super().merge(slo_default_relay_state: nil) }
 
         context "when response relay state is valid" do
-          let(:params) {super().merge(RelayState: "/safe/logout")}
+          let(:params) { super().merge(RelayState: "/safe/logout") }
 
-          it {is_expected.to be_redirect.and have_attributes(location: '/safe/logout') }
+          it { is_expected.to be_redirect.and have_attributes(location: '/safe/logout') }
         end
 
         context "when response relay state is invalid" do
-          let(:params) {super().merge(RelayState: "javascript:alert(1)")}
+          let(:params) { super().merge(RelayState: "javascript:alert(1)") }
 
-          it {is_expected.to be_redirect.and have_attributes(location: nil) }
+          it { is_expected.to be_redirect.and have_attributes(location: nil) }
         end
       end
     end