Skip to content

Commit e60bc2e

Browse files
committed
fix: messy promises, TODO - more err handling cleanup
1 parent d03014a commit e60bc2e

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

dist/index.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
/***/ ((module, __unused_webpack_exports, __nccwpck_require__) => {
66

77
const {Octokit} = __nccwpck_require__(1231)
8+
const core = __nccwpck_require__(2186);
89
const octokit = new Octokit();
910

1011
function uniq(a) {
@@ -34,14 +35,17 @@ async function getRepoTeams(org, repo) {
3435
return Promise.resolve(data
3536
.filter(team => teamHasWrite(team.permission))
3637
.map(team => team.name)
37-
);
38+
).catch(err => { core.setFailed(err) });
3839
}
3940

4041
async function getUserIsApprover(org, repo, user) {
4142
const repoTeams = await getRepoTeams(org, repo);
4243
teamsArrays = await Promise.all(
4344
repoTeams.map(team => getTeamUsers(team))
44-
);
45+
).catch((err) => {
46+
console.error(err)
47+
core.setFailed(err);
48+
});
4549

4650
const allApprovingUsers = teamsArrays
4751
.reduce((acc, arr) => acc.concat(arr));

lib/helpers.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
const {Octokit} = require('@octokit/action')
2+
const core = require('@actions/core');
23
const octokit = new Octokit();
34

45
function uniq(a) {
@@ -28,14 +29,17 @@ async function getRepoTeams(org, repo) {
2829
return Promise.resolve(data
2930
.filter(team => teamHasWrite(team.permission))
3031
.map(team => team.name)
31-
);
32+
).catch(err => { core.setFailed(err) });
3233
}
3334

3435
async function getUserIsApprover(org, repo, user) {
3536
const repoTeams = await getRepoTeams(org, repo);
3637
teamsArrays = await Promise.all(
3738
repoTeams.map(team => getTeamUsers(team))
38-
);
39+
).catch((err) => {
40+
console.error(err)
41+
core.setFailed(err);
42+
});
3943

4044
const allApprovingUsers = teamsArrays
4145
.reduce((acc, arr) => acc.concat(arr));

0 commit comments

Comments
 (0)