Refactor: Rename ScreenMemoryUpdatedEvent to MemoryUpdatedEvent and update the related event logic

Author: voytas

src/Spectron.Emulation/Devices/Memory/IEmulatorMemory.cs

@@ -2,7 +2,7 @@
 
 namespace OldBit.Spectron.Emulation.Devices.Memory;
 
-public delegate void ScreenMemoryUpdatedEvent(Word address);
+public delegate void MemoryUpdatedEvent(Word address);
 
 internal interface IEmulatorMemory : IMemory, IDevice
 {
@@ -12,5 +12,5 @@ void Reset() { }
 
     void ShadowRom(IRomMemory? shadowRom);
 
-    event ScreenMemoryUpdatedEvent? ScreenMemoryUpdated;
+    event MemoryUpdatedEvent? MemoryUpdated;
 }

src/Spectron.Emulation/Devices/Memory/Memory128K.cs

@@ -75,10 +75,7 @@ public void Write(Word address, byte data)
 
         bank[relativeAddress] = data;
 
-        if (address < 0x5B00)
-        {
-            ScreenMemoryUpdated?.Invoke(address);
-        }
+        MemoryUpdated?.Invoke(address);
     }
 
     public void ShadowRom(IRomMemory? shadowRom)
@@ -88,7 +85,7 @@ public void ShadowRom(IRomMemory? shadowRom)
         _activeRom = shadowRom ?? RomBank1;
     }
 
-    public event ScreenMemoryUpdatedEvent? ScreenMemoryUpdated;
+    public event MemoryUpdatedEvent? MemoryUpdated;
 
     public void WritePort(Word address, byte data)
     {

src/Spectron.Emulation/Devices/Memory/Memory16K.cs

@@ -43,13 +43,10 @@ public void Write(Word address, byte data)
 
         _memory[address] = data;
 
-        if (address < 0x5B00)
-        {
-            ScreenMemoryUpdated?.Invoke(address);
-        }
+        MemoryUpdated?.Invoke(address);
     }
 
     public void ShadowRom(IRomMemory? shadowRom) => _activeRom = shadowRom ?? _normalRom;
 
-    public event ScreenMemoryUpdatedEvent? ScreenMemoryUpdated;
+    public event MemoryUpdatedEvent? MemoryUpdated;
 }

src/Spectron.Emulation/Devices/Memory/Memory48K.cs

@@ -38,13 +38,10 @@ public void Write(Word address, byte data)
 
         _memory[address] = data;
 
-        if (address < 0x5B00)
-        {
-            ScreenMemoryUpdated?.Invoke(address);
-        }
+        MemoryUpdated?.Invoke(address);
     }
 
     public void ShadowRom(IRomMemory? shadowRom) => _activeRom = shadowRom ?? _normalRom;
 
-    public event ScreenMemoryUpdatedEvent? ScreenMemoryUpdated;
+    public event MemoryUpdatedEvent? MemoryUpdated;
 }

src/Spectron.Emulation/Emulator.cs

@@ -205,7 +205,13 @@ private void OnTimerElapsed(EventArgs e)
 
     private void SetupEventHandlers()
     {
-        _memory.ScreenMemoryUpdated += address => ScreenBuffer.UpdateScreen(address);
+        _memory.MemoryUpdated += address =>
+        {
+            if (address < 0x5B00)
+            {
+                ScreenBuffer.UpdateScreen(address);
+            }
+        };
         Cpu.Clock.TicksAdded += (_, previousFrameTicks, _) => ScreenBuffer.UpdateScreen(previousFrameTicks);
         Cpu.BeforeInstruction += BeforeInstruction;
         UlaPlus.ActiveChanged += (_) => _invalidateScreen = true;