Bug in smallest_diminesions_yet calculation?

[fdncred]

I believe this for loop code

rust-term-grid/src/lib.rs

Line 383 in 99396dd

for num_lines in (1 .. theoretical_max_num_lines).rev() {

should be inclusive

for num_lines in (1..=theoretical_max_num_lines).rev() {

I ran into this problem where the output should've been 2 rows but it would never output 2 rows. It would always fail and return the initialized value of None for smallest_dimensions_yet.

Please confirm.

Thanks!

[tertsdiepraam]

Hi! We're also hitting this issue with the uutils ls, preventing us from upgrading to 0.2.0 and using the alignment feature. I just wanted to mention that the proposed fix passes the uutils tests and it'd be great to see this implemented.