fabtests/unit: Add negative testing for fi_av_lookup

Premise: AV opened with num_good_addr + 1
Insert num_good_addr addresses so 0->num_good_addr-1 are taken

Negative Tests:
Case 1: Lookup addr of non-inserted location in opened range
Lookup fi_addr num_good_addr
Expected Result: -EINVAL

Case 2: Lookup addr outside of av_open range
Lookup fi_addr num_good_addr + 32
Expected Result: -EINVAL

Case 3: Lookup fi_addr UINT_MAX
Expected Result: -EINVAL

Case 4: Remove an addr and then lookup its location
Remove fi_addr 0 -> lookup fi_addr 0
Expected Result: -EINVAL


Signed-off-by: Zach Dworkin <[email protected]>

Author: zachdworkin

fabtests/unit/av_test.c

@@ -713,6 +713,121 @@ av_lookup_good(void)
 	return TEST_RET_VAL(ret, testret);
 }
 
+static int
+av_lookup_bad(void)
+{
+	int testret;
+	int ret;
+	int i;
+	struct fid_av *av = NULL;
+	struct fi_av_attr attr;
+	uint8_t addrbuf[4096];
+	size_t buflen;
+	uint8_t lookup_buf[4096];
+	size_t lookup_len;
+	fi_addr_t *fi_addr;
+
+	testret = FAIL;
+
+	fi_addr = calloc(num_good_addr, sizeof(fi_addr_t));
+	if (!fi_addr) {
+		sprintf(err_buf, "malloc fi_addr failed");
+		ret = -FI_ENOMEM;
+		goto fail;
+	}
+
+	memset(&attr, 0, sizeof(attr));
+	attr.type = av_type;
+	attr.count = num_good_addr + 1;
+
+	av = NULL;
+	ret = fi_av_open(domain, &attr, &av, NULL);
+	if (ret != 0) {
+		sprintf(err_buf, "fi_av_open(%s) = %d, %s",
+			fi_tostr(&av_type, FI_TYPE_AV_TYPE), ret,
+			fi_strerror(-ret));
+		goto fail;
+	}
+
+	for (i = 0; i < num_good_addr + 1; i++)
+		fi_addr[i] = FI_ADDR_NOTAVAIL;
+
+	buflen = sizeof(addrbuf);
+	ret = av_create_address_list(good_address, 0, num_good_addr, addrbuf, 0,
+				     buflen);
+	if (ret < 0)
+		goto fail;
+
+	ret = fi_av_insert(av, addrbuf, num_good_addr, fi_addr, 0, NULL);
+	if (ret != num_good_addr) {
+		sprintf(err_buf, "fi_av_insert ret=%d, %s", ret,
+			fi_strerror(-ret));
+		goto fail;
+	}
+
+	for (i = 0; i < num_good_addr; i++) {
+		if (fi_addr[i] == FI_ADDR_NOTAVAIL) {
+			sprintf(err_buf, "fi_av_insert failed ret=%d, %s", ret,
+				fi_strerror(-ret));
+		}
+	}
+
+	/* case 1: lookup addr of non-inserted location in av open range */
+	memset(lookup_buf, 0, sizeof(lookup_buf));
+	lookup_len = sizeof(lookup_buf);
+	ret = fi_av_lookup(av, (fi_addr_t) num_good_addr, &lookup_buf,
+			   &lookup_len);
+	if (ret >= 0) {
+		sprintf(err_buf, "fi_av_lookup of non-inserted location "
+			"ret=%d, should be < 0", ret);
+		goto fail;
+	}
+
+	/* case 2: lookup addr outside of av open range */
+	memset(lookup_buf, 0, sizeof(lookup_buf));
+	lookup_len = sizeof(lookup_buf);
+	ret = fi_av_lookup(av, (fi_addr_t) (num_good_addr + 32), &lookup_buf,
+			   &lookup_len);
+	if (ret >= 0) {
+		sprintf(err_buf, "fi_av_lookup addr outside of range ret=%d, "
+			"should be < 0", ret);
+		goto fail;
+	}
+
+	/* case 3: lookup UINT_MAX*/
+	memset(lookup_buf, 0, sizeof(lookup_buf));
+	lookup_len = sizeof(lookup_buf);
+	ret = fi_av_lookup(av, (fi_addr_t) UINT64_MAX, &lookup_buf,
+			   &lookup_len);
+	if (ret >= 0) {
+		sprintf(err_buf, "fi_av_lookup of UINT64_MAX ret=%d, should "
+			"be < 0", ret);
+		goto fail;
+	}
+
+	/* case 4: remove an addr and then lookup its location */
+	memset(lookup_buf, 0, sizeof(lookup_buf));
+	lookup_len = sizeof(lookup_buf);
+	ret = fi_av_remove(av, &fi_addr[0], 1, 0);
+	if (ret != FI_SUCCESS) {
+		sprintf(err_buf, "fi_av_remove ret=%d, %s", ret,
+			fi_strerror(-ret));
+		goto fail;
+	}
+	ret = fi_av_lookup(av, 0, &lookup_buf, &lookup_len);
+	if (ret >= 0) {
+		sprintf(err_buf, "fi_av_lookup of removed addr ret=%d, "
+			"should be < 0", ret);
+		goto fail;
+	}
+
+	testret = PASS;
+fail:
+	FT_CLOSE_FID(av);
+	free(fi_addr);
+	return TEST_RET_VAL(ret, testret);
+}
+
 struct test_entry test_array_good[] = {
 	TEST_ENTRY(av_open_close, "Test open and close AVs of varying sizes"),
 	TEST_ENTRY(av_good, "Test AV insert with good address"),
@@ -728,6 +843,9 @@ struct test_entry test_array_bad[] = {
 		   "Test AV insert of 1 good and 1 bad address"),
 	TEST_ENTRY(av_goodbad_vector_sync_err,
 		   "Test AV insert of 1 good, 1 bad address using FI_SYNC_ERR"),
+	TEST_ENTRY(av_lookup_bad,
+		   "Test lookup of address not in AV after inserting good "
+		   "addresses"),
 	{ NULL, "" }
 };