prov/udp: cleanup CQ parameters

Remove passing around RX CQ flags and buffer since they are not needed
and always 0/NULL.
UDP does not support any features that would report any additional flags
and does not support FI_MULTI_RECV which is the only case where the buf
field is valid.
This is not a functional fix and just cleans up the code a bit

Signed-off-by: Alexia Ingerson <[email protected]>

Author: aingerson

prov/udp/src/udpx.h

@@ -91,8 +91,8 @@ struct udpx_ep_entry {
 OFI_DECLARE_CIRQUE(struct udpx_ep_entry, udpx_rx_cirq);
 
 struct udpx_ep;
-typedef void (*udpx_rx_comp_func)(struct udpx_ep *ep, void *context,
-		uint64_t flags, size_t len, void *buf, void *addr);
+typedef void (*udpx_rx_comp_func)(struct udpx_ep *ep, void *context, size_t len,
+				  void *addr);
 typedef void (*udpx_tx_comp_func)(struct udpx_ep *ep, void *context);
 
 struct udpx_ep {

prov/udp/src/udpx_ep.c

@@ -234,41 +234,41 @@ static void udpx_tx_comp_signal(struct udpx_ep *ep, void *context)
 	ep->util_ep.tx_cq->wait->signal(ep->util_ep.tx_cq->wait);
 }
 
-static void udpx_rx_comp(struct udpx_ep *ep, void *context, uint64_t flags,
-			 size_t len, void *buf, void *addr)
+static void udpx_rx_comp(struct udpx_ep *ep, void *context, size_t len,
+			 void *addr)
 {
 	struct fi_cq_tagged_entry *comp;
 
 	assert(!ofi_cirque_isfull(ep->util_ep.rx_cq->cirq));
 
 	comp = ofi_cirque_next(ep->util_ep.rx_cq->cirq);
 	comp->op_context = context;
-	comp->flags = FI_RECV | flags;
+	comp->flags = FI_RECV;
 	comp->len = len;
-	comp->buf = buf;
+	comp->buf = NULL;
 	comp->data = 0;
 	ofi_cirque_commit(ep->util_ep.rx_cq->cirq);
 }
 
-static void udpx_rx_src_comp(struct udpx_ep *ep, void *context, uint64_t flags,
-			     size_t len, void *buf, void *addr)
+static void udpx_rx_src_comp(struct udpx_ep *ep, void *context, size_t len,
+			     void *addr)
 {
 	ep->util_ep.rx_cq->src[ofi_cirque_windex(ep->util_ep.rx_cq->cirq)] =
 			ofi_ip_av_get_fi_addr(ep->util_ep.av, addr);
-	udpx_rx_comp(ep, context, flags, len, buf, addr);
+	udpx_rx_comp(ep, context, len, addr);
 }
 
-static void udpx_rx_comp_signal(struct udpx_ep *ep, void *context,
-			uint64_t flags, size_t len, void *buf, void *addr)
+static void udpx_rx_comp_signal(struct udpx_ep *ep, void *context, size_t len,
+				void *addr)
 {
-	udpx_rx_comp(ep, context, flags, len, buf, addr);
+	udpx_rx_comp(ep, context, len, addr);
 	ep->util_ep.rx_cq->wait->signal(ep->util_ep.rx_cq->wait);
 }
 
 static void udpx_rx_src_comp_signal(struct udpx_ep *ep, void *context,
-			uint64_t flags, size_t len, void *buf, void *addr)
+				    size_t len, void *addr)
 {
-	udpx_rx_src_comp(ep, context, flags, len, buf, addr);
+	udpx_rx_src_comp(ep, context, len, addr);
 	ep->util_ep.rx_cq->wait->signal(ep->util_ep.rx_cq->wait);
 }
 
@@ -298,7 +298,7 @@ static void udpx_ep_progress(struct util_ep *util_ep)
 
 	ret = ofi_recvmsg_udp(ep->sock, &hdr, 0);
 	if (ret >= 0) {
-		ep->rx_comp(ep, entry->context, 0, ret, NULL, &addr);
+		ep->rx_comp(ep, entry->context, ret, &addr);
 		ofi_cirque_discard(ep->rxq);
 	}
 out: