From c02d71cbcd6ca9a449341a11167b8b0313438f81 Mon Sep 17 00:00:00 2001
From: hapt-odoo <hapt@odoo.com>
Date: Mon, 30 Jun 2025 18:29:52 +0530
Subject: [PATCH 1/4] [ADD] new_producttype: created wizard in sale.order,line
 and created new fields

In the new_producttype module created in the product form to add
sub-products field in specific products and in sale.order.line added a button
in that by clicking on it, created a wizard of sub_product linked with
the main product.
---
 new_producttype/__init__.py                   |  2 ++
 new_producttype/__manifest__.py               | 16 ++++++++++++
 new_producttype/models/__init__.py            |  2 ++
 new_producttype/models/product_template.py    | 25 +++++++++++++++++++
 new_producttype/models/sale_order_line.py     | 22 ++++++++++++++++
 new_producttype/security/ir.model.access.csv  |  3 +++
 new_producttype/views/product_views.xml       | 14 +++++++++++
 new_producttype/views/sale_order_view.xml     | 17 +++++++++++++
 new_producttype/wizard/__init__.py            |  2 ++
 .../wizard/sub_product_kit_wizard.py          | 11 ++++++++
 .../wizard/sub_product_kit_wizard_view.xml    | 24 ++++++++++++++++++
 .../wizard/sub_product_line_kit_wizard.py     | 10 ++++++++
 12 files changed, 148 insertions(+)
 create mode 100644 new_producttype/__init__.py
 create mode 100644 new_producttype/__manifest__.py
 create mode 100644 new_producttype/models/__init__.py
 create mode 100644 new_producttype/models/product_template.py
 create mode 100644 new_producttype/models/sale_order_line.py
 create mode 100644 new_producttype/security/ir.model.access.csv
 create mode 100644 new_producttype/views/product_views.xml
 create mode 100644 new_producttype/views/sale_order_view.xml
 create mode 100644 new_producttype/wizard/__init__.py
 create mode 100644 new_producttype/wizard/sub_product_kit_wizard.py
 create mode 100644 new_producttype/wizard/sub_product_kit_wizard_view.xml
 create mode 100644 new_producttype/wizard/sub_product_line_kit_wizard.py

diff --git a/new_producttype/__init__.py b/new_producttype/__init__.py
new file mode 100644
index 00000000000..9b4296142f4
--- /dev/null
+++ b/new_producttype/__init__.py
@@ -0,0 +1,2 @@
+from . import models
+from . import wizard
diff --git a/new_producttype/__manifest__.py b/new_producttype/__manifest__.py
new file mode 100644
index 00000000000..7595c7562ec
--- /dev/null
+++ b/new_producttype/__manifest__.py
@@ -0,0 +1,16 @@
+{
+    'name': "New Product Type",
+    'category': '',
+    'version': '0.1',
+    'depends': ['sale'],
+    'sequence': 1,
+    'application': True,
+    'installable': True,
+    'data': [
+        'security/ir.model.access.csv',
+        "wizard/sub_product_kit_wizard_view.xml",
+        "views/product_views.xml",
+        "views/sale_order_view.xml",
+    ],
+    'license': 'AGPL-3'
+}
diff --git a/new_producttype/models/__init__.py b/new_producttype/models/__init__.py
new file mode 100644
index 00000000000..83527162d00
--- /dev/null
+++ b/new_producttype/models/__init__.py
@@ -0,0 +1,2 @@
+from . import product_template
+from . import sale_order_line
diff --git a/new_producttype/models/product_template.py b/new_producttype/models/product_template.py
new file mode 100644
index 00000000000..f1ec80566f9
--- /dev/null
+++ b/new_producttype/models/product_template.py
@@ -0,0 +1,25 @@
+from odoo import fields, models, api
+from odoo.exceptions import ValidationError
+
+
+class ProductTemplate(models.Model):
+    _inherit = 'product.template'
+
+    is_kit = fields.Boolean(default=False, string='Is kit')
+    sub_products_ids = fields.Many2many('product.product', string='Sub products')
+
+    @api.constrains("sub_products_ids")
+    def check_sub_product_not_itself(self):
+        for record in self:
+            if record.id in record.sub_products_ids.mapped("product_tmpl_id.id"):
+                raise ValidationError(
+                    "A product cannot be added as its own sub-product"
+                )
+
+    @api.constrains("sub_products_ids", "is_kit")
+    def check_sub_product(self):
+        for record in self:
+            if record.is_kit and not record.sub_products_ids:
+                raise ValidationError(
+                    "A kit product must have at least one sub-product"
+                )
diff --git a/new_producttype/models/sale_order_line.py b/new_producttype/models/sale_order_line.py
new file mode 100644
index 00000000000..e30416582cb
--- /dev/null
+++ b/new_producttype/models/sale_order_line.py
@@ -0,0 +1,22 @@
+from odoo import fields, models
+
+
+class SaleOrderLine(models.Model):
+    _inherit = 'sale.order.line'
+
+    is_kit = fields.Boolean(string='Is kit', related='product_id.is_kit')
+    parent_line_id = fields.Many2one("sale.order.line", ondelete="cascade")
+    sub_products_ids = fields.Many2many(
+        "product.product",
+        related="product_template_id.sub_products_ids",
+        string="Sub Products",
+    )
+
+    def action_open_kit_wizard(self):
+        return {
+            'type': 'ir.actions.act_window',
+            'name': 'sub.product.kit.wizard.view',
+            'res_model': 'sub.product.kit.wizard',
+            'view_mode': 'form',
+            'target': 'new',
+        }
diff --git a/new_producttype/security/ir.model.access.csv b/new_producttype/security/ir.model.access.csv
new file mode 100644
index 00000000000..2ec380ca018
--- /dev/null
+++ b/new_producttype/security/ir.model.access.csv
@@ -0,0 +1,3 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+access_sub_product_kit_wizard,access_sub_product_kit_wizard,model_sub_product_kit_wizard,base.group_user,1,1,1,1
+access_sub_product_line_kit_wizard,access_sub_product_line_kit_wizard,model_sub_product_line_kit_wizard,base.group_user,1,1,1,1
diff --git a/new_producttype/views/product_views.xml b/new_producttype/views/product_views.xml
new file mode 100644
index 00000000000..2924bde217e
--- /dev/null
+++ b/new_producttype/views/product_views.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<odoo>
+    <record id="product_template_form_view_inherit" model="ir.ui.view">
+        <field name="name">product.template.form.view.inherit</field>
+        <field name="model">product.template</field>
+        <field name="inherit_id" ref="product.product_template_form_view"/>
+        <field name="arch" type="xml">
+            <xpath expr="//page//group[@name='group_general']" position="inside">
+                <field name="is_kit"/>
+                <field name="sub_products_ids" widget="many2many_tags" invisible="is_kit == False"/>
+            </xpath>
+        </field>
+    </record>
+</odoo>
diff --git a/new_producttype/views/sale_order_view.xml b/new_producttype/views/sale_order_view.xml
new file mode 100644
index 00000000000..ab9dd32a3a6
--- /dev/null
+++ b/new_producttype/views/sale_order_view.xml
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<odoo>
+    <record id="view_order_form_inherit_sub_product" model="ir.ui.view">
+        <field name="name">view.order.form.inherit.sub.product</field>
+        <field name="model">sale.order</field>
+        <field name="inherit_id" ref="sale.view_order_form"/>
+        <field name="arch" type="xml">
+            <xpath expr="//list//field[@name='product_template_id']" position="after">
+                <button name="action_open_kit_wizard"
+                        type="object"
+                        string="Open Kit"
+                        invisible="not is_kit or state=='sale'"
+                />
+            </xpath>
+        </field>
+    </record>
+</odoo>
diff --git a/new_producttype/wizard/__init__.py b/new_producttype/wizard/__init__.py
new file mode 100644
index 00000000000..2b0626748af
--- /dev/null
+++ b/new_producttype/wizard/__init__.py
@@ -0,0 +1,2 @@
+from . import sub_product_kit_wizard
+from . import sub_product_line_kit_wizard
diff --git a/new_producttype/wizard/sub_product_kit_wizard.py b/new_producttype/wizard/sub_product_kit_wizard.py
new file mode 100644
index 00000000000..3f359863855
--- /dev/null
+++ b/new_producttype/wizard/sub_product_kit_wizard.py
@@ -0,0 +1,11 @@
+from odoo import fields, models
+
+
+class SubProductKitWizard(models.TransientModel):
+    _name = 'sub.product.kit.wizard'
+
+    sale_order_line_id = fields.Many2one('sale.order.line')
+    sub_products_ids = fields.One2many('sub.product.line.kit.wizard', 'sub_products_line_id')
+
+    def action_confirm(self):
+        pass
diff --git a/new_producttype/wizard/sub_product_kit_wizard_view.xml b/new_producttype/wizard/sub_product_kit_wizard_view.xml
new file mode 100644
index 00000000000..17fcf647b27
--- /dev/null
+++ b/new_producttype/wizard/sub_product_kit_wizard_view.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<odoo>
+    <record id="sub_product_kit_wizard_view" model="ir.ui.view">
+        <field name="name">sub.product.kit.wizard.view</field>
+        <field name="model">sub.product.kit.wizard</field>
+        <field name="arch" type="xml">
+            <form string="Sub-Products">
+                <sheet>
+                    <field name="sub_products_ids">
+                        <list editable="bottom">
+                            <field name="product_id"/>
+                            <field name="quantity"/>
+                            <field name="price"/>
+                        </list>
+                    </field>
+                    <footer>
+                        <button name="action_confirm" type="object" string="Confirm" class="btn btn-primary"/>
+                        <button string="Cancel" class="btn-secondary" special="cancel"/>
+                    </footer>
+                </sheet>
+            </form>
+        </field>
+    </record>
+</odoo>
diff --git a/new_producttype/wizard/sub_product_line_kit_wizard.py b/new_producttype/wizard/sub_product_line_kit_wizard.py
new file mode 100644
index 00000000000..5e6072327f0
--- /dev/null
+++ b/new_producttype/wizard/sub_product_line_kit_wizard.py
@@ -0,0 +1,10 @@
+from odoo import fields, models
+
+
+class SubProductLineKitWizard(models.TransientModel):
+    _name = 'sub.product.line.kit.wizard'
+
+    sub_products_line_id = fields.Many2one('sub.product.kit.wizard')
+    product_id = fields.Many2one('product.product', required=True)
+    quantity = fields.Float(default=0.0)
+    price = fields.Float(default=0)

From 04e374644e5e8fb53b63ff1a53674060dd1189f9 Mon Sep 17 00:00:00 2001
From: hapt-odoo <hapt@odoo.com>
Date: Tue, 1 Jul 2025 18:16:29 +0530
Subject: [PATCH 2/4] [IMP] new_producttype: added sub_products directly in
 sale.order.line

In the new_producttype module, get the sub-products associated with
the product on sale.order.line using wizard and added that the sub_products
directly in sale.order.line and made the parent line ondelete=cascade
to delete sub_product_lines on deletion of parent_line
---
 new_producttype/__manifest__.py               |  2 +-
 new_producttype/models/__init__.py            |  1 +
 new_producttype/models/sale_order.py          |  7 ++
 new_producttype/models/sale_order_line.py     |  3 +-
 new_producttype/views/sale_order_view.xml     | 22 +++++-
 .../wizard/sub_product_kit_wizard.py          | 71 ++++++++++++++++++-
 .../wizard/sub_product_kit_wizard_view.xml    |  6 +-
 7 files changed, 102 insertions(+), 10 deletions(-)
 create mode 100644 new_producttype/models/sale_order.py

diff --git a/new_producttype/__manifest__.py b/new_producttype/__manifest__.py
index 7595c7562ec..fab165d27ee 100644
--- a/new_producttype/__manifest__.py
+++ b/new_producttype/__manifest__.py
@@ -7,7 +7,7 @@
     'application': True,
     'installable': True,
     'data': [
-        'security/ir.model.access.csv',
+        "security/ir.model.access.csv",
         "wizard/sub_product_kit_wizard_view.xml",
         "views/product_views.xml",
         "views/sale_order_view.xml",
diff --git a/new_producttype/models/__init__.py b/new_producttype/models/__init__.py
index 83527162d00..8f2f8c0cbc1 100644
--- a/new_producttype/models/__init__.py
+++ b/new_producttype/models/__init__.py
@@ -1,2 +1,3 @@
 from . import product_template
 from . import sale_order_line
+from . import sale_order
diff --git a/new_producttype/models/sale_order.py b/new_producttype/models/sale_order.py
new file mode 100644
index 00000000000..64b6caff4ce
--- /dev/null
+++ b/new_producttype/models/sale_order.py
@@ -0,0 +1,7 @@
+from odoo import models, fields
+
+
+class SaleOrder(models.Model):
+    _inherit = 'sale.order'
+
+    print_report = fields.Boolean(string="Print in Report")
diff --git a/new_producttype/models/sale_order_line.py b/new_producttype/models/sale_order_line.py
index e30416582cb..9103f1e837f 100644
--- a/new_producttype/models/sale_order_line.py
+++ b/new_producttype/models/sale_order_line.py
@@ -5,12 +5,13 @@ class SaleOrderLine(models.Model):
     _inherit = 'sale.order.line'
 
     is_kit = fields.Boolean(string='Is kit', related='product_id.is_kit')
-    parent_line_id = fields.Many2one("sale.order.line", ondelete="cascade")
+    main_product_line_id = fields.Many2one("sale.order.line", ondelete="cascade")
     sub_products_ids = fields.Many2many(
         "product.product",
         related="product_template_id.sub_products_ids",
         string="Sub Products",
     )
+    last_price = fields.Float()
 
     def action_open_kit_wizard(self):
         return {
diff --git a/new_producttype/views/sale_order_view.xml b/new_producttype/views/sale_order_view.xml
index ab9dd32a3a6..b01a32dd595 100644
--- a/new_producttype/views/sale_order_view.xml
+++ b/new_producttype/views/sale_order_view.xml
@@ -8,10 +8,28 @@
             <xpath expr="//list//field[@name='product_template_id']" position="after">
                 <button name="action_open_kit_wizard"
                         type="object"
-                        string="Open Kit"
-                        invisible="not is_kit or state=='sale'"
+                        string="Add Sub-Products"
+                        invisible="not is_kit or state=='sale' or main_product_line_id"
                 />
             </xpath>
+            <xpath expr="//field[@name='order_line']/list" position="attributes">
+                <attribute name="decoration-warning">main_product_line_id</attribute>
+            </xpath>
+            <xpath expr="//list//field[@name='product_template_id']" position="attributes">
+                <attribute name="readonly">main_product_line_id</attribute>
+            </xpath>
+            <xpath expr="//list//field[@name='product_uom_qty']" position="attributes">
+                <attribute name="readonly">main_product_line_id</attribute>
+            </xpath>
+            <xpath expr="//list//field[@name='price_unit']" position="attributes">
+                <attribute name="readonly">main_product_line_id</attribute>
+            </xpath>
+            <xpath expr="//list//field[@name='tax_id']" position="attributes">
+                <attribute name="readonly">main_product_line_id</attribute>
+            </xpath>
+            <xpath expr="//group//field[@name='payment_term_id']" position="after">
+                <field name="print_report"/>
+            </xpath>
         </field>
     </record>
 </odoo>
diff --git a/new_producttype/wizard/sub_product_kit_wizard.py b/new_producttype/wizard/sub_product_kit_wizard.py
index 3f359863855..3b03d6d0144 100644
--- a/new_producttype/wizard/sub_product_kit_wizard.py
+++ b/new_producttype/wizard/sub_product_kit_wizard.py
@@ -1,11 +1,76 @@
-from odoo import fields, models
+from odoo import fields, models, api, Command
 
 
 class SubProductKitWizard(models.TransientModel):
     _name = 'sub.product.kit.wizard'
 
-    sale_order_line_id = fields.Many2one('sale.order.line')
+    sale_order_line_id = fields.Many2one('sale.order.line', required=True)
     sub_products_ids = fields.One2many('sub.product.line.kit.wizard', 'sub_products_line_id')
 
+    @api.model
+    def default_get(self, fields_list):
+        res = super().default_get(fields_list)
+        sale_order_line_id = self._context.get("active_id")
+        if sale_order_line_id:
+            sale_order_line = self.env["sale.order.line"].browse(sale_order_line_id)
+            existing_lines = self.env["sale.order.line"].search(
+                [("main_product_line_id", "=", sale_order_line_id)]
+            )
+            line_values = []
+            if existing_lines:
+                for sub_product in existing_lines:
+                    curr_product = self.env["sub.product.line.kit.wizard"].create(
+                        {
+                            "product_id": sub_product.product_id.id,
+                            "price": sub_product.price_unit,
+                            "quantity": sub_product.product_uom_qty,
+                        }
+                    )
+                    line_values.append(Command.link(curr_product.id))
+            else:
+                for sub_product in sale_order_line.product_id.sub_products_ids:
+                    curr_product = self.env["sub.product.line.kit.wizard"].create(
+                        {
+                            "product_id": sub_product.id,
+                            "price": sub_product.list_price,
+                            "quantity": 1,
+                        }
+                    )
+                    line_values.append(Command.link(curr_product.id))
+            res["sub_products_ids"] = line_values
+            res["sale_order_line_id"] = sale_order_line_id
+        return res
+
     def action_confirm(self):
-        pass
+        total_of_sub_product_price = 0
+        for rec in self.sub_products_ids:
+            existing_lines = self.env["sale.order.line"].search(
+                [
+                    ("main_product_line_id", "=", self.sale_order_line_id.id),
+                    ("product_id", "=", rec.product_id.id),
+                    ("order_id", "=", self.sale_order_line_id.order_id.id)
+                ],
+                limit=1,
+            )
+            if existing_lines:
+                existing_lines.product_uom_qty = rec.quantity
+                existing_lines.last_price = rec.price
+                existing_lines.price_unit = 0
+            else:
+                self.env["sale.order.line"].create(
+                    {
+                        "order_id": self.sale_order_line_id.order_id.id,
+                        "product_id": rec.product_id.id,
+                        "product_uom_qty": rec.quantity,
+                        "last_price": rec.price,
+                        "price_unit": 0,
+                        "main_product_line_id": self.sale_order_line_id.id,
+                    }
+                )
+            total_of_sub_product_price += (rec.quantity * rec.price)
+        total_of_sub_product_price += (
+                self.sale_order_line_id.product_uom_qty
+                * self.sale_order_line_id.product_template_id.list_price
+        )
+        self.sale_order_line_id.price_unit = total_of_sub_product_price
+        return True
diff --git a/new_producttype/wizard/sub_product_kit_wizard_view.xml b/new_producttype/wizard/sub_product_kit_wizard_view.xml
index 17fcf647b27..19359466c21 100644
--- a/new_producttype/wizard/sub_product_kit_wizard_view.xml
+++ b/new_producttype/wizard/sub_product_kit_wizard_view.xml
@@ -7,14 +7,14 @@
             <form string="Sub-Products">
                 <sheet>
                     <field name="sub_products_ids">
-                        <list editable="bottom">
-                            <field name="product_id"/>
+                        <list create="false" editable="bottom">
+                            <field name="product_id" readonly="1"/>
                             <field name="quantity"/>
                             <field name="price"/>
                         </list>
                     </field>
                     <footer>
-                        <button name="action_confirm" type="object" string="Confirm" class="btn btn-primary"/>
+                        <button name="action_confirm" class="btn btn-primary" type="object" string="Confirm"/>
                         <button string="Cancel" class="btn-secondary" special="cancel"/>
                     </footer>
                 </sheet>

From 198d890bc6833d2522cc5245dffa3850e253ff57 Mon Sep 17 00:00:00 2001
From: hapt-odoo <hapt@odoo.com>
Date: Wed, 2 Jul 2025 11:58:36 +0530
Subject: [PATCH 3/4] [IMP] new_producttype:  Created sub-product template

In the new_producttype module , added sub_products in invoice
When the boolean is true, and also added sub_products in
customer preview.
---
 new_producttype/__manifest__.py                        | 2 ++
 new_producttype/report/sub_product_report.xml          | 8 ++++++++
 new_producttype/views/sub_product_customer_preview.xml | 8 ++++++++
 3 files changed, 18 insertions(+)
 create mode 100644 new_producttype/report/sub_product_report.xml
 create mode 100644 new_producttype/views/sub_product_customer_preview.xml

diff --git a/new_producttype/__manifest__.py b/new_producttype/__manifest__.py
index fab165d27ee..eddaecf752b 100644
--- a/new_producttype/__manifest__.py
+++ b/new_producttype/__manifest__.py
@@ -8,9 +8,11 @@
     'installable': True,
     'data': [
         "security/ir.model.access.csv",
+        "report/sub_product_report.xml",
         "wizard/sub_product_kit_wizard_view.xml",
         "views/product_views.xml",
         "views/sale_order_view.xml",
+        "views/sub_product_customer_preview.xml",
     ],
     'license': 'AGPL-3'
 }
diff --git a/new_producttype/report/sub_product_report.xml b/new_producttype/report/sub_product_report.xml
new file mode 100644
index 00000000000..3e705c34cfc
--- /dev/null
+++ b/new_producttype/report/sub_product_report.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<odoo>
+    <template id="report_sub_product_template" inherit_id="sale.report_saleorder_document">
+        <xpath expr="//tbody[@class='sale_tbody']/t/tr" position="attributes">
+            <attribute name="t-if">(doc.print_report) or (not line.main_product_line_id)</attribute>
+        </xpath>
+    </template>
+</odoo>
diff --git a/new_producttype/views/sub_product_customer_preview.xml b/new_producttype/views/sub_product_customer_preview.xml
new file mode 100644
index 00000000000..e661cffea5d
--- /dev/null
+++ b/new_producttype/views/sub_product_customer_preview.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<odoo>
+    <template id="sale_portal_templates_report_inherited" inherit_id="sale.sale_order_portal_content">
+        <xpath expr="//table[@id='sales_order_table']/tbody/t/tr" position="attributes">
+            <attribute name="t-if">(sale_order.print_report) or (not line.main_product_line_id)</attribute>
+        </xpath>
+    </template>
+</odoo>

From bf0b94acd726e426ed9d683271d7fae394e66bcc Mon Sep 17 00:00:00 2001
From: hapt-odoo <hapt@odoo.com>
Date: Fri, 11 Jul 2025 11:40:38 +0530
Subject: [PATCH 4/4] [IMP] new_producttype:  changes made in sub-product
 wizard

In the new_producttyoe module, optimized the code
In the sub-product wizard
---
 new_producttype/__manifest__.py               |  1 -
 new_producttype/models/sale_order_line.py     |  2 +-
 .../wizard/sub_product_kit_wizard.py          | 75 +++++++++++--------
 3 files changed, 43 insertions(+), 35 deletions(-)

diff --git a/new_producttype/__manifest__.py b/new_producttype/__manifest__.py
index eddaecf752b..c911da1919c 100644
--- a/new_producttype/__manifest__.py
+++ b/new_producttype/__manifest__.py
@@ -1,6 +1,5 @@
 {
     'name': "New Product Type",
-    'category': '',
     'version': '0.1',
     'depends': ['sale'],
     'sequence': 1,
diff --git a/new_producttype/models/sale_order_line.py b/new_producttype/models/sale_order_line.py
index 9103f1e837f..d1da7861180 100644
--- a/new_producttype/models/sale_order_line.py
+++ b/new_producttype/models/sale_order_line.py
@@ -5,7 +5,7 @@ class SaleOrderLine(models.Model):
     _inherit = 'sale.order.line'
 
     is_kit = fields.Boolean(string='Is kit', related='product_id.is_kit')
-    main_product_line_id = fields.Many2one("sale.order.line", ondelete="cascade")
+    main_product_line_id = fields.Many2one('sale.order.line', ondelete='cascade')
     sub_products_ids = fields.Many2many(
         "product.product",
         related="product_template_id.sub_products_ids",
diff --git a/new_producttype/wizard/sub_product_kit_wizard.py b/new_producttype/wizard/sub_product_kit_wizard.py
index 3b03d6d0144..4b60d9b2710 100644
--- a/new_producttype/wizard/sub_product_kit_wizard.py
+++ b/new_producttype/wizard/sub_product_kit_wizard.py
@@ -13,49 +13,58 @@ def default_get(self, fields_list):
         sale_order_line_id = self._context.get("active_id")
         if sale_order_line_id:
             sale_order_line = self.env["sale.order.line"].browse(sale_order_line_id)
-            existing_lines = self.env["sale.order.line"].search(
-                [("main_product_line_id", "=", sale_order_line_id)]
-            )
+            existing_lines = self.env["sale.order.line"].search([
+                ("main_product_line_id", "=", sale_order_line_id)
+            ])
+            sub_product_line_wizard = self.env["sub.product.line.kit.wizard"]
             line_values = []
             if existing_lines:
-                for sub_product in existing_lines:
-                    curr_product = self.env["sub.product.line.kit.wizard"].create(
-                        {
-                            "product_id": sub_product.product_id.id,
-                            "price": sub_product.price_unit,
-                            "quantity": sub_product.product_uom_qty,
-                        }
-                    )
-                    line_values.append(Command.link(curr_product.id))
+                vals_list = [
+                    {
+                        "product_id": line.product_id.id,
+                        "price": line.price_unit,
+                        "quantity": line.product_uom_qty,
+                    }
+                    for line in existing_lines
+                ]
             else:
-                for sub_product in sale_order_line.product_id.sub_products_ids:
-                    curr_product = self.env["sub.product.line.kit.wizard"].create(
-                        {
-                            "product_id": sub_product.id,
-                            "price": sub_product.list_price,
-                            "quantity": 1,
-                        }
-                    )
-                    line_values.append(Command.link(curr_product.id))
-            res["sub_products_ids"] = line_values
-            res["sale_order_line_id"] = sale_order_line_id
+                vals_list = [
+                    {
+                        "product_id": sub_product.id,
+                        "price": sub_product.list_price,
+                        "quantity": 1,
+                    }
+                    for sub_product in sale_order_line.product_id.sub_products_ids
+                ]
+            if vals_list:
+                curr_products = sub_product_line_wizard.create(vals_list)
+                line_values = [Command.link(product.id) for product in curr_products]
+            res.update({
+                "sub_products_ids": line_values,
+                "sale_order_line_id": sale_order_line_id,
+            })
         return res
 
     def action_confirm(self):
-        total_of_sub_product_price = 0
-        for rec in self.sub_products_ids:
-            existing_lines = self.env["sale.order.line"].search(
+        existing_sub_product_lines_map = {
+            line.product_id.id: line
+            for line in self.env["sale.order.line"].search(
                 [
                     ("main_product_line_id", "=", self.sale_order_line_id.id),
-                    ("product_id", "=", rec.product_id.id),
                     ("order_id", "=", self.sale_order_line_id.order_id.id)
-                ],
-                limit=1,
+                ]
             )
-            if existing_lines:
-                existing_lines.product_uom_qty = rec.quantity
-                existing_lines.last_price = rec.price
-                existing_lines.price_unit = 0
+        }
+        total_of_sub_product_price = 0
+        for rec in self.sub_products_ids:
+            product_id = rec.product_id.id
+            existing_line = existing_sub_product_lines_map.get(product_id)
+            if existing_line:
+                existing_line.write({
+                    "product_uom_qty": rec.quantity,
+                    "last_price": rec.price,
+                    "price_unit": 0,
+                })
             else:
                 self.env["sale.order.line"].create(
                     {