[IMP] estate: interact with external modules and code cleanup

- Implemented cross-module field access and method calls to demonstrate interaction with other modules.
- Cleaned codebase to fix linter errors and improve readability.

Author: rvar-odoo

estate/__init__.py

@@ -1 +1 @@
-from . import models
+from . import models

estate/__manifest__.py

@@ -1,19 +1,20 @@
 {
-    'name': 'Real Estate',
-    'category': 'All',
-    'summary': 'Demo app for estate',
-    'description': "This is the demo app ",
-    'installable': True,
-    'depends': ['base'],
-    'application': True,
-    'auto_install': False,
-    'data' : [
-        'security/ir.model.access.csv',
-        'views/estate_property_offer_views.xml',
-        'views/estate_property_views.xml',
-        'views/estate_menus.xml',
-        'views/estate_settings_views.xml',
-        'views/estate_property_tags_views.xml',
-        'views/res_users_views.xml'
-    ]
-}
+    "name": "Real Estate",
+    "category": "All",
+    "summary": "Demo app for estate",
+    "description": "This is the demo app ",
+    "installable": True,
+    "depends": ["base"],
+    "application": True,
+    "auto_install": False,
+    "license": "AGPL-3",
+    "data": [
+        "security/ir.model.access.csv",
+        "views/estate_property_offer_views.xml",
+        "views/estate_property_views.xml",
+        "views/estate_settings_views.xml",
+        "views/estate_property_tags_views.xml",
+        "views/res_users_views.xml",
+        "views/estate_menus.xml",
+    ],
+}

estate/models/__init__.py

@@ -2,4 +2,4 @@
 from . import estate_property_type
 from . import estate_property_tag
 from . import estate_property_offer
-from . import inherited_model
+from . import inherited_model

estate/models/estate_property.py

@@ -1,20 +1,22 @@
 from dateutil.relativedelta import relativedelta
 from odoo import fields, models, api, _
 from odoo.exceptions import UserError, ValidationError
-from odoo.tools.float_utils import float_compare, float_is_zero, float_round
-
-
+from odoo.tools.float_utils import float_compare, float_is_zero
 
 
 class RecurringPlan(models.Model):
     _name = "estate.property"
     _description = "estate property revenue plans"
-    _order = "id desc"   # For ordering in ascending opr descending order   one more way to do so is from view like: <list default_order="date desc">
+    _order = "id desc"  # For ordering in ascending opr descending order   one more way to do so is from view like: <list default_order="date desc">
 
     name = fields.Char(required=True)
     description = fields.Text(string="Description")
     postcode = fields.Char(string="Postcode")
-    date_availability = fields.Date(string="Available From", copy=False, default=lambda self: fields.Date.today() + relativedelta(months=3))
+    date_availability = fields.Date(
+        string="Available From",
+        copy=False,
+        default=lambda self: fields.Date.today() + relativedelta(months=3),
+    )
     expected_price = fields.Float(string="Expected Price", required=True)
     selling_price = fields.Float(string="Selling Price", readonly=True, copy=False)
     bedrooms = fields.Integer(string="Bedrooms", default=2)
@@ -25,94 +27,104 @@ class RecurringPlan(models.Model):
     garden_area = fields.Integer(string="Garden Area (sqm)")
     garden_orientation = fields.Selection(
         selection=[
-            ('north', 'North'),
-            ('south', 'South'),
-            ('east', 'East'),
-            ('west', 'West')
+            ("north", "North"),
+            ("south", "South"),
+            ("east", "East"),
+            ("west", "West"),
         ],
-        string='Garden Orientation',
-        help="Orientation of the garden relative to the property"
+        string="Garden Orientation",
+        help="Orientation of the garden relative to the property",
     )
     active = fields.Boolean(default=True)
     state = fields.Selection(
         selection=[
-            ('new', 'NEW'),
-            ('offer_received', 'Offer Received'),
-            ('offer_accepted', 'Offer Accepted'),
-            ('sold', 'Sold'),
-            ('cancelled', 'Cancelled')
+            ("new", "NEW"),
+            ("offer_received", "Offer Received"),
+            ("offer_accepted", "Offer Accepted"),
+            ("sold", "Sold"),
+            ("cancelled", "Cancelled"),
         ],
         string="Status",
-        required=True, 
-        default='new',
+        required=True,
+        default="new",
         copy=False,
         # readonly=True
-
     )
 
     total_area = fields.Integer(string="Total Area", compute="_compute_total_area")
     best_price = fields.Float(string="Best Offer", compute="_compute_best_price")
 
     property_type_id = fields.Many2one("estate.property.type", string="Property Type")
     buyer_id = fields.Many2one("res.partner", string="Buyer", copy=False)
-    user_id = fields.Many2one("res.users", string="Salesman", copy=False, default=lambda self: self.env.user)
-
-    tag_id = fields.Many2many("estate.property.tag", string="Tags",copy=False)
+    user_id = fields.Many2one(
+        "res.users", string="Salesman", copy=False, default=lambda self: self.env.user
+    )
 
-    offer_id = fields.One2many("estate.property.offer","property_id", string="Offer")
+    tag_id = fields.Many2many("estate.property.tag", string="Tags", copy=False)
 
+    offer_id = fields.One2many("estate.property.offer", "property_id", string="Offer")
 
     _sql_constraints = [
-        ('check_expected_price', 'CHECK(expected_price > 0)','The Expected price of a property should be strictly positive.'),
-        ('check_selling_price', 'CHECK(selling_price IS NULL OR selling_price >= 0)', 'Selling price must be positive when set.')
+        (
+            "check_expected_price",
+            "CHECK(expected_price > 0)",
+            "The Expected price of a property should be strictly positive.",
+        ),
+        (
+            "check_selling_price",
+            "CHECK(selling_price IS NULL OR selling_price >= 0)",
+            "Selling price must be positive when set.",
+        ),
     ]
 
-
-    @api.depends('living_area', 'garden_area')
+    @api.depends("living_area", "garden_area")
     def _compute_total_area(self):
         for area in self:
             area.total_area = area.living_area + area.garden_area
 
-    
-    @api.depends('offer_id.price')
+    @api.depends("offer_id.price")
     def _compute_best_price(self):
         for record in self:
             # Get all prices from offer_ids
-            offer_prices = record.offer_id.mapped('price')
+            offer_prices = record.offer_id.mapped("price")
             record.best_price = max(offer_prices) if offer_prices else 0.0
 
-
     @api.onchange("garden")
     def _onchange_garden(self):
-        if(self.garden):
-            self.garden_orientation = 'north'
+        if self.garden:
+            self.garden_orientation = "north"
             self.garden_area = 10
         else:
             self.garden_orientation = False
             self.garden_area = 0
-    
-    def action_property_sold(self): 
-        for prop in self: 
-            if prop.state == 'cancelled':
+
+    def action_property_sold(self):
+        for prop in self:
+            if prop.state == "cancelled":
                 raise UserError(_("Cancelled properties cannot be sold."))
-            prop.state = 'sold'
-        return True 
+            prop.state = "sold"
+        return True
 
     def action_property_cancel(self):
         for prop in self:
-            if prop.state == 'sold':
+            if prop.state == "sold":
                 raise UserError(_("Sold properties cannot be cancelled."))
-            prop.state = 'cancelled'
+            prop.state = "cancelled"
         return True
 
-    @api.constrains('selling_price','expected_price')
+    @api.constrains("selling_price", "expected_price")
     def _check_selling_price(self):
         for record in self:
             if float_is_zero(record.selling_price, precision_digits=2):
                 continue
             min_allowed_price = record.expected_price * 0.9
 
-            if float_compare(record.selling_price, min_allowed_price, precision_digits=2) < 0:
+            if (
+                float_compare(
+                    record.selling_price, min_allowed_price, precision_digits=2
+                )
+                < 0
+            ):
                 raise ValidationError(
                     "Selling price cannot be lower than 90% of the expected price. "
                     f"(Minimum allowed: {min_allowed_price:.2f})"
@@ -121,5 +133,9 @@ def _check_selling_price(self):
     @api.ondelete(at_uninstall=False)
     def _unlink_except_state_not_new(self):
         for rec in self:
-            if rec.state not in ['new', 'cancelled']:
-                raise UserError(_("You cannot delete a property unless its state is 'New' or 'Cancelled'."))
+            if rec.state not in ["new", "cancelled"]:
+                raise UserError(
+                    _(
+                        "You cannot delete a property unless its state is 'New' or 'Cancelled'."
+                    )
+                )

estate/models/estate_property_offer.py

@@ -10,31 +10,42 @@ class EstatePropertyOffer(models.Model):
 
     price = fields.Float(string="Price")
     status = fields.Selection(
-        selection = [
-            ('accepted','Accepted'),
-            ('refused','Refused')
-        ], copy=False,string='Status'
+        selection=[("accepted", "Accepted"), ("refused", "Refused")],
+        copy=False,
+        string="Status",
     )
 
     validity = fields.Integer(string="Validity", default=7)
-    date_deadline = fields.Date(string="Deadline", compute="_compute_deadline_date", inverse="_inverse_deadline_date")
+    date_deadline = fields.Date(
+        string="Deadline",
+        compute="_compute_deadline_date",
+        inverse="_inverse_deadline_date",
+    )
 
-    partner_id = fields.Many2one("res.partner", string="Partner",copy=False,required=True)
-    property_id = fields.Many2one("estate.property",copy=False,required=True)
-    property_type_id = fields.Many2one("estate.property.type", related="property_id.property_type_id",store=True,readonly=False)
-    _sql_constraints =[
-        ('check_offer_price', 'CHECK(price > 0)', 'The Offer price must be strictly positive')
+    partner_id = fields.Many2one(
+        "res.partner", string="Partner", copy=False, required=True
+    )
+    property_id = fields.Many2one("estate.property", copy=False, required=True)
+    property_type_id = fields.Many2one(
+        "estate.property.type",
+        related="property_id.property_type_id",
+        store=True,
+        readonly=False,
+    )
+    _sql_constraints = [
+        (
+            "check_offer_price",
+            "CHECK(price > 0)",
+            "The Offer price must be strictly positive",
+        )
     ]
 
-
-
-    @api.depends('create_date','validity')
+    @api.depends("create_date", "validity")
     def _compute_deadline_date(self):
         for offer in self:
             create_dt = offer.create_date or fields.Date.today()
             offer.date_deadline = create_dt + relativedelta(days=offer.validity)
 
-
     def _inverse_deadline_date(self):
         for offer in self:
             if offer.date_deadline:
@@ -48,46 +59,46 @@ def action_accept(self):
         for offer in self:
             # Allow only if property has no accepted offer
             if offer.property_id.buyer_id:
-                raise UserError(_("An offer has already been accepted for this property."))
+                raise UserError(
+                    _("An offer has already been accepted for this property.")
+                )
             # Set buyer and selling price
             offer.property_id.buyer_id = offer.partner_id
             offer.property_id.selling_price = offer.price
-            offer.status = 'accepted'
-            offer.property_id.state = 'offer_accepted'
+            offer.status = "accepted"
+            offer.property_id.state = "offer_accepted"
             # Setting remaining Offer as refused
             other_offers = offer.property_id.offer_id - offer
             # for other in other_offers:                  # -----> Normal for loop logic
             #     other.status = 'refused'
-            other_offers.write({'status': 'refused'})     # -----> Odoo ORM Method
+            other_offers.write({"status": "refused"})  # -----> Odoo ORM Method
 
         return True
 
     def action_refused(self):
         for offer in self:
-            offer.status = 'refused'
+            offer.status = "refused"
         return True
 
     @api.model_create_multi
     def create(self, vals_list):
         new_records = []
-        print(f"vals_list---------> {vals_list}")
         for vals in vals_list:
-            property_id = vals.get('property_id')
+            property_id = vals.get("property_id")
 
-            property_rec = self.env['estate.property'].browse(property_id)
+            property_rec = self.env["estate.property"].browse(property_id)
             # Business logic: set property state
-            if property_rec.state == 'new':
-                property_rec.state = 'offer_received'
-                print("DEBUG: Property state set to 'offer_received'")
+            if property_rec.state == "new":
+                property_rec.state = "offer_received"
 
             # Business logic: validate price
-            if 'price' in vals and vals['price'] < property_rec.best_price:
-                raise exceptions.ValidationError("Offer price must be higher than existing offers.")
+            if "price" in vals and vals["price"] < property_rec.best_price:
+                raise exceptions.ValidationError(
+                    "Offer price must be higher than existing offers."
+                )
 
             new_records.append(vals)
 
         return super().create(new_records)
 
-
-
         # vals_list---------> [{'partner_id': 23, 'price': 100, 'validity': 7, 'date_deadline': '2025-07-16', 'property_id': 19}]

estate/models/estate_property_tag.py

@@ -1,15 +1,18 @@
 from odoo import fields, models
 
+
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
     _description = "Tags of Estate property "
     _order = "name asc"
 
-    name = fields.Char(required=True, string='Name')
+    name = fields.Char(required=True, string="Name")
     color = fields.Integer(default=3)
 
-
-
-    _sql_constraints=[
-        ('unique_property_tag_name', 'UNIQUE(name)', 'A property tag name must be unique.'),
-    ]
+    _sql_constraints = [
+        (
+            "unique_property_tag_name",
+            "UNIQUE(name)",
+            "A property tag name must be unique.",
+        ),
+    ]