[IMP] estate: align views and models with coding guidelines

- Renamed XML ids and view names to follow naming conventions
- Reordered model field attributes according to the defined guidelines

Author: pusu-odoo

estate/models/estate_property.py

@@ -7,6 +7,13 @@
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Estate Property"
+    _sql_constraints = [
+        (
+            "check_expected_price",
+            "CHECK(expected_price > 0)",
+            "The expected price must be greater than 0.",
+        ),
+    ]
     _order = "id desc"
 
     name = fields.Char(string="Name", required=True)
@@ -77,22 +84,6 @@ class EstateProperty(models.Model):
         compute="_compute_best_price",
     )
 
-    _sql_constraints = [
-        (
-            "check_expected_price",
-            "CHECK(expected_price > 0)",
-            "The expected price must be greater than 0.",
-        ),
-    ]
-
-    @api.ondelete(at_uninstall=False)
-    def _unlink_check(self):
-        for property in self:
-            if property.state not in ["new", "cancelled"]:
-                raise UserError(
-                    "You cannot delete a property that is not new or cancelled."
-                )
-
     @api.depends("living_area", "garden_area", "garden")
     def _compute_total_area(self):
         for property in self:
@@ -105,6 +96,24 @@ def _compute_best_price(self):
         for property in self:
             property.best_price = max(property.offer_ids.mapped("price"), default=0.0)
 
+    @api.constrains("selling_price", "expected_price")
+    def _check_selling_price(self):
+        for property in self:
+            if float_is_zero(property.selling_price, precision_rounding=2):
+                continue
+
+            if (
+                float_compare(
+                    property.selling_price,
+                    property.expected_price * 0.9,
+                    precision_rounding=2,
+                )
+                < 0
+            ):
+                raise ValidationError(
+                    "The selling price cannot be lower than 90'%' of the expected price!"
+                )
+
     @api.onchange("garden")
     def _onchange_garden(self):
         for property in self:
@@ -115,6 +124,14 @@ def _onchange_garden(self):
                 property.garden_area = 0
                 property.garden_orientation = False
 
+    @api.ondelete(at_uninstall=False)
+    def _unlink_check(self):
+        for property in self:
+            if property.state not in ["new", "cancelled"]:
+                raise UserError(
+                    "You cannot delete a property that is not new or cancelled."
+                )
+
     def action_set_sold(self):
         for property in self:
             if property.selling_price > 0.0 and property.state != "cancelled":
@@ -136,21 +153,3 @@ def action_set_cancelled(self):
                 raise UserError("This property is already cancelled.")
             elif property.state == "sold":
                 raise UserError("A sold property cannot be cancelled.")
-
-    @api.constrains("selling_price", "expected_price")
-    def _check_selling_price(self):
-        for property in self:
-            if float_is_zero(property.selling_price, precision_rounding=2):
-                continue
-
-            if (
-                float_compare(
-                    property.selling_price,
-                    property.expected_price * 0.9,
-                    precision_rounding=2,
-                )
-                < 0
-            ):
-                raise ValidationError(
-                    "The selling price cannot be lower than 90'%' of the expected price!"
-                )

estate/models/estate_property_offer.py

@@ -6,6 +6,9 @@
 class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
     _description = "Estate Property Offer"
+    _sql_constraints = [
+        ("check_price", "CHECK(price > 0)", "The price must be greater than 0."),
+    ]
     _order = "price desc"
 
     price = fields.Float(string="Price")
@@ -36,23 +39,6 @@ class EstatePropertyOffer(models.Model):
         store=True,
     )
 
-    _sql_constraints = [
-        ("check_price", "CHECK(price > 0)", "The price must be greater than 0."),
-    ]
-
-    @api.model_create_multi
-    def create(self, vals_list):
-        for record in vals_list:
-            property = self.env["estate.property"].browse(record["property_id"])
-
-            if record.get("price") < property.best_price:
-                raise UserError(
-                    "You cannot create an offer lower than an existing one."
-                )
-
-            property.state = "offer received"
-        return super().create(vals_list)
-
     @api.depends("validity")
     def _compute_date_deadline(self):
         for offer in self:
@@ -75,6 +61,19 @@ def _inverse_date_deadline(self):
             else:
                 offer.validity = 0
 
+    @api.model_create_multi
+    def create(self, vals_list):
+        for record in vals_list:
+            property = self.env["estate.property"].browse(record["property_id"])
+
+            if record.get("price") < property.best_price:
+                raise UserError(
+                    "You cannot create an offer lower than an existing one."
+                )
+
+            property.state = "offer received"
+        return super().create(vals_list)
+
     def action_set_accepted(self):
         for offer in self:
             if offer.property_id.selling_price == 0.0:

estate/models/estate_property_tag.py

@@ -4,12 +4,11 @@
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
     _description = "Estate Property Tag"
+    _sql_constraints = [
+        ("unique_name", "UNIQUE(name)", "A tag with same name is already exists."),
+    ]
     _order = "name asc"
 
     name = fields.Char(string="Tag Name", required=True)
     description = fields.Text(string="Description")
     color = fields.Integer(string="Color")
-
-    _sql_constraints = [
-        ("unique_name", "UNIQUE(name)", "A tag with same name is already exists."),
-    ]

estate/models/estate_property_type.py

@@ -4,6 +4,9 @@
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
     _description = "Estate Property Type"
+    _sql_constraints = [
+        ("unique_name", "UNIQUE(name)", "A type with same name is already exists."),
+    ]
     _order = "sequence,name"
 
     name = fields.Char(required=True)
@@ -16,13 +19,8 @@ class EstatePropertyType(models.Model):
     sequence = fields.Integer(
         "Sequence", default=1, help="Used to order types. Lower is better."
     )
-
     offer_count = fields.Integer("Offers", compute="_compute_offer_count")
 
-    _sql_constraints = [
-        ("unique_name", "UNIQUE(name)", "A type with same name is already exists."),
-    ]
-
     @api.depends("offer_ids")
     def _compute_offer_count(self):
         for record in self:

estate/views/estate_property_offer_views.xml

@@ -8,8 +8,9 @@
         <field name="domain">[('property_type_id', '=', active_id)]</field>
     </record>
 
-    <record id="estate_property_offer_view" model="ir.ui.view">
-        <field name="name">estate.property.offer.list</field>
+    <!-- list view -->
+    <record id="estate_property_offer_view_list" model="ir.ui.view">
+        <field name="name">estate.property.offer.view.list</field>
         <field name="model">estate.property.offer</field>
         <field name="arch" type="xml">
             <list editable="bottom" decoration-success="status == 'accepted'" decoration-danger="status == 'refused'">
@@ -26,8 +27,9 @@
         </field>
     </record>
 
-    <record id="estate_property_offer_form" model="ir.ui.view">
-        <field name="name">estate.property.offer.form</field>
+    <!-- form view -->
+    <record id="estate_property_offer_view_form" model="ir.ui.view">
+        <field name="name">estate.property.offer.view.form</field>
         <field name="model">estate.property.offer</field>
         <field name="arch" type="xml">
             <form>

estate/views/estate_property_tag_views.xml

@@ -14,7 +14,7 @@
 
     <!-- list view -->
     <record id="estate_property_tag_view_list" model="ir.ui.view">
-        <field name="name">estate.property.tag.list</field>
+        <field name="name">estate.property.tag.view.list</field>
         <field name="model">estate.property.tag</field>
         <field name="arch" type="xml">
             <list string="Property Types" editable="bottom">
@@ -26,7 +26,7 @@
 
     <!-- form view -->
     <record id="estate_property_tag_view_form" model="ir.ui.view">
-        <field name="name">estate.property.tag.form</field>
+        <field name="name">estate.property.tag.view.form</field>
         <field name="model">estate.property.tag</field>
         <field name="arch" type="xml">
             <form string="Property Tag">

estate/views/estate_property_type_views.xml

@@ -14,7 +14,7 @@
 
     <!-- list view -->
     <record id="estate_property_type_view_list" model="ir.ui.view">
-        <field name="name">estate.property.type.list</field>
+        <field name="name">estate.property.type.view.list</field>
         <field name="model">estate.property.type</field>
         <field name="arch" type="xml">
             <list string="Property Types">
@@ -26,7 +26,7 @@
 
     <!-- form view -->
     <record id="estate_property_type_view_form" model="ir.ui.view">
-        <field name="name">estate.property.type.form</field>
+        <field name="name">estate.property.type.view.form</field>
         <field name="model">estate.property.type</field>
         <field name="arch" type="xml">
             <form string="Property Type">

estate/views/estate_property_views.xml

@@ -14,8 +14,8 @@
     </record>
 
     <!-- list view -->
-    <record id="estate_property_view" model="ir.ui.view">
-        <field name="name">estate.property.list</field>
+    <record id="estate_property_view_list" model="ir.ui.view">
+        <field name="name">estate.property.view.list</field>
         <field name="model">estate.property</field>
         <field name="arch" type="xml">
             <list string="estate_property_view" decoration-success="state in ['offer received','offer accepted']" 
@@ -34,8 +34,8 @@
     </record>
 
     <!-- form view -->
-    <record id="estate_property_form" model="ir.ui.view">
-        <field name="name">estate.property.form</field>
+    <record id="estate_property_view_form" model="ir.ui.view">
+        <field name="name">estate.property.view.form</field>
         <field name="model">estate.property</field>
         <field name="arch" type="xml">
             <form string="estate_property_form">
@@ -96,8 +96,8 @@
     </record>
 
     <!-- search view-->
-    <record id="estate_property_search" model="ir.ui.view">
-        <field name="name">estate.property.search</field>
+    <record id="estate_property_view_search" model="ir.ui.view">
+        <field name="name">estate.property.view.search</field>
         <field name="model">estate.property</field>
         <field name="arch" type="xml">
             <search string="estate_property_search">
@@ -119,8 +119,8 @@
     </record>
 
     <!-- kanban view -->
-    <record id="estate_property_kanban_view" model="ir.ui.view">
-        <field name="name">estate.property.kanban</field>
+    <record id="estate_property_view_kanban" model="ir.ui.view">
+        <field name="name">estate.property.view.kanban</field>
         <field name="model">estate.property</field>
         <field name="arch" type="xml">
             <kanban default_group_by="property_type_id" records_draggable="False" group_create="False">
@@ -157,4 +157,3 @@
         </field>
     </record>    
 </odoo>
-