[IMP] real_estate: add SQL constraints and UI improvements for property models

This commit adds data integrity and UI improvements as guided by Chapters 10 and
11 of the Odoo Server Framework 101 tutorial.

Constraints:
- Added SQL constraints to ensure unique names for property types and tags.
- Added SQL constraint to ensure color index stays within valid range.
- Implemented Python constraints to enforce logical business rules

UI Enhancements:
- Introduced computed field  on property types.
- Added stat button to open related offers via domain.
- Enhanced form views with notebooks and inline editing for better UX.
- Updated navigation menu to include property type and tag settings.

Author: prbo-odoo

real_estate/__init__.py

@@ -1 +1 @@
-from . import models
+from . import models

real_estate/__manifest__.py

@@ -9,10 +9,10 @@
     'author': "prbo",
     'data': [
     'security/ir.model.access.csv',
-    'views/estate_property_views.xml',
+    'views/estate_property_offer_view.xml',
     'views/estate_property_type_view.xml', 
+    'views/estate_property_views.xml',
     'views/estate_property_tag_view.xml',
-    'views/estate_property_offer_view.xml',
     'views/estate_menus.xml'
 ]
-}
+}

real_estate/models/__init__.py

@@ -1,4 +1,4 @@
 from . import estate_property
 from . import estate_property_type
 from . import estate_property_tag
-from . import estate_property_offer
+from . import estate_property_offer

real_estate/models/estate_property.py

@@ -1,11 +1,13 @@
 from odoo import fields, models, api
 from datetime import date, timedelta
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare
 
-class estate_property(models.Model):
+
+class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Test Model"
-
+    _order = "id desc"
 
     name = fields.Char(required=True)
     description = fields.Text()
@@ -17,56 +19,64 @@ class estate_property(models.Model):
     )
     expected_price = fields.Float(required=True)
     selling_price = fields.Float(readonly=True, copy=False)
-
     best_price = fields.Float(compute="_compute_best_price")
 
     bedrooms = fields.Integer(default=2)
-
     facades = fields.Integer()
     garage = fields.Boolean()
     garden = fields.Boolean()
     living_area = fields.Float()
     garden_area = fields.Float()
     total_area = fields.Float(compute="_compute_total_area")
+
     garden_orientation = fields.Selection(
         string='Garden Orientation',
-        selection=[('north', 'North'), ('south', 'South'),
-                   ('east', 'East'), ('west', 'West')],
+        selection=[
+            ('north', 'North'),
+            ('south', 'South'),
+            ('east', 'East'),
+            ('west', 'West')
+        ],
         help="Direction of the garden"
     )
+
     active = fields.Boolean(default=True)
     state = fields.Selection(
-    selection=[
-        ('new', 'New'),
-        ('offer_received', 'Offer Received'),
-        ('offer_accepted', 'Offer Accepted'),
-        ('sold', 'Sold'),
-        ('cancelled', 'Cancelled')
-    ],
-    required=True,
-    copy=False,
-    default='new'
-)
-    property_type = fields.Many2one("estate.property.type", string="Property Type", default=None)
+        selection=[
+            ('new', 'New'),
+            ('offer_received', 'Offer Received'),
+            ('offer_accepted', 'Offer Accepted'),
+            ('sold', 'Sold'),
+            ('cancelled', 'Cancelled')
+        ],
+        required=True,
+        copy=False,
+        default='new'
+    )
+
+    property_type = fields.Many2one("estate.property.type", string="Property Type")
     buyer = fields.Many2one("res.partner", string="Buyer", copy=False)
     seller = fields.Many2one("res.partner", string="Salesperson", default=lambda self: self.env.user)
     tag_ids = fields.Many2many("estate.property.tag", string="Tags", default=None)
     offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
 
+    _sql_constraints = [
+        ('check_expected_price_positive', 'CHECK(expected_price > 0)', 'Expected price must be strictly positive.'),
+        ('check_selling_price_positive', 'CHECK(selling_price >= 0)', 'Selling price must be zero or positive.')
+    ]
+
     @api.depends("living_area", "garden_area")
     def _compute_total_area(self):
         for record in self:
             record.total_area = record.living_area + record.garden_area
 
-
     @api.depends("offer_ids.price")
     def _compute_best_price(self):
         for record in self:
             if record.offer_ids:
                 record.best_price = max(record.offer_ids.mapped("price"))
             else:
-                record.best_price = 0.0   
-
+                record.best_price = 0.0
 
     @api.onchange('garden')
     def _onchange_garden(self):
@@ -75,21 +85,26 @@ def _onchange_garden(self):
             self.garden_orientation = 'north'
         else:
             self.garden_area = 0
-            self.garden_orientation = False                 
-
+            self.garden_orientation = False
 
     def action_sold(self):
         for record in self:
-            if record.state == 'cancelled':
-                raise UserError("Cancelled property cannot be sold.")
+            if record.state in ['sold', 'cancelled']:
+                raise UserError("You cannot sell a cancelled or already sold property.")
             record.state = 'sold'
         return True
 
     def action_cancel(self):
         for record in self:
-            if record.state == 'sold':
-                raise UserError("Sold property cannot be cancelled.")
+            if record.state in ['sold', 'cancelled']:
+                raise UserError("You cannot cancel a sold or already cancelled property.")
             record.state = 'cancelled'
         return True
 
-    
+    @api.constrains('selling_price', 'expected_price')
+    def _check_selling_price_margin(self):
+        for record in self:
+            if float_compare(record.selling_price, 0.0, precision_digits=2) > 0:
+                min_acceptable_price = 0.9 * record.expected_price
+                if float_compare(record.selling_price, min_acceptable_price, precision_digits=2) < 0:
+                    raise ValidationError("Selling price cannot be lower than 90% of the expected price.")

real_estate/models/estate_property_offer.py

@@ -2,43 +2,57 @@
 from datetime import timedelta
 from odoo.exceptions import UserError
 
+
 class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
     _description = "Property Offer"
+    _order = "price desc"
 
-    price = fields.Float()
+    price = fields.Float(required=True)
     status = fields.Selection([
         ('accepted', 'Accepted'),
         ('refused', 'Refused')
     ])
     partner_id = fields.Many2one("res.partner", string="Partner", required=True)
     property_id = fields.Many2one("estate.property", string="Property", required=True)
+    property_type_id = fields.Many2one(
+        related="property_id.property_type",
+        store=True,
+        string="Property Type"
+    )
 
     validity = fields.Integer(default=7)
-    date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline")
+    date_deadline = fields.Date(
+        compute="_compute_date_deadline",
+        inverse="_inverse_date_deadline",
+        store=True
+    )
+
+    _sql_constraints = [
+        ('check_offer_price_positive', 'CHECK(price > 0)', 'Offer price must be strictly positive.')
+    ]
 
     @api.depends("create_date", "validity")
     def _compute_date_deadline(self):
         for record in self:
             create_date = record.create_date or fields.Date.today()
             record.date_deadline = create_date + timedelta(days=record.validity)
-            print("Computed date_deadline:", record.date_deadline)
 
     def _inverse_date_deadline(self):
         for record in self:
             create_date = record.create_date.date() if record.create_date else fields.Date.today()
             record.validity = (record.date_deadline - create_date).days
 
-
     def action_accept(self):
         for record in self:
             if record.property_id.state == 'sold':
                 raise UserError("You cannot accept an offer on a sold property.")
             record.status = 'accepted'
             record.property_id.selling_price = record.price
-            record.property_id.buyer = record.partner_id 
+            record.property_id.buyer = record.partner_id
             record.property_id.state = 'offer_accepted'
 
+            # Refuse all other offers
             other_offers = self.search([
                 ('property_id', '=', record.property_id.id),
                 ('id', '!=', record.id)

real_estate/models/estate_property_tag.py

@@ -1,7 +1,14 @@
 from odoo import fields, models
 
-class estate_property_tag(models.Model):
+
+class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
     _description = "Property Tag"
+    _order = "name"
 
     name = fields.Char(required=True)
+    color = fields.Integer(string="Color")
+
+    _sql_constraints = [
+        ('unique_tag_name', 'UNIQUE(name)', 'Tag name must be unique.')
+    ]

real_estate/models/estate_property_type.py

@@ -1,7 +1,36 @@
-from odoo import fields, models
+from odoo import fields, models, api
 
 
-class estate_property_type(models.Model):
+class EstatePropertyType(models.Model):
     _name = "estate.property.type"
-    _description = "property type"
-    name = fields.Char(required=True)
+    _description = "Property Type"
+    _order = "sequence, name"
+
+    name = fields.Char(required=True)
+    sequence = fields.Integer(default=10)
+
+    _sql_constraints = [
+        ('unique_type_name', 'UNIQUE(name)', 'Property type name must be unique.')
+    ]
+
+    offer_ids = fields.One2many(
+        'estate.property.offer',
+        'property_type_id',
+        string="Offers"
+    )
+
+    offer_count = fields.Integer(
+        string="Offer Count",
+        compute="_compute_offer_count"
+    )
+
+    property_ids = fields.One2many(
+        "estate.property",
+        "property_type",
+        string="Properties"
+    )
+
+    @api.depends('offer_ids')
+    def _compute_offer_count(self):
+        for record in self:
+            record.offer_count = len(record.offer_ids)

real_estate/security/ir.model.access.csv

@@ -2,4 +2,4 @@ id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 access_estate_property_user,access.estate.property,model_estate_property,base.group_user,1,1,1,1
 access_estate_property_type_user,access.estate.property.type,model_estate_property_type,base.group_user,1,1,1,1
 access_estate_property_tag_user,access.estate.property.tag,model_estate_property_tag,base.group_user,1,1,1,1
-access_estate_property_offer_user,access.estate.property.offer,model_estate_property_offer,base.group_user,1,1,1,1
+access_estate_property_offer_user,access.estate.property.offer,model_estate_property_offer,base.group_user,1,1,1,1

real_estate/views/estate_menus.xml

@@ -1,27 +1,34 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <odoo>
-    <menuitem id="estate_menu_root" name="Estate" sequence="10" />
+    <menuitem id="estate_menu_root"
+              name="Estate"
+              sequence="10" />
 
     <menuitem id="estate_menu_property"
-        name="Properties"
-        parent="estate_menu_root"
-        sequence="10" />
+              name="Properties"
+              parent="estate_menu_root"
+              sequence="10" />
 
     <menuitem id="estate_menu_property_action"
-        parent="estate_menu_property"
-        action="action_estate_property"
-        sequence="10" />
+              name="All Properties"
+              parent="estate_menu_property"
+              action="action_estate_property"
+              sequence="10" />
 
-    <menuitem id="estate_setting" name="Settings" parent="estate_menu_root" />
+    <menuitem id="estate_setting"
+              name="Settings"
+              parent="estate_menu_root"
+              sequence="20" />
 
     <menuitem id="estate_property_type"
-        name="Property Types"
-        parent="estate_setting"
-        action="action_estate_property_type" />
+              name="Property Types"
+              parent="estate_setting"
+              action="action_estate_property_type"
+              sequence="10" />
 
     <menuitem id="estate_menu_property_tag"
-        name="Property Tags"
-        parent="estate_setting"
-        action="action_estate_property_tag" />
-
-</odoo>
+              name="Property Tags"
+              parent="estate_setting"
+              action="action_estate_property_tag"
+              sequence="20" />
+</odoo>

real_estate/views/estate_property_offer_view.xml

@@ -1,12 +1,12 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <odoo>
-    <record id="view_estate_property_offer_list" model="ir.ui.view">
+    <record id="view_tree_estate_property_offer_list" model="ir.ui.view">
         <field name="name">estate.property.offer.list</field>
         <field name="model">estate.property.offer</field>
         <field name="arch" type="xml">
-            <list>
+            <list string="Offers" editable="bottom">
+                <field name="property_id" />
                 <field name="price" />
-                <field name="partner_id" />
                 <field name="validity" />
                 <field name="date_deadline" />
                 <field name="status" />
@@ -19,21 +19,22 @@
         <field name="model">estate.property.offer</field>
         <field name="arch" type="xml">
             <form>
-                <header>
-    <button name="action_accept" type="object" string="Accept" class="btn-primary"/>
-    <button name="action_refuse" type="object" string="Refuse" class="btn-secondary"/>
-</header>
-
                 <sheet>
                     <group>
                         <field name="price" />
-                        <field name="partner_id" />
                         <field name="validity" />
                         <field name="date_deadline" />
-                        <field name="status" />
+                        <field name="status" readonly="1" />
                     </group>
                 </sheet>
             </form>
         </field>
     </record>
-</odoo>
+    <record id="action_estate_property_offer" model="ir.actions.act_window">
+        <field name="name">Offers</field>
+        <field name="res_model">estate.property.offer</field>
+        <field name="view_mode">list,form</field>
+        <field name="context">{}</field>
+        <field name="domain">[('property_type_id', '=', active_id)]</field>
+    </record>
+</odoo>