Skip to content

Commit 513c8e3

Browse files
committed
[IMP] real_estate: improve code in estate property model
improve code and change file name according to guidelines rename model name same as the record name
1 parent c169bc2 commit 513c8e3

9 files changed

+18
-16
lines changed

real_estate/__manifest__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
'view/estate_property_offer_views.xml',
1717
'view/estate_property_type_views.xml',
1818
'view/estate_property_tag_views.xml',
19-
'view/estate_menus.xml',
20-
'view/estate_res_users_view.xml'
19+
'view/estate_res_users_view.xml',
20+
'view/estate_menu.xml',
2121
],
2222
}

real_estate/models/estate_property.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from datetime import date, timedelta
22
from odoo import api, fields, models
3-
from odoo.exceptions import UserError,ValidationError
3+
from odoo.exceptions import UserError, ValidationError
44
from odoo.tools.float_utils import float_compare, float_is_zero
55

66

real_estate/models/estate_property_offer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from datetime import timedelta
22
from odoo import api, fields, models
3-
from odoo.exceptions import UserError
3+
from odoo.exceptions import UserError, ValidationError
44

55

66
class EstatePropertyOffer(models.Model):
File renamed without changes.

real_estate/view/estate_property_offer_views.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<field name="domain">[('property_type_id', '=', active_id)]</field>
88
</record>
99

10-
<record id="view_estate_property_offer_form" model="ir.ui.view">
10+
<record id="estate_property_offer_form" model="ir.ui.view">
1111
<field name="name">estate.property.offer.form</field>
1212
<field name="model">estate.property.offer</field>
1313
<field name="arch" type="xml">
@@ -31,7 +31,7 @@
3131
</field>
3232
</record>
3333

34-
<record id="view_estate_property_offer_list" model="ir.ui.view">
34+
<record id="estate_property_offer_list" model="ir.ui.view">
3535
<field name="name">estate.property.offer.list</field>
3636
<field name="model">estate.property.offer</field>
3737
<field name="arch" type="xml">

real_estate/view/estate_property_tag_views.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22

33
<odoo>
4-
<record id="view_estate_property_tag_list" model="ir.ui.view">
4+
<record id="estate_property_tag_list" model="ir.ui.view">
55
<field name="name">estate.property.tag.list</field>
66
<field name="model">estate.property.tag</field>
77
<field name="arch" type="xml">

real_estate/view/estate_property_type_views.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<field name="res_model">estate.property.type</field>
77
<field name="view_mode">list,form</field>
88
</record>
9-
<record id="estate_property_type_form_view" model="ir.ui.view">
9+
<record id="estate_property_type_form" model="ir.ui.view">
1010
<field name="name">estate.property.type.form</field>
1111
<field name="model">estate.property.type</field>
1212

@@ -39,7 +39,7 @@
3939
</form>
4040
</field>
4141
</record>
42-
<record id="estate_property_type_tree_view" model="ir.ui.view">
42+
<record id="estate_property_type_tree" model="ir.ui.view">
4343
<field name="name">estate.property.type.tree</field>
4444
<field name="model">estate.property.type</field>
4545
<field name="arch" type="xml">

real_estate/view/estate_property_views.xml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
<field name="arch" type="xml">
2929
<form string="Estate Property">
3030
<header>
31-
<button name="action_sold" string="Sold" type="object" class="btn-primary" invisible="state != 'offer_accepted'"/>
31+
<button name="action_sold" string="Sold" type="object" invisible="state != 'offer_accepted'"/>
3232

3333
<button name="action_cancel" string="Cancel" type="object" class="btn-secondary" invisible="state in ('sold', 'cancelled')"/>
3434
<field name="state" widget="statusbar"/>
@@ -99,26 +99,28 @@
9999
<field name="model">estate.property</field>
100100
<field name="arch" type="xml">
101101
<search string="Search Properties">
102-
<!-- Quick search fields -->
102+
<filter name="available" string="Available" domain="[('state', '=', 'new')]"/>
103+
103104
<field name="name"/>
105+
<field name="living_area" string="Living Area" filter_domain="[('living_area', '>=', self)]"/>
106+
104107
<field name="postcode"/>
105108
<field name="property_type_id"/>
106109
<separator/>
107-
<!-- Filters -->
110+
108111
<filter name="filter_available" string="Available" domain="[ '|', ('state', '=', 'new'), ('state', '=', 'offer_received') ]"/>
109112

110-
<!-- Group By -->
111113
<group expand="1" string="Group By">
112114
<filter name="group_by_postcode" string="Postcode" context="{'group_by': 'postcode'}"/>
113115
</group>
114116
</search>
115117
</field>
116118
</record>
117119

118-
119120
<record id="action_estate_property" model="ir.actions.act_window">
120121
<field name="name">Real estate action</field>
121122
<field name="res_model">estate.property</field>
122123
<field name="view_mode">list,form</field>
123124
</record>
124-
</odoo>
125+
</data>
126+
</odoo>

real_estate/view/estate_res_users_view.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<odoo>
2-
<record id="view_users_form_inherit_real_estate" model="ir.ui.view">
2+
<record id="res_users_form_inherit_real_estate" model="ir.ui.view">
33
<field name="name">res.users.form.inherit.real.estate</field>
44
<field name="model">res.users</field>
55
<field name="inherit_id" ref="base.view_users_form"/>

0 commit comments

Comments
 (0)