[IMP] real_estate: Testcases for offers and garden reset logic

Purpose:
Prevent invalid property sales/offers and fix garden field issues.

Approach:
- Blocked offers on sold properties and sales without accepted offers.
- Fixed garden reset to retain area and orientation when unchecked.

Impact:
Eliminates user confusion and ensures consistent  UI behavior.

Author: metu-odoo

real_estate/models/estate_property_offers.py

@@ -37,27 +37,25 @@ def _compute_date_deadline(self):
             if record.create_date and record.validity:
                 record.offer_deadline = fields.Date.add(
                     record.create_date, days=record.validity
-                )
+                    )
             else:
                 record.offer_deadline = fields.Date.add(
                     fields.Date.today(), days=record.validity
-                )
+                    )
 
     def _inverse_date_deadline(self):
         for record in self:
             if record.create_date and record.offer_deadline:
                 record.validity = (
                     record.offer_deadline - fields.Date.to_date(record.create_date)
-                ).days
+                    ).days
 
     def action_accept_offer(self):
         for offer in self:
-            accepted_offer = self.env["estate.property.offers"].search(
-                [
+            accepted_offer = self.env["estate.property.offers"].search([
                     ("property_id", "=", offer.property_id.id),
                     ("status", "=", "accepted"),
-                ]
-            )
+                ])
             if accepted_offer:
                 raise UserError("Only one offer can be accepted per property.")
             offer.status = "accepted"
@@ -74,6 +72,9 @@ def create(self, vals):
         for val in vals:
             property_id = self.env["estate.property"].browse(val["property_id"])
 
+            if property_id.state == "sold":
+                raise UserError("Cannot create an offer on a sold property.")
+
             if property_id.state == "new":
                 property_id.state = "offer_received"
 

real_estate/tests/__init__.py

@@ -0,0 +1,3 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from . import test_real_estate

real_estate/tests/test_real_estate.py

@@ -0,0 +1,62 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from odoo.exceptions import UserError
+from odoo.tests import Form, tagged
+from odoo.tests.common import TransactionCase
+
+
+@tagged('post_install', '-at_install')
+class TestEstateProperty(TransactionCase):
+
+    def setUp(self):
+        super().setUp()
+        self.Property = self.env['estate.property']
+        self.Offer = self.env['estate.property.offers']
+
+    def test_offer_cannot_be_created_on_sold_property(self):
+        """Offers cannot be created for sold properties"""
+        partner = self.env['res.partner'].create({
+            'name': 'Test Partner',
+            'email': '[email protected]',
+        })
+        prop = self.Property.create({
+            'name': 'Sold Property',
+            'state': 'sold',
+            'expected_price': 90000
+        })
+        with self.assertRaises(UserError):
+            self.Offer.create({
+                'price': 100000,
+                'property_id': prop.id,
+                'partner_id': partner.id,
+            })
+
+    def test_cannot_mark_as_sold_without_accepted_offer(self):
+        """Should raise error when trying to sell a property with no offers at all"""
+        prop = self.Property.create({
+            'name': 'No Offers Property',
+            'expected_price': 120000,
+        })
+        with self.assertRaises(UserError):
+            prop.action_sold()
+
+    def test_onchange_garden_unchecked_resets_fields(self):
+        """Garden area and orientation should reset when garden is unchecked"""
+        form = Form(self.env['estate.property'])
+        form.name = "Reset Garden Test"
+        form.expected_price = 90000
+        form.garden = True
+        prop = form.save()
+
+        self.assertEqual(prop.garden_area, 10)
+        self.assertEqual(prop.garden_orientation, "north")
+
+        form = Form(prop)
+        form.garden = False
+        self.assertEqual(form.garden_area, 0)
+        self.assertFalse(form.garden_orientation)
+
+        prop = form.save()
+        self.assertFalse(prop.garden)
+        self.assertEqual(prop.garden_area, 0)
+        self.assertFalse(prop.garden_orientation)