[ADD] real_estate: tests for property selling and offer creation

Prevent creation of offers on sold properties and
Prevent selling properties without accepted offers
Ensure successful property sale updates the state correctly
Add tests to validate offer and sale constraints
Add test to ensure Garden Area and Orientation are reset
when Garden is unchecked

Author: rodh-odoo

estate_account/models/estate_property.py

@@ -7,6 +7,7 @@ class EstateProperty(models.Model):
 
     def action_sold(self):
         res = super().action_sold()
+        self.check_access('write')
 
         journal = self.env['account.journal'].search([('type', '=', 'sale')], limit=1)
         if not journal:
@@ -21,8 +22,6 @@ def action_sold(self):
             journal = self.env['account.journal'].sudo().search([('type', '=', 'sale')], limit=1)
             if not journal:
                 raise UserError("No sale journal found. Please configure at least one sale journal.")
-            record.check_access_rights('write')
-            record.check_access_rule('write')
             invoice_vals = {
                 "partner_id": record.buyer_id.id,
                 "move_type": "out_invoice",
@@ -40,6 +39,5 @@ def action_sold(self):
                     }),
                 ]
             }
-
             self.env["account.move"].sudo().create(invoice_vals)
         return res

real_estate/models/estate_property.py

@@ -99,6 +99,8 @@ def action_cancel(self):
 
     def action_sold(self):
         for record in self:
+            if not any(offer.state == 'accepted' for offer in record.offer_ids):
+                raise UserError("You cannot sell a property without an accepted offer.")
             if record.state == 'cancelled':
                 raise UserError("Cancelled properties cannot be sold.")
             record.state = 'sold'

real_estate/models/estate_property_offer.py

@@ -62,7 +62,9 @@ def create(self, vals_list):
         for vals in vals_list:
             price = vals.get('price')
             property_obj = self.env['estate.property'].browse(vals.get('property_id'))
-            existing_offers = property_obj.offer_ids.filtered(lambda o: o.price >= price)
+            existing_offers = property_obj.offer_ids.filtered(lambda o: o.price is not None and price is not None and o.price >= price)
+            if property_obj.state == 'sold':
+                raise UserError("Cannot create offer for a sold property.")
             if existing_offers:
                 raise ValidationError("You cannot create an offer with a lower or equal price than existing offers.")
             property_obj.state = 'offer_received'

real_estate/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_property_logic

real_estate/tests/test_property_logic.py

@@ -0,0 +1,67 @@
+from odoo.tests.common import TransactionCase
+from odoo.tests import Form
+from odoo.exceptions import UserError
+from odoo.tests import tagged
+
+
+@tagged('post_install', '-at_install')
+class TestEstatePropertyLogic(TransactionCase):
+    def setUp(self):
+        super().setUp()
+        Property = self.env['estate.property']
+        Offer = self.env['estate.property.offer']
+
+        self.partner = self.env['res.partner'].create({
+            'name': 'Test Buyer',
+            'email': '[email protected]'
+        })
+
+        self.property = Property.create({
+            'name': 'Test Property',
+            'state': 'new',
+            'expected_price': 150000,
+            'garden': True,
+            'garden_area': 100,
+            'garden_orientation': 'north',
+        })
+
+        self.offer = Offer.create({
+            'property_id': self.property.id,
+            'partner_id': self.partner.id,
+            'price': 160000,
+        })
+
+    def test_cannot_create_offer_on_sold_property(self):
+        self.property.state = 'sold'
+        with self.assertRaises(UserError):
+            self.env['estate.property.offer'].create({
+                'property_id': self.property.id,
+                'partner_id': self.partner.id,
+                'price': 170000
+            })
+
+    def test_cannot_sell_property_without_accepted_offer(self):
+        self.property.offer_ids.unlink()
+        with self.assertRaises(UserError):
+            self.property.action_sold()
+
+    def test_can_sell_property_with_accepted_offer(self):
+        self.offer.action_accept()
+        self.property.action_sold()
+        self.assertEqual(self.property.selling_price, self.offer.price)
+        self.assertEqual(self.property.buyer_id, self.partner)
+
+    def test_reset_garden_fields_when_unchecked(self):
+        form = Form(self.env['estate.property'])
+        form.name = 'Garden Test'
+        form.garden = True
+        form.expected_price = 15000
+        form.garden_area = 50
+        form.garden_orientation = 'east'
+        prop = form.save()
+
+        prop.garden = False
+        prop._onchange_garden()
+
+        self.assertEqual(prop.garden_area, 0)
+        self.assertFalse(prop.garden_orientation)