[FIX] estate_account: fixed check style and tutorial changes

 fixed check style and tutorial changes in estate_account and estate_property

Author: rodh-odoo

estate_account/__manifest__.py

@@ -1,8 +1,9 @@
 {
     'name': 'Estate Accounting',
     'version': '1.0',
-    'depends': ['base','real_estate', 'account'],
+    'depends': ['real_estate', 'account'],
     'category': 'Real Estate',
+    'license': 'LGPL-3',
     'installable': True,
     'application': False,
 }

real_estate/models/estate_property.py

@@ -1,6 +1,6 @@
 from odoo import fields, models, api
 from datetime import date, timedelta
-from odoo.exceptions import UserError,ValidationError
+from odoo.exceptions import UserError, ValidationError
 from odoo.tools.float_utils import float_compare, float_is_zero
 
 
@@ -32,7 +32,7 @@ class EstateProperty(models.Model):
             ('south', 'South'),
             ('east', 'East'),
             ('west', 'West')
-        ], 
+        ],
         string="Garden Orientation"
     )
     last_seen = fields.Datetime("Last Seen", default=fields.Datetime.now)
@@ -44,9 +44,9 @@ class EstateProperty(models.Model):
             ('offer_accepted', 'Offer Accepted'),
             ('sold', 'Sold'),
             ('cancelled', 'Cancelled'),
-        ], 
-        required=True, 
-        copy=False, 
+        ],
+        required=True,
+        copy=False,
         default='new'
     )
     property_type_id = fields.Many2one('estate.property.type', string="Property Type")
@@ -102,6 +102,6 @@ def action_sold(self):
 
     @api.ondelete(at_uninstall=False)
     def _check_deletion(self):
-       for record in self:
-           if record.state not in ['new', 'cancelled']:
-            raise UserError("You can only delete a property if its state is 'New' or 'Cancelled'.")
+        for record in self:
+            if record.state not in ['new', 'cancelled']:
+                raise UserError("You can only delete a property if its state is 'New' or 'Cancelled'.")

real_estate/models/estate_property_offer.py

@@ -45,8 +45,8 @@ def action_accept(self):
                 raise UserError("An offer has already been accepted.")
             offer.state = 'accepted'
             offer.property_id.write({
-                'selling_price': offer.price, 
-                'buyer_id': offer.partner_id.id, 
+                'selling_price': offer.price,
+                'buyer_id': offer.partner_id.id,
                 'state': 'offer_accepted'
             })
         return True
@@ -57,13 +57,13 @@ def action_refuse(self):
         return True
 
     @api.model_create_multi
-    def create(self, vals):
-        property_id = vals.get('property_id')
-        price = vals.get('price')
-        property_obj = self.env['estate.property'].browse(property_id)
-        existing_offers = property_obj.offer_ids.filtered(lambda o: o.price >= price)
-        if existing_offers:
-            raise ValidationError("You cannot create an offer with a lower or equal price than existing offers.")
-        property_obj.state = 'offer_received'
+    def create(self, vals_list):
+        for vals in vals_list:
+            price = vals.get('price')
+            property_obj = self.env['estate.property'].browse(vals.get('property_id'))
+            existing_offers = property_obj.offer_ids.filtered(lambda o: o.price >= price)
+            if existing_offers:
+                raise ValidationError("You cannot create an offer with a lower or equal price than existing offers.")
+            property_obj.state = 'offer_received'
 
-        return super().create(vals)
+        return super().create(vals_list)

real_estate/view/estate_property_offer_views.xml

@@ -14,11 +14,9 @@
             <form string="Property Offer">
            <header>
     <button name="action_accept" string="Accept" type="object"
-            class="btn-primary"
             invisible="state != 'accepted'"/>
 
     <button name="action_refuse" string="Refuse" type="object"
-            class="btn-secondary"
             invisible="state == 'accepted'"/>
             </header>
 
@@ -42,7 +40,6 @@
               decoration-success="state == 'accepted'">
                 <field name="price"/>
                 <field name="partner_id"/>
-                <field name="state" invisible="1"/>
                  <button name="action_accept" type="object" string="✓" icon="fa-check"/>
                 <button name="action_refuse" type="object" string="✗" icon="fa-times"/>
             </list>

real_estate/view/estate_property_views.xml

@@ -14,7 +14,6 @@
                 <field name="state"/>
                 <field name="expected_price"/>
                 <field name="selling_price"/>
-                <field name="availability_date" optional="show" invisible="1"/>
                 <field name="state"/>
                 <field name="bedrooms"/>
                 <field name="availability_date"/>
@@ -33,11 +32,9 @@
             <form string="Estate Property">
              <header>
     <button name="action_sold" string="Sold" type="object"
-            class="btn-primary"
             invisible="state != 'offer_accepted'"/>
 
     <button name="action_cancel" string="Cancel" type="object"
-            class="btn-secondary"
             invisible="state in ('sold', 'cancelled')"/>
              <field name="state" widget="statusbar"/>
             </header>
@@ -86,18 +83,16 @@
                           <field name="offer_ids">
                          <list editable="bottom" 
                          decoration-success="state == 'accepted'"
-              decoration-danger="state == 'refused'">
+                         decoration-danger="state == 'refused'">
                            <field name="price"/>
                            <field name="partner_id"/>
                            <field name="state"/>
                            <field name="validity"/>
                            <field name="date_deadline"/>
                           <button name="action_accept" string="Accept" type="object"
-            class="btn-primary"
-            invisible="state in ('accepted','refused')"/>
-    <button name="action_refuse" string="Refuse" type="object"
-            class="btn-secondary"
-            invisible="state in ('accepted','refused')"/>
+                           invisible="state in ('accepted','refused')"/>
+                         <button name="action_refuse" string="Refuse" type="object"
+                          invisible="state in ('accepted','refused')"/>
                        </list>
                    </field>