[IMP] real_estate: add UI polish, constraints, ordering, and smart buttons

- Added inline views, statusbar, widget options
- Set SQL & Python constraints for data validity
- Defined default ordering for all models
- Conditional button visibility & field behaviors
- Editable/color-coded list views with decorations
- Stat button for offer count on property type

Author: metu-odoo

real_estate/__manifest__.py

@@ -1,19 +1,18 @@
 {
-    'name': "Dream Homes",
-    'version': '1.0',
-    'depends': ['base'],
-    'author': "Megha Tulsyani",
-    'category': 'Ecommerce For Properties',
-    'data': [
-
-        'security/ir.model.access.csv',
-        'views/estate_property_views.xml',
-        'views/estate_property_type_views.xml',
-        "views/estate_property_tag_views.xml",
+    "name": "Dream Homes",
+    "version": "1.0",
+    "depends": ["base"],
+    "author": "Megha Tulsyani",
+    "category": "Ecommerce For Properties",
+    "data": [
+        "security/ir.model.access.csv",
+        "views/estate_property_views.xml",
         "views/estate_property_offer_views.xml",
-        'views/estate_property_menus.xml'
+        "views/estate_property_type_views.xml",
+        "views/estate_property_tag_views.xml",
+        "views/estate_property_menus.xml",
     ],
-    'license': 'LGPL-3',
-    'installable': True,
-    'application': True
+    "license": "LGPL-3",
+    "installable": True,
+    "application": True,
 }

real_estate/models/estate_property.py

@@ -1,11 +1,13 @@
 from odoo import api, fields, models
 from dateutil.relativedelta import relativedelta
-from odoo.exceptions import UserError
+from odoo.exceptions import UserError, ValidationError
+from odoo.tools.float_utils import float_compare, float_is_zero
 
 
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "This is a real estate module"
+    _order = "id desc"
 
     name = fields.Char(required=True)
     description = fields.Text()
@@ -20,8 +22,8 @@ class EstateProperty(models.Model):
     garden_area = fields.Integer()
     active = fields.Boolean(default=True)
     buyer_id = fields.Many2one(comodel_name="res.partner", string="Buyer", copy=False)
-    total_area  = fields.Float(compute='_compute_total_area', string="Total Area" )
-    best_offer = fields.Float(compute='_compute_best_price',string="Best Offer")
+    total_area = fields.Float(compute="_compute_total_area", string="Total Area")
+    best_offer = fields.Float(compute="_compute_best_price", string="Best Offer")
     date_availability = fields.Date(
         string="Availability From",
         default=lambda self: fields.Date.today() + relativedelta(months=3),
@@ -41,8 +43,7 @@ class EstateProperty(models.Model):
         comodel_name="estate.property.types", string="Property Type"
     )
     estate_property_tag_ids = fields.Many2many(
-        comodel_name="estate.property.tags",
-        string="Tags"
+        comodel_name="estate.property.tags", string="Tags"
     )
     garden_orientation = fields.Selection(
         selection=[
@@ -65,13 +66,12 @@ class EstateProperty(models.Model):
         default="new",
     )
 
-    @api.depends('living_area','garden_area')
+    @api.depends("living_area", "garden_area")
     def _compute_total_area(self):
         for record in self:
             record.total_area = record.living_area + record.garden_area
 
-
-    @api.depends('estate_property_offer_ids')
+    @api.depends("estate_property_offer_ids")
     def _compute_best_price(self):
         for record in self:
             prices = record.estate_property_offer_ids.mapped("price")
@@ -86,15 +86,34 @@ def _onchange_garden(self):
             self.garden_area = 0
             self.garden_orientation = False
 
-
     def action_sold(self):
         for record in self:
-            if record.state == 'cancelled':
+            if record.state == "cancelled":
                 raise UserError("You cannot mark a cancelled property as sold.")
-            record.state = 'sold'
+            record.state = "sold"
 
     def action_cancel(self):
         for record in self:
-            if record.state == 'sold':
+            if record.state == "sold":
                 raise UserError("You cannot mark a sold property as cancelled.")
-            record.state = 'cancelled'
+            record.state = "cancelled"
+
+    _sql_constraints = [
+        (
+            "check_expected_price_positive",
+            "CHECK(expected_price > 0)",
+            "Expected price must be strictly positive.",
+        ),
+    ]
+
+    @api.constrains("expected_price", "selling_price")
+    def _check_selling_price(self):
+        for record in self:
+            if float_is_zero(record.selling_price, precision_digits=2):
+                continue
+
+            min_price = record.expected_price * 0.9
+            if float_compare(record.selling_price, min_price, precision_digits=2) < 0:
+                raise ValidationError(
+                    "Selling price must be at least 90% of the expected price."
+                )

real_estate/models/estate_property_offers.py

@@ -5,48 +5,65 @@
 class EstatePropertyOffers(models.Model):
     _name = "estate.property.offers"
     _description = "Estate Property Offers"
+    _order = "price desc"
 
     price = fields.Float()
     partner_id = fields.Many2one(comodel_name="res.partner", required=True)
     property_id = fields.Many2one(comodel_name="estate.property", required=True)
-    validity = fields.Integer(default='7')
+    validity = fields.Integer(default="7")
+    property_type_id = fields.Many2one(
+        related="property_id.estate_property_type_id", store=True
+    )
+
     offer_deadline = fields.Date(
-        compute='_compute_date_deadline',
-        inverse='_inverse_date_deadline'
-        )
+        compute="_compute_date_deadline", inverse="_inverse_date_deadline"
+    )
     status = fields.Selection(
-        selection=[
-            ("accepted", "Accepted"),
-            ("refused", "Refused")
-            ]
-        )
+        selection=[("accepted", "Accepted"), ("refused", "Refused")]
+    )
 
-    @api.depends('create_date', 'validity')
+    @api.depends("create_date", "validity")
     def _compute_date_deadline(self):
         for record in self:
             if record.create_date and record.validity:
-                record.offer_deadline = fields.Date.add(record.create_date, days=record.validity)
+                record.offer_deadline = fields.Date.add(
+                    record.create_date, days=record.validity
+                )
             else:
-                record.offer_deadline = fields.Date.add(fields.Date.today(), days=record.validity)
+                record.offer_deadline = fields.Date.add(
+                    fields.Date.today(), days=record.validity
+                )
 
     def _inverse_date_deadline(self):
         for record in self:
             if record.create_date and record.offer_deadline:
-                record.validity = (record.offer_deadline - fields.Date.to_date(record.create_date)).days
+                record.validity = (
+                    record.offer_deadline - fields.Date.to_date(record.create_date)
+                ).days
 
     def action_accept_offer(self):
         for offer in self:
-            accepted_offer = self.env['estate.property.offers'].search([
-                ('property_id', '=', offer.property_id.id),
-                ('status', '=', 'accepted')
-            ])
+            accepted_offer = self.env["estate.property.offers"].search(
+                [
+                    ("property_id", "=", offer.property_id.id),
+                    ("status", "=", "accepted"),
+                ]
+            )
             if accepted_offer:
                 raise UserError("Only one offer can be accepted per property.")
-            offer.status = 'accepted'
+            offer.status = "accepted"
             offer.property_id.selling_price = offer.price
             offer.property_id.buyer_id = offer.partner_id
-            offer.property_id.state = 'offer_accepted'
+            offer.property_id.state = "offer_accepted"
 
     def action_refuse_offer(self):
         for offer in self:
-            offer.status = 'refused'
+            offer.status = "refused"
+
+    _sql_constraints = [
+        (
+            "check_offer_price_positive",
+            "CHECK(price > 0)",
+            "Offer price must be strictly positive.",
+        )
+    ]

real_estate/models/estate_property_tags.py

@@ -4,5 +4,15 @@
 class EstatePropertyTags(models.Model):
     _name = "estate.property.tags"
     _description = "Estate Property Tags"
+    _order = "name"
 
     name = fields.Char(required=True)
+    color = fields.Integer()
+
+    _sql_constraints = [
+        (
+            "unique_tag_name",
+            "UNIQUE(name)",
+            "This property tag already exits, create a unique one.",
+        )
+    ]

real_estate/models/estate_property_types.py

@@ -1,9 +1,31 @@
-from odoo import fields, models
+from odoo import api, fields, models
 
 
 class EstatePropertyTypes(models.Model):
     _name = "estate.property.types"
     _description = "Estate Property Types"
+    _order = "sequence, name"
 
     name = fields.Char(required=True)
+    sequence = fields.Integer(default=1)
+    offer_ids = fields.One2many(
+        comodel_name="estate.property.offers", inverse_name="property_type_id"
+    )
+    offer_count = fields.Integer(
+        string="Number of Offers", compute="_compute_offer_count"
+    )
+    property_ids = fields.One2many(
+        "estate.property", "estate_property_type_id", string="Properties"
+    )
+    _sql_constraints = [
+        (
+            "unique_type_name",
+            "UNIQUE(name)",
+            "This property type already exits, create a unique one.",
+        )
+    ]
 
+    @api.depends("offer_ids")
+    def _compute_offer_count(self):
+        for record in self:
+            record.offer_count = len(record.offer_ids)

real_estate/views/estate_property_offer_views.xml

@@ -1,17 +1,28 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <odoo>
+    <record id="estate_property_offer_action" model="ir.actions.act_window">
+        <field name="name">estate.property.offer.action</field>
+        <field name="res_model">estate.property.offers</field>
+        <field name="view_mode">list,form</field>
+        <field name="domain">[('property_type_id', '=', active_id)]</field>
+    </record>
+
     <record id="estate_property_offer_view" model="ir.ui.view">
         <field name="name">estate.property.offer.list</field>
         <field name="model">estate.property.offers</field>
         <field name="arch" type="xml">
-            <list editable="bottom">
+            <list editable="bottom"
+                decoration-danger="status == 'refused'"
+                decoration-success="status == 'accepted'">
                 <field name="price" />
                 <field name="partner_id" />
                 <field name="status" />
                 <field name="validity" string="Validity(Days)" />
                 <field name="offer_deadline" />
-                <button name="action_accept_offer" string="Accept" type="object" icon="fa-check" invisible="status in ('accepted','refused')"/>
-                <button name="action_refuse_offer" string="Refuse" type="object" icon="fa-close" invisible="status in ('accepted','refused')"/>
+                <button name="action_accept_offer" string="Accept" type="object" icon="fa-check"
+                    invisible="status in ('accepted','refused')" />
+                <button name="action_refuse_offer" string="Refuse" type="object" icon="fa-close"
+                    invisible="status in ('accepted','refused')" />
             </list>
         </field>
     </record>

real_estate/views/estate_property_tag_views.xml

@@ -15,4 +15,14 @@
         </field>
     </record>
 
+    <record id="view_estate_property_tag_list" model="ir.ui.view">
+        <field name="name">estate.property.tag.list</field>
+        <field name="model">estate.property.tags</field>
+        <field name="arch" type="xml">
+            <list editable="bottom">
+                <field name="name" />
+            </list>
+        </field>
+    </record>
+
 </odoo>

real_estate/views/estate_property_type_views.xml

@@ -14,4 +14,52 @@
         </field>
     </record>
 
+    <record id="view_estate_property_type_form" model="ir.ui.view">
+        <field name="name">estate.property.type.form</field>
+        <field name="model">estate.property.types</field>
+        <field name="arch" type="xml">
+            <form string="Property Type">
+                <sheet>
+                    <div class="oe_button_box" name="button_box">
+                        <button name="%(estate_property_offer_action)d"
+                            type="action"
+                            class="oe_stat_button"
+                            icon="fa-list">
+                            <div>
+                                <field name="offer_count" widget="statinfo" string="Offers" />
+                            </div>
+                        </button>
+                    </div>
+                    <group>
+                        <h1>
+                            <field name="name" />
+                        </h1>
+                    </group>
+                    <notebook>
+                        <page string="Properties">
+                            <field name="property_ids">
+                                <list>
+                                    <field name="name" />
+                                    <field name="expected_price" />
+                                    <field name="state" />
+                                </list>
+                            </field>
+                        </page>
+                    </notebook>
+                </sheet>
+            </form>
+        </field>
+    </record>
+
+    <record id="view_estate_property_type_list" model="ir.ui.view">
+        <field name="name">estate.property.type.list</field>
+        <field name="model">estate.property.types</field>
+        <field name="arch" type="xml">
+            <list>
+                <field name="sequence" widget="handle" />
+                <field name="name" />
+            </list>
+        </field>
+    </record>
+
 </odoo>