[FIX] real_estate: code correction according to coding guidelines and add access rights

In this tutorial, learn about coding guidelines about format of
documentation and naming convention of models and files,
also get information about how to organize models and files in
Directories, get knowledge about xml format. next understand
about javascript naming convention and formatting and gained
knowledge about CSS and SCSS. Understand about access rule about
which rights should give to user or not like create, edit, delete and update.

Author: gasa-odoo

estate-gasa/models/inherited_model.py

@@ -1,7 +1,7 @@
 {
     'name': "Account",
     'version': '1.0',
-    'depends': ['base','estate-gasa', 'account'],
+    'depends': ['base', 'estate_gasa', 'account'],
     'author': "Author Name",
     'category': 'Category',
     "license": "LGPL-3",

estate_account/__manifest__.py

@@ -10,10 +10,10 @@
     'data': [
      'security/ir.model.access.csv',
      'views/estate_property_views.xml',
+     'views/estate_property_offer_views.xml',
      'views/estate_property_type_views.xml',
      'views/estate_tag_views.xml',
-     'views/estate_property_offer_views.xml',
-     'views/estate_menus.xml', 
      'views/inherited_model.xml',
+     'views/estate_menus.xml',
     ],
 }

estate-gasa/__init__.py renamed to estate_gasa/__init__.py

@@ -16,10 +16,7 @@ class Estate(models.Model):
     expected_price = fields.Float()
     bedrooms = fields.Integer(default=2)
     last_seen = fields.Datetime("Last Seen", default=fields.Date.today)
-    date_availability = fields.Date(
-        default=lambda self: date.today() + timedelta(days=90),
-        copy=False
-    )
+    date_availability = fields.Date(default=lambda self: date.today() + timedelta(days=90), copy=False)
     active = fields.Boolean(default=True)
     living_area = fields.Integer(string="Living Area")
     facades = fields.Integer(string="Facades")
@@ -106,20 +103,18 @@ def action_mark_cancelled(self):
             record.state = 'cancelled'
 
     _sql_constraints = [
-        ('check_expected_price_positive', 'CHECK(expected_price > 0)',
-         'The expected price must be strictly positive.'),
-        ('check_selling_price_positive', 'CHECK(selling_price >= 0)',
-         'The selling price must be positive.'),
+        ('check_expected_price_positive', 'CHECK(expected_price > 0)', 'The expected price must be strictly positive.'),
+        ('check_selling_price_positive', 'CHECK(selling_price >= 0)', 'The selling price must be positive.'),
     ]
 
     @api.constrains('selling_price', 'expected_price')
     def _check_selling_price_threshold(self):
         for record in self:
             if float_is_zero(record.selling_price, precision_digits=2):
                 continue
-            
+
             minimum_allowed = record.expected_price * 0.9
-            
+
             if float_compare(record.selling_price, minimum_allowed, precision_digits=2) < 0:
                 raise ValidationError(
                     ("The selling price cannot be lower than 90%% of the expected price.\n"

estate-gasa/__manifest__.py renamed to estate_gasa/__manifest__.py

@@ -1,6 +1,6 @@
 from odoo import api, models, fields
-from odoo.exceptions import UserError,ValidationError
-from datetime import date, timedelta
+from odoo.exceptions import UserError, ValidationError
+from datetime import timedelta
 
 
 class EstatePropertyOffer(models.Model):
@@ -64,21 +64,22 @@ def action_refuse(self):
          'The offer price must be strictly positive.'),
     ]
 
-    @api.model
-    def create(self, vals):
-        property_id = vals.get('property_id')
-        amount = vals.get('price')
-
-        if property_id and amount:
-            existing_offers = self.search([
-                ('property_id', '=', property_id),
-                ('price', '>=', amount)
-            ])
-            if existing_offers:
-                raise ValidationError("An offer with a higher or equal price already exists.")
-
-            property = self.env['estate.property'].browse(property_id)
-            if property.state == 'new':
-                property.state = 'offer_received'
-
-        return super().create(vals)
+    @api.model_create_multi
+    def create(self, vals_list):
+        for vals in vals_list:
+            property_id = vals.get('property_id')
+            amount = vals.get('price')
+
+            if property_id and amount:
+                existing_offers = self.search([
+                    ('property_id', '=', property_id),
+                    ('price', '>=', amount)
+                ])
+                if existing_offers:
+                    raise ValidationError("An offer with a higher or equal price already exists.")
+
+                property = self.env['estate.property'].browse(property_id)
+                if property.state == 'new':
+                    property.state = 'offer_received'
+
+        return super().create(vals_list)

estate-gasa/models/__init__.py renamed to estate_gasa/models/__init__.py

@@ -13,11 +13,11 @@ class EstatePropertyType(models.Model):
     _sql_constraints = [
     ('unique_property_type_name', 'UNIQUE(name)',
      'Property type name must be unique.'),
-    ] 
+    ]
     offer_ids = fields.One2many('estate.property.offer', 'property_type_id', string="Offers")
     offer_count = fields.Integer(compute='_compute_offer_count')
 
     @api.depends('offer_ids')
     def _compute_offer_count(self):
-      for rec in self:
-        rec.offer_count = len(rec.offer_ids)
+        for rec in self:
+            rec.offer_count = len(rec.offer_ids)

estate-gasa/models/estate.py renamed to estate_gasa/models/estate.py

@@ -0,0 +1,12 @@
+from odoo import fields, models
+
+
+class InheritedModel(models.Model):
+    _inherit = "res.users"
+
+    property_ids = fields.One2many(
+        "estate.property",
+        "seller",
+        string="Properties",
+        domain=[('state', '!=', 'cancelled')]
+    )