Skip to content

Commit 5716b66

Browse files
committed
final attempt fixing tests
1 parent 3f32eed commit 5716b66

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

app/src/main/kotlin/com/k0d4black/theforce/features/character_details/CharacterDetailViewModel.kt

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import com.k0d4black.theforce.mappers.toPresentation
1414
import com.k0d4black.theforce.models.FilmPresentation
1515
import com.k0d4black.theforce.models.PlanetPresentation
1616
import com.k0d4black.theforce.models.SpeciePresentation
17-
import kotlinx.coroutines.Dispatchers
1817
import kotlinx.coroutines.flow.collect
1918
import kotlinx.coroutines.launch
2019
import javax.inject.Inject
@@ -41,33 +40,33 @@ class CharacterDetailViewModel @Inject constructor(
4140
private var _species = MutableLiveData<List<SpeciePresentation>>()
4241

4342
fun getCharacterDetails(characterUrl: String) {
44-
viewModelScope.launch(Dispatchers.IO + handler) {
45-
_uiState.postValue(Loading)
43+
viewModelScope.launch(handler) {
44+
_uiState.value = Loading
4645
loadPlanet(characterUrl)
4746
loadFilms(characterUrl)
4847
loadSpecies(characterUrl)
49-
_uiState.postValue(Success(Unit))
48+
_uiState.value = Success(Unit)
5049
}
5150
}
5251

5352
private suspend fun loadPlanet(characterUrl: String) {
5453
getPlanetUseCase(characterUrl).collect { planet ->
5554
val planetPresentation = planet.toPresentation()
56-
_planet.postValue(planetPresentation)
55+
_planet.value = planetPresentation
5756
}
5857
}
5958

6059
private suspend fun loadFilms(characterUrl: String) {
6160
getFilmsUseCase(characterUrl).collect { films ->
6261
val filmsPresentation = films.map { eachFilm -> eachFilm.toPresentation() }
63-
_films.postValue(filmsPresentation)
62+
_films.value = filmsPresentation
6463
}
6564
}
6665

6766
private suspend fun loadSpecies(characterUrl: String) {
6867
getSpeciesUseCase(characterUrl).collect { species ->
6968
val speciesPresentation = species.map { eachSpecie -> eachSpecie.toPresentation() }
70-
_species.postValue(speciesPresentation)
69+
_species.value = speciesPresentation
7170
}
7271
}
7372

app/src/main/kotlin/com/k0d4black/theforce/features/character_search/CharacterSearchViewModel.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ class CharacterSearchViewModel @Inject constructor(
1616
) : UiStateViewModel() {
1717

1818
fun executeCharacterSearch(characterName: String) {
19-
viewModelScope.launch(Dispatchers.IO + handler) {
20-
_uiState.postValue(Loading)
19+
viewModelScope.launch(handler) {
20+
_uiState.value = Loading
2121
searchCharactersUseCase(characterName).collect { results ->
2222
val characters = results.map { character -> character.toPresentation() }
23-
_uiState.postValue(Success(characters))
23+
_uiState.value = Success(characters)
2424
}
2525
}
2626
}

app/src/test/kotlin/com/k0d4black/theforce/viewmodels/CharacterDetailViewModelTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ internal class CharacterDetailViewModelTest : BaseViewModelTest() {
5656
Truth.assertThat(filmPresentation)
5757
.isEqualTo(SampleData.films.map { it.toPresentation() })
5858
}
59-
characterDetailViewModel.planet1.observeOnce { planetPresentation->
59+
characterDetailViewModel.planet.observeOnce { planetPresentation->
6060
Truth.assertThat(planetPresentation).isEqualTo(SampleData.planet.toPresentation())
6161
}
6262
}

0 commit comments

Comments
 (0)