fix number format exception

Author: odaridavid

app/build.gradle

@@ -26,15 +26,6 @@ jacocoAndroidUnitTestReport {
 
 android {
 
-    signingConfigs {
-        release {
-            keyAlias "theforcekey"
-            keyPassword "theforce2020"
-            storeFile file("../theforce.jks")
-            storePassword "theforce2020"
-        }
-    }
-
     compileSdkVersion rootProject.ext.compileSdkVersion
     buildToolsVersion rootProject.ext.buildToolsVersion
 

app/src/main/kotlin/com/k0d4black/theforce/features/character_details/CharacterDetailActivity.kt

@@ -118,18 +118,22 @@ class CharacterDetailActivity : AppCompatActivity() {
         onNetworkChange { isConnected ->
             characterDetailViewModel.detailViewState.value?.let { viewState ->
                 if (isConnected && viewState.error != null) {
-                    binding.filmsLayout.filmsErrorTextView.remove()
-                    binding.planetLayout.planetErrorTextView.remove()
-                    binding.specieLayout.specieErrorTextView.remove()
-                    binding.filmsLayout.filmsProgressBar.show()
-                    binding.planetLayout.planetProgressBar.show()
-                    binding.specieLayout.speciesProgressBar.show()
+                    resolveErrorViewState()
                     characterDetailViewModel.getCharacterDetails(characterUrl, isRetry = true)
                 }
             }
         }
     }
 
+    private fun resolveErrorViewState() {
+        binding.filmsLayout.filmsErrorTextView.remove()
+        binding.planetLayout.planetErrorTextView.remove()
+        binding.specieLayout.specieErrorTextView.remove()
+        binding.filmsLayout.filmsProgressBar.show()
+        binding.planetLayout.planetProgressBar.show()
+        binding.specieLayout.speciesProgressBar.show()
+    }
+
     private fun onNetworkChange(block: (Boolean) -> Unit) {
         NetworkUtils.getNetworkStatus(this)
             .observe(this, Observer { isConnected ->

app/src/main/kotlin/com/k0d4black/theforce/features/character_details/CharacterDetailViewModel.kt

@@ -1,7 +1,11 @@
 package com.k0d4black.theforce.features.character_details
 
+import android.util.Log
 import androidx.annotation.StringRes
-import androidx.lifecycle.*
+import androidx.lifecycle.LiveData
+import androidx.lifecycle.MutableLiveData
+import androidx.lifecycle.ViewModel
+import androidx.lifecycle.viewModelScope
 import com.k0d4black.theforce.commons.ExceptionHandler
 import com.k0d4black.theforce.domain.usecases.FilmsUseCase
 import com.k0d4black.theforce.domain.usecases.PlanetUseCase
@@ -27,6 +31,7 @@ internal class CharacterDetailViewModel(
     private var _detailViewState = MutableLiveData<CharacterDetailsViewState>()
 
     private val characterDetailExceptionHandler = CoroutineExceptionHandler { _, exception ->
+        Log.d("Character Detail VM", "$exception")
         val message = ExceptionHandler.parse(exception)
         _detailViewState.value = _detailViewState.value?.copy(error = Error(message))
     }
@@ -47,14 +52,10 @@ internal class CharacterDetailViewModel(
             _detailViewState.value = _detailViewState.value?.copy(error = null)
         }
         viewModelScope.launch(characterDetailExceptionHandler) {
-            val planetRequest = async { loadPlanet(characterUrl) }
-            val filmsRequest = async { loadFilms(characterUrl) }
-            val speciesRequest = async { loadSpecies(characterUrl) }
-            planetRequest.await()
-            filmsRequest.await()
-            speciesRequest.await()
+            async { loadPlanet(characterUrl) }.await()
+            async { loadFilms(characterUrl) }.await()
+            async { loadSpecies(characterUrl) }.await()
             _detailViewState.value = _detailViewState.value?.copy(isComplete = true)
-
         }
     }
 

app/src/main/kotlin/com/k0d4black/theforce/features/character_search/CharacterSearchViewModel.kt

@@ -21,7 +21,6 @@ internal class CharacterSearchViewModel(
     private var _searchViewState = MutableLiveData<SearchViewState>()
 
     private val searchExceptionHandler = CoroutineExceptionHandler { _, exception ->
-        Log.d("Vm","$exception")
         val message = ExceptionHandler.parse(exception)
         _searchViewState.value = Error(message)
     }

app/src/main/kotlin/com/k0d4black/theforce/mappers/DomainToPresentation.kt

@@ -22,7 +22,7 @@ fun Character.toPresentation(): CharacterPresentation {
 }
 
 fun Planet.toPresentation(): PlanetPresentation {
-    val populationAsLong = if (this.population.contains("Unknown")) 0L else this.population.toLong()
+    val populationAsLong = if (this.population.contains("unknown")) 0L else this.population.toLong()
     return PlanetPresentation(this.name, populationAsLong)
 }