[BUG]: Paginate method yields stale data

[JSFernandes]

What happened?

I was using the Octokit gem to iterate through issues with a given block:

client.paginate('/repos/rails/rails/issues') do |batch|
  puts "Batch from #{batch.first.number} to #{batch.last.number}"
end

This was always yielding the same batch to the block. I then investigated the source code and this indeed the case:

octokit.rb/lib/octokit/connection.rb

Line 90 in ea3413c

yield(data, @last_response)

data is never modified, yet always yielded to the block. It will always correspond to the data from the initial request.

Assuming that this isn't intentional, may I work on a fix for it?

PS: The documentation for this also looks incorrect or outdated https://docs.github.com/en/rest/guides/scripting-with-the-rest-api-and-ruby?apiVersion=2022-11-28#making-paginated-requests

Versions

Octokit gem 10.0.0
Ruby version 3.3.4

Relevant log output

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀