Skip to content

Conversation

@jeffgran-dox
Copy link
Contributor

Adds /healthcheck endpoints to the app and webhook servers so that k8s deployment can check when the node is up.

Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is a GRPC service, I think I'd rather see us register the healthpb service and use a grpc probe, which thanksfully k8s now has.

I think it basically entails importing:

	"google.golang.org/grpc/health"
	healthpb "google.golang.org/grpc/health/grpc_health_v1"

and then doing something like this to register the service:

	// Register health check service
	healthServer := health.NewServer()
	healthpb.RegisterHealthServer(d.Server, healthServer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants