fix-update: updated package dependency not to catch exceptions and removed unnecessary comments

Signed-off-by: kemsguy7 <[email protected]>

Author: kemsguy7

src/dune_lang/package_dependency.ml

@@ -1,4 +1,4 @@
-open! Stdune
+open Import
 
 type t =
   { name : Package_name.t
@@ -41,56 +41,59 @@ let encode { name; constraint_ } =
 ;;
 
 (* Check for common typos in package dependency constraints *)
-let check_for_typo ~loc { name; constraint_ } =
-  (* Early return if warnings are disabled *)
-  if Dune_config.Config.(get typo_warnings) <> `Enabled then None
-  else
-    let open Package_constraint in
-    match constraint_ with
-    | Some (Uop (Relop.Eq, Value.String_literal "version")) ->
-      let message =
-        User_message.make
-          ~loc
-          [ Pp.textf
-              "Possible typo in constraint for dependency %S: '(= version)' might be a \
-               mistake."
-              (Package_name.to_string name)
-          ]
-          ~hints:
-            [ Pp.textf
-                "Did you mean to use the `:version` variable instead? Example: (depends \
-                 (%s (= :version)))"
-                (Package_name.to_string name)
-            ]
-      in
-      Some message
-    | Some (Bvar var) when String.equal (Package_variable_name.to_string var) "with_test" ->
-      let message =
-        User_message.make
-          ~loc
-          [ Pp.textf
-              "Possible typo in constraint for dependency %S: ':with_test' might be a \
-               mistake."
-              (Package_name.to_string name)
-          ]
-          ~hints:
-            [ Pp.textf
-                "Did you mean to use ':with-test' instead? Example: (depends (%s \
-                 :with-test))"
-                (Package_name.to_string name)
-            ]
-      in
-      Some message
-    | _ -> None
+let dependency_constraint_variable_typo_warnings ~loc { name; constraint_ } =
+  match Dune_config.Config.(get typo_warnings) with
+  | `Enabled ->
+    (match constraint_ with
+     | Some
+         (Package_constraint.Uop
+            (Relop.Eq, Package_constraint.Value.String_literal "version")) ->
+       let message =
+         User_message.make
+           ~loc
+           [ Pp.textf
+               "Possible typo in constraint for dependency %S: '(= version)' might be a \
+                mistake."
+               (Package_name.to_string name)
+           ]
+           ~hints:
+             [ Pp.textf
+                 "Did you mean to use the `:version` variable instead? Example: (depends \
+                  (%s (= :version)))"
+                 (Package_name.to_string name)
+             ]
+       in
+       Some message
+     | Some (Package_constraint.Bvar var)
+       when String.equal (Package_variable_name.to_string var) "with_test" ->
+       let message =
+         User_message.make
+           ~loc
+           [ Pp.textf
+               "Possible typo in constraint for dependency %S: ':with_test' might be a \
+                mistake."
+               (Package_name.to_string name)
+           ]
+           ~hints:
+             [ Pp.textf
+                 "Did you mean to use ':with-test' instead? Example: (depends (%s \
+                  :with-test))"
+                 (Package_name.to_string name)
+             ]
+       in
+       Some message
+     | _ -> None)
+  | `Disabled -> None
+;;
+
 let decode =
-  let open Dune_sexp.Decoder in
+  let open Decoder in
   let constrained =
     let+ loc = loc
     and+ name = Package_name.decode
     and+ expr = Package_constraint.decode in
     let result = { name; constraint_ = Some expr } in
-    (* Check for typos and emit warnings *)
-    (match check_for_typo ~loc result with
+    (match dependency_constraint_variable_typo_warnings ~loc result with
      | Some msg -> User_warning.emit_message msg
      | None -> ());
     result
@@ -111,4 +114,4 @@ let to_dyn { name; constraint_ } =
 let equal { name; constraint_ } t =
   Package_name.equal name t.name
   && Option.equal Package_constraint.equal constraint_ t.constraint_
-;;
+;;