Open
Conversation
SGrondin
reviewed
Jul 9, 2023
Comment on lines
+48
to
+50
| Warning: as with `Fiber.first`, it is possible that two or more streams | ||
| yield an item simultaneously, in which case only one item will be | ||
| returned, and the other items are discarded.*) |
Collaborator
There was a problem hiding this comment.
In my opinion, this caveat is too much at the moment.
I would love to see Eio.Stream.select added, but I think it needs to be done using something like #558
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(for #577)
This is a proposal for a (simplistic) implementation of
Stream.select, which permits watching multiple streams and returning the first item yielded by any of them. It works for the intended use case, although at this point there are two weaknesses, both due to the underlying implementation usingFiber.any:Fiber.anyonly works with fiber functions yielding the same type)Fiber.any). This is documented, but still not desirable.Thanks for considering this - I'd be happy to hear proposals for making this functionality more general, or just not based on the
Fiberfunctions which restrict what can be done here. So please consider it a starting point :-)