-
Notifications
You must be signed in to change notification settings - Fork 20
runner: Add coloured logging #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Few things:
|
|
|
Alright, I removed formatting entirely & ensured it doesn't affect log files. Let me know if it needs anything else. |
|
Hmm, this is a good point. I don't feel particularly comfortable importing a dependency just to colour logs. I'll do some further digging. Do we want to support |
|
Yeah, somewhat selfishly since I do most of my work on windows, so it should work there. Haven't tested in powershell, but no sane person uses powershell. |
The bot is already using third party requirements (requirements.txt), so I don't see why it would be a bad thing. I personally believe that it's better to depend a package that results in more readable code than it is to try to build in that functionality myself in situations like this. |

After a few minutes of using the bot, I realised it'd benefit from some basic colour coding for logging levels.