Skip to content

createIconSet with a glyphmap of UTF-8 strings doesn't work #1839

@jonathanj

Description

@jonathanj

Which package are you using?

@react-native-vector-icons/*

What platform(s) does this occur on?

iOS

Minimal reproducible example

No response

What happened?

It seems this line was changed to always return a literal "?" instead of the glyph, as it did before. Which means that a glyphmap of UTF-8 strings will never work as documented.

Additionally, shouldn't the type for the glyphmap be Record<string, string | number> if UTF-8 strings are supported input?

I'm happy to make a PR for this, but I'm not sure why the change to a literal question mark was introduced.

Relevant log output

Your computer environment

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions