webadmin: fix template creation resource issues

Fixes an issue where creating a template from a VM or VM snapshot
can result in incorrect vCPU values and
potentially incorrect memory values in the template.

With this change, VmListModel.onNewTemplate() now runs model.validate()
so that "Create Template" could fail fast if the VM model is invalid,
instead of creating a template with wrong memory/CPU settings.

Furthermore, getTotalCpuCores() is now called inside a callback function
in order to avoid a race condition.

Signed-off-by: Guoyong Zhang <[email protected]>

Author: zabdulre

frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java

@@ -1326,11 +1326,9 @@ private void onNewTemplate() {
             return;
         }
 
-        if (!model.validateNaming()) {
-            return;
-        }
-
-        if (model.getIsSubTemplate().getEntity()) {
+        if (!model.validate(false)) {
+            model.setIsValid(false);
+        } else if (model.getIsSubTemplate().getEntity()) {
             postNameUniqueCheck();
         } else {
             String name = model.getName().getEntity();
@@ -2193,7 +2191,7 @@ public void executeCommand(UICommand command) {
     }
 
     protected void exportOva() {
-        VM selectedEntity = (VM) getSelectedItem();
+        VM selectedEntity = getSelectedItem();
         if (selectedEntity == null) {
             return;
         }

frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java

@@ -1694,17 +1694,17 @@ public void updateMaxMemory() {
     }
 
     public void updateMemory() {
-        Integer memoryMb = getModel().getMemSize().getEntity();
         AsyncDataProvider.getMinMemoryForOs(new AsyncQuery<>(minMemory -> {
+            Integer memoryMb = getModel().getMemSize().getEntity();
             if (memoryMb == null || memoryMb < minMemory) {
                 getModel().getMemSize().setEntity(minMemory);
             }
         }), getSelectedOSType(), getCompatibilityVersion());
     }
 
     public void updateTotalCpuCores() {
-        int cpuCores = getTotalCpuCores();
         AsyncDataProvider.getMinCpus(new AsyncQuery<>(minCpus -> {
+            int cpuCores = getTotalCpuCores();
             if (cpuCores < minCpus) {
                 getModel().getTotalCPUCores().setEntity(Integer.toString(minCpus));
             }