Green screen with the attached video sample

[kyak]

Originally reported at 7Ji-PKGBUILDs/.meta#29

I'm using kodi-mpp-git and ffmpeg-rockchip-git.

With the attached video sample, mpv --profile=fast --hwdec=rkmpp path-to-file displays green screen.

kodi under GBM (https://github.com/hbiyik/ffmpeg-rockchip/wiki/Rendering#kodi-under-gbm) seems to play it, although displays black screen after stopping the video.

After stopping the video, kodi shows black screen (it doesn't freeze, it really is just a blank or black screen).

I see these messages in journalctl:

kernel: [drm:rockchip_vop2_mod_supported] *ERROR* Unsupported format modifier 0x800000000000051

And these messages in kodi log:

2024-03-14 21:28:00.101 T:328297   error <general>: CDRMAtomic::DrmAtomicCommit - test commit failed: (Invalid argument) - falling back to last successful atomic request
2024-03-14 21:28:00.102 T:328297   error <general>:
                                                   Object: plane        ID: 71
                                                     Property: SRC_X    ID: 9   Value: 0
                                                     Property: SRC_Y    ID: 10  Value: 0
                                                     Property: SRC_W    ID: 11  Value: 251658240
                                                     Property: SRC_H    ID: 12  Value: 141557760
                                                     Property: CRTC_X   ID: 13  Value: 0
                                                     Property: CRTC_Y   ID: 14  Value: 0
                                                     Property: CRTC_W   ID: 15  Value: 3840
                                                     Property: CRTC_H   ID: 16  Value: 2160
                                                     Property: FB_ID    ID: 17  Value: 322
                                                     Property: CRTC_ID  ID: 20  Value: 85
2024-03-14 21:28:00.102 T:328297   error <general>: CDRMAtomic::DrmAtomicCommit - atomic commit failed: Invalid argument

Sorry for gzip'ed mkv, couldn't upload to github otherwise :(

out.mkv.gz

[hbiyik]

and your kernel is?

[kyak]

and your kernel is?

It's 5.10.160

[nyanmisaka]

This clip itself is abnormal. When I play it on other x86 PCs, it also behaves very choppy. When I use ffmpeg-rockchip to transcode on RK3588, the transcoded clip is still very choppy, but there is no green screen here.

transcoded_out.mp4

[hbiyik]

dont worry, i reproduced the issue,

true that, the file is acting weird, but blue/green screen is because of the dimensions

w = 912,
stride = 57*16 (this is what mpp is using align to 16) = 912
but mesa (EGL/mpv) expect 912 to be 64 dividable, 912/64 = 14.25, so wont work

however gbm should have still worked, seems like there is something weird there, i m trying find out if this is kernel related or xbmc related....

[hbiyik]

to prevent kodi/gbm issues in the meanwhile you can use without afbc mdoe as below

kodi --windowing=gbm --audio-backend=alsa

it should work (as long the file is not corrupted, the file seems to be corrupted)

do not add env variable FFMPEG_RKMPP_DEC_OPT="afbc=on" , there seems to be an issue there.

[nyanmisaka]

I think I know why. I've been using the mpp patch for Jellyfin to avoid 64-aligned issues when using RGA3. Maybe you should add these two to the repository too.

nyanmisaka/mpp@6e76ecb
nyanmisaka/mpp@6221ca8

[hbiyik]

ok what if vp9 or hevc, are they 256 aligned?

and mpeg1/2/4... DVD stuff

[nyanmisaka]

iirc vp9 and hevc should both be 256-aligned. I forgot mpeg1/2/4, will add it later.

[hbiyik]

i think not always, only when above certain size, at least for either vp9 or hevc afaik...

[hbiyik]

linking the issue for future reference rockchip-linux/mpp#507

[hbiyik]

Found the root cause of GBM problem

xbmc/xbmc#24431 (comment)

i will push a fix, in the meanwhile you can disable afbc mode by not passing the env value