Skip to content

Commit 5d64a46

Browse files
author
Robert Liao
committed
Use the Native Certificate Viewer on MacOS even on MacViews
BUG=766926 Change-Id: I6d0302763687bbb4fe30682684ad85a2ac79f782 Reviewed-on: https://chromium-review.googlesource.com/1145674 Reviewed-by: Elly Fong-Jones <[email protected]> Commit-Queue: Robert Liao <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#577201}(cherry picked from commit 7fbbd5f) Reviewed-on: https://chromium-review.googlesource.com/1148610 Reviewed-by: Robert Liao <[email protected]> Cr-Commit-Position: refs/branch-heads/3497@{#51} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
1 parent f37fee3 commit 5d64a46

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

chrome/browser/ui/views/ssl_client_certificate_selector.cc

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -142,14 +142,11 @@ void ShowSSLClientCertificateSelector(
142142
net::ClientCertIdentityList client_certs,
143143
std::unique_ptr<content::ClientCertificateDelegate> delegate) {
144144
#if defined(OS_MACOSX)
145-
// TODO(ellyjones): Always use the Cocoa cert selector, even in Views builds.
146-
// See also https://crbug.com/804950.
147-
if (views_mode_controller::IsViewsBrowserCocoa()) {
148-
return ShowSSLClientCertificateSelectorCocoa(contents, cert_request_info,
149-
std::move(client_certs),
150-
std::move(delegate));
151-
}
152-
#endif
145+
return ShowSSLClientCertificateSelectorCocoa(contents, cert_request_info,
146+
std::move(client_certs),
147+
std::move(delegate));
148+
#else // defined(OS_MACOSX)
149+
153150
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
154151

155152
// Not all WebContentses can show modal dialogs.
@@ -164,6 +161,7 @@ void ShowSSLClientCertificateSelector(
164161
std::move(delegate));
165162
selector->Init();
166163
selector->Show();
164+
#endif // defined(OS_MACOSX)
167165
}
168166

169167
} // namespace chrome

0 commit comments

Comments
 (0)