Commit d475146
committed
Remove invalid kustomizeconfig from config/webhook
This change has no effect on the output of this kustomization because
the removed configuration was redundant. However, it fixes a bug which
can be triggered when using this kustomization as a base for another
kustomization.
kustomizeconfig contained 3 directives:
* nameReference
* namespace
* varReference
varReference remains required until vars are removed from this
kustomization.
nameReference is redundant because the specified configuration is
already in kustomize's defaults. However, nameReference is the important
transformation here.
namespace is incorrect. It directs the namespace transformer to update
webhooks/clientConfig/service/namespace. However, this is not the
intended function of the namespace transformer: it should only set the
namespace directly on objects and allow references to be updated
automatically by nameReference. Configuring it to update a reference
directly leaves kustomize with inconsistent internal state. Depending on
execution order this can cause a subsequent transformation to fail to
update the reference when it makes further changes to the Service
object.1 parent 26c3586 commit d475146
1 file changed
+2
-23
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
| 1 | + | |
| 2 | + | |
24 | 3 | | |
25 | 4 | | |
0 commit comments