NDK is not set up properly with the `1.6.0` release

[marekszulik]

Our repo was using the action and was pointed at the v1 tag, so the recent v1.6.0 release got picked up automatically. That caused our builds to fail with the following error:

C/C++: CMake Error at CMakeLists.txt:1 (project):
C/C++:   The CMAKE_C_COMPILER:
C/C++:     /usr/local/lib/***/sdk/ndk/27.0.12077973/toolchains/llvm/prebuilt/linux-x86_64/bin/clang
C/C++:   is not a full path to an existing compiler tool.
C/C++:   Tell CMake where to find the compiler by setting either the environment
C/C++:   variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
C/C++:   the compiler, or to the compiler name if it is in the PATH.
C/C++: CMake Error at CMakeLists.txt:1 (project):
C/C++:   The CMAKE_CXX_COMPILER:
C/C++:     /usr/local/lib/***/sdk/ndk/27.0.12077973/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++
C/C++:   is not a full path to an existing compiler tool.
C/C++:   Tell CMake where to find the compiler by setting either the environment
C/C++:   variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
C/C++:   to the compiler, or to the compiler name if it is in the PATH.

Our action setup:

      - name: Setup NDK
        uses: nttld/setup-ndk@v1
        id: setup-ndk
        with:
          ndk-version: r27
          link-to-sdk: true
          local-cache: true

For the time being we've reverted to v1.5.0 and it works fine.

[raftario]

Is the repo where this happened public so I can try to repro ? And if not are you able to provide a minimal reproducer ?

[marekszulik]

Repo is not public. I can work on preparing a public repo as a minimal reproducer next week.

[AnthonyRonning]

Confirmed v1.5.0 downgrade fixed it for me. Something broken with the new version. You can check the linked reference above.

[raftario]

Given none of the implementation changed I'm suspecting GH somehow broke ZIP extraction in their actions packages, which wouldn't surprise me given how broken Actions are in general. I'll create a new branch and revert to the old packages apart from the cache when I have some time, would appreciate your help for testing that fix then :)

[marekszulik]

Given none of the implementation changed I'm suspecting GH somehow broke ZIP extraction in their actions packages, which wouldn't surprise me given how broken Actions are in general. I'll create a new branch and revert to the old packages apart from the cache when I have some time, would appreciate your help for testing that fix then :)

There might be something to it perhaps. The log for the extraction has changed from:

/usr/bin/tar --posix -cf cache.tzst --exclude cache.tzst -P -C /home/runner/_work/project/project --files-from manifest.txt --use-compress-program zstdmt

to

/usr/bin/tar -xf /home/runner/_work/_temp/0b583e41-1490-48d0-a5fc-764b1b5b8d44/cache.tzst -P -C /home/runner/_work/project/project --use-compress-program unzstd

[AnthonyRonning]

this is still an issue. What's going on and why is there still a broken latest?

[raftario]

What's going on is that this action which I personally have not used in years is broken on custom runners due to code maintained by GitHub themselves. I do not have custom runners to test a fix, neither have I had the time to work on one. If this is a pressing matter to you, you are more than welcome to open a PR with a fix, and I will gladly merge and release it :)