fix(devkit): include UPDATE changes in findCreatedProjectFiles for generator callbacks (#31429)

## Current Behavior

getProjects(Tree) from project-configuration.ts does not return projects
created in generators when called from generator callbacks. This happens
because findCreatedProjectFiles only looks for changes with type ===
'CREATE', but during callbacks, the tree has already been flushed to
disk, so newly created project files are marked as 'UPDATE' instead of
'CREATE'.

## Expected Behavior

getProjects(Tree) should return all projects, including those created
during the current generator run, even when called from generator
callbacks.

## Changes Made

- Modified findCreatedProjectFiles() to include both CREATE and UPDATE
changes
- Added deduplication using Set to prevent duplicate project files
- Added comprehensive test coverage for the callback scenario

## Related Issue(s)

Fixes #29852

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: AgentEnder <[email protected]>
(cherry picked from commit d298de5)

Author: 2 people

packages/nx/src/generators/utils/project-configuration.spec.ts

@@ -173,6 +173,38 @@ describe('project configuration', () => {
     });
   });
 
+  it('should find projects created during generator run when called from callback', () => {
+    // Simulate what happens during a generator callback:
+    // 1. A project is created during generator execution
+    addProjectConfiguration(tree, 'test-proj', {
+      root: 'libs/test-proj',
+    });
+
+    // Verify the project is found before callback
+    let projects = getProjects(tree);
+    expect(projects.size).toEqual(1);
+    expect(projects.has('test-proj')).toBeTruthy();
+
+    // 2. Simulate changes being flushed to disk by modifying the tree
+    // to mark the file as UPDATE instead of CREATE
+    const projectJsonPath = 'libs/test-proj/project.json';
+    const projectJsonContent = tree.read(projectJsonPath, 'utf-8');
+
+    // Clear the tree and write the file again to simulate it being flushed
+    // This creates a scenario similar to what happens in callbacks
+    tree.write(projectJsonPath, projectJsonContent);
+
+    // 3. getProjects should still find the project even when it's marked as UPDATE
+    projects = getProjects(tree);
+    expect(projects.size).toEqual(1);
+    expect(projects.has('test-proj')).toBeTruthy();
+    expect(projects.get('test-proj')).toEqual({
+      $schema: '../../node_modules/nx/schemas/project-schema.json',
+      name: 'test-proj',
+      root: 'libs/test-proj',
+    });
+  });
+
   describe('without nx.json', () => {
     beforeEach(() => tree.delete('nx.json'));
 

packages/nx/src/generators/utils/project-configuration.ts

@@ -268,7 +268,9 @@ function readAndCombineAllProjectConfigurations(tree: Tree): {
   const globbedFiles = globWithWorkspaceContextSync(tree.root, patterns);
   const createdFiles = findCreatedProjectFiles(tree, patterns);
   const deletedFiles = findDeletedProjectFiles(tree, patterns);
-  const projectFiles = [...globbedFiles, ...createdFiles].filter(
+  // Ensure we don't duplicate files that are both globbed and in tree changes
+  const allProjectFiles = new Set([...globbedFiles, ...createdFiles]);
+  const projectFiles = Array.from(allProjectFiles).filter(
     (r) => deletedFiles.indexOf(r) === -1
   );
 
@@ -326,7 +328,10 @@ function findCreatedProjectFiles(tree: Tree, globPatterns: string[]) {
   const createdProjectFiles = [];
 
   for (const change of tree.listChanges()) {
-    if (change.type === 'CREATE') {
+    // Include both CREATE and UPDATE changes to handle project files
+    // created during generator callbacks (which are marked as UPDATE
+    // since the tree has already been flushed to disk)
+    if (change.type === 'CREATE' || change.type === 'UPDATE') {
       const fileName = basename(change.path);
       if (
         globPatterns.some((pattern) =>