From 1d9e20ad3b2c4ae423e01881a6d16334edf3d510 Mon Sep 17 00:00:00 2001 From: Samuel Loup Date: Thu, 9 Jun 2022 15:26:33 +0200 Subject: [PATCH 1/6] Impl. IsIconic --- src/c++/window.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/c++/window.cpp b/src/c++/window.cpp index c0d6dee..d7e8d35 100644 --- a/src/c++/window.cpp +++ b/src/c++/window.cpp @@ -99,6 +99,7 @@ Napi::Object Window::Init(Napi::Env env, Napi::Object exports) { InstanceMethod("getHwnd", &Window::GetHwnd), InstanceMethod("getDimensions", &Window::GetDimensions), InstanceMethod("isVisible", &Window::IsVisible), + InstanceMethod("isIconic", &Window::IsIconic), InstanceMethod("exists", &Window::Exists), InstanceMethod("getTitle", &Window::GetTitle), InstanceMethod("getClassName", &Window::GetClassName), @@ -237,6 +238,11 @@ Napi::Value Window::IsVisible(const Napi::CallbackInfo& info) { return Napi::Boolean::New(info.Env(), returned); } +Napi::Value Window::IsIconic(const Napi::CallbackInfo& info) { + bool returned = IsWindowIconic(this->_identifier); + return Napi::Boolean::New(info.Env(), returned); +} + Napi::Value Window::Exists(const Napi::CallbackInfo& info) { bool returned = IsWindow(this->_identifier); return Napi::Boolean::New(info.Env(), returned); From afd3befc713eed9bac27b33a3674114a69421c9f Mon Sep 17 00:00:00 2001 From: Samuel Loup Date: Thu, 9 Jun 2022 15:27:15 +0200 Subject: [PATCH 2/6] Impl. IsIconic --- src/c++/window.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/c++/window.hpp b/src/c++/window.hpp index 97eaa71..210ab54 100644 --- a/src/c++/window.hpp +++ b/src/c++/window.hpp @@ -23,6 +23,7 @@ class Window : public Napi::ObjectWrap { Napi::Value GetHwnd(const Napi::CallbackInfo &info); Napi::Value GetDimensions(const Napi::CallbackInfo& info); Napi::Value IsVisible(const Napi::CallbackInfo& info); + Napi::Value IsIconic(const Napi::CallbackInfo& info); Napi::Value Exists(const Napi::CallbackInfo& info); Napi::Value GetTitle(const Napi::CallbackInfo& info); Napi::Value GetClassName(const Napi::CallbackInfo& info); From 9e62e4cc5da961973008c646da6432ad43cfd188 Mon Sep 17 00:00:00 2001 From: Samuel Loup Date: Thu, 9 Jun 2022 15:30:50 +0200 Subject: [PATCH 3/6] Use correct win32 API --- src/c++/window.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/c++/window.cpp b/src/c++/window.cpp index d7e8d35..e88fff8 100644 --- a/src/c++/window.cpp +++ b/src/c++/window.cpp @@ -239,7 +239,7 @@ Napi::Value Window::IsVisible(const Napi::CallbackInfo& info) { } Napi::Value Window::IsIconic(const Napi::CallbackInfo& info) { - bool returned = IsWindowIconic(this->_identifier); + bool returned = IsIconic(this->_identifier); return Napi::Boolean::New(info.Env(), returned); } From 72d05d944a5dbb17003797ea1a14014c5f3dd6e0 Mon Sep 17 00:00:00 2001 From: Samuel Loup Date: Thu, 9 Jun 2022 15:34:23 +0200 Subject: [PATCH 4/6] Update doc --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index cf9869b..3f83e46 100644 --- a/README.md +++ b/README.md @@ -93,6 +93,10 @@ Returns a `boolean` indicating if the window still exists Returns a `boolean` indicating if the window is visible +#### #isMinimized() + +Returns a `boolean` indicating if the window is minimized (iconic). + #### #getDimensions() Retrieves the dimensions of the bounding rectangle of the specified window. The dimensions are given in screen coordinates that are relative to the upper-left corner of the screen. From 9b26d6302e76ecdc232bd694536fdd7be37ae979 Mon Sep 17 00:00:00 2001 From: Samuel Loup Date: Thu, 9 Jun 2022 15:35:25 +0200 Subject: [PATCH 5/6] Rename IsIconic -> IsMinimized More clear in 2022... --- src/c++/window.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/c++/window.hpp b/src/c++/window.hpp index 210ab54..3d1a63b 100644 --- a/src/c++/window.hpp +++ b/src/c++/window.hpp @@ -23,7 +23,7 @@ class Window : public Napi::ObjectWrap { Napi::Value GetHwnd(const Napi::CallbackInfo &info); Napi::Value GetDimensions(const Napi::CallbackInfo& info); Napi::Value IsVisible(const Napi::CallbackInfo& info); - Napi::Value IsIconic(const Napi::CallbackInfo& info); + Napi::Value IsMinimized(const Napi::CallbackInfo& info); Napi::Value Exists(const Napi::CallbackInfo& info); Napi::Value GetTitle(const Napi::CallbackInfo& info); Napi::Value GetClassName(const Napi::CallbackInfo& info); From 2c6dd6ed97541917402ebf5544c99d4dd5487d2d Mon Sep 17 00:00:00 2001 From: Samuel Loup Date: Thu, 9 Jun 2022 15:37:00 +0200 Subject: [PATCH 6/6] Rename IsIconic -> IsMinimized --- src/c++/window.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/c++/window.cpp b/src/c++/window.cpp index e88fff8..86af25b 100644 --- a/src/c++/window.cpp +++ b/src/c++/window.cpp @@ -99,7 +99,7 @@ Napi::Object Window::Init(Napi::Env env, Napi::Object exports) { InstanceMethod("getHwnd", &Window::GetHwnd), InstanceMethod("getDimensions", &Window::GetDimensions), InstanceMethod("isVisible", &Window::IsVisible), - InstanceMethod("isIconic", &Window::IsIconic), + InstanceMethod("isMinimized", &Window::IsMinimized), InstanceMethod("exists", &Window::Exists), InstanceMethod("getTitle", &Window::GetTitle), InstanceMethod("getClassName", &Window::GetClassName), @@ -238,7 +238,7 @@ Napi::Value Window::IsVisible(const Napi::CallbackInfo& info) { return Napi::Boolean::New(info.Env(), returned); } -Napi::Value Window::IsIconic(const Napi::CallbackInfo& info) { +Napi::Value Window::IsMinimized(const Napi::CallbackInfo& info) { bool returned = IsIconic(this->_identifier); return Napi::Boolean::New(info.Env(), returned); }