From db5c57036de4c7ec32663311112ea2a3fd0399f3 Mon Sep 17 00:00:00 2001 From: Abdirahim Musse <33973272+abmusse@users.noreply.github.com> Date: Thu, 12 Jun 2025 15:38:43 -0500 Subject: [PATCH] test: skip tests that cause timeouts on IBM i I missed marking a couple of test cases flaky in my previous PR: https://github.com/nodejs/node/pull/58583 tests missed were: - parallel.test-inspector-network-content-type - benchmark.test-benchmark-websocket After marking the above flaky I re-ran a test build and noticed the build still failed. Unfortuantely the build still fails because the build detects that node process are left behind after the tests, presumably because tests that spawn child processes are being timed out and only the parent process is killed off, leaving the child processes behind. see: https://github.com/nodejs/node/pull/59014#issuecomment-3057162303 We've decided to skip these tests until the underlying issue is resolved. The tests being skipped are: - parallel.test-http-proxy-fetch - parallel.test-https-proxy-fetch - benchmark.test-benchmark-websocket - parallel.test-inspector-network-fetch - parallel.test-inspector-network-content-type - es-module.test-wasm-web-api - parallel.test-fetch - parallel.test-without-async-context-frame - report.test-report-exclude-network --- test/benchmark/benchmark.status | 2 ++ test/es-module/es-module.status | 2 +- test/parallel/parallel.status | 11 ++++++----- test/report/report.status | 2 +- 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/test/benchmark/benchmark.status b/test/benchmark/benchmark.status index 9487ac00829783..ea666f58a73aeb 100644 --- a/test/benchmark/benchmark.status +++ b/test/benchmark/benchmark.status @@ -23,3 +23,5 @@ test-benchmark-crypto: PASS, FLAKY [$arch==arm] +[$system==ibmi] +test-benchmark-websocket: SKIP diff --git a/test/es-module/es-module.status b/test/es-module/es-module.status index 32b712cbef0c8f..376b9cdeb07b78 100644 --- a/test/es-module/es-module.status +++ b/test/es-module/es-module.status @@ -16,4 +16,4 @@ test-wasm-web-api: SKIP [$system==ibmi] # https://github.com/nodejs/node/issues/58582 -test-wasm-web-api: PASS,FLAKY +test-wasm-web-api: SKIP diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index 9c534c4492ae4c..77682bc8498fbd 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -127,11 +127,12 @@ test-tls-write-error: PASS, FLAKY # https://github.com/nodejs/node/issues/48047 test-http-pipeline-flood: SKIP # https://github.com/nodejs/node/issues/58582 -test-http-proxy-fetch: PASS, FLAKY -test-https-proxy-fetch: PASS, FLAKY -test-inspector-network-fetch: PASS, FLAKY -test-fetch: PASS, FLAKY -test-without-async-context-frame: PASS, FLAKY +test-http-proxy-fetch: SKIP +test-https-proxy-fetch: SKIP +test-inspector-network-fetch: SKIP +test-inspector-network-content-type: SKIP +test-fetch: SKIP +test-without-async-context-frame: SKIP test-process-cpuUsage: PASS, FLAKY diff --git a/test/report/report.status b/test/report/report.status index 3832cb760db735..2aaf4228c7caba 100644 --- a/test/report/report.status +++ b/test/report/report.status @@ -12,4 +12,4 @@ test-report-fatal-error: PASS, FLAKY [$system==ibmi] # https://github.com/nodejs/node/issues/58582 -test-report-exclude-network: PASS,FLAKY +test-report-exclude-network: SKIP