Skip to content

doc: add missing <code> blocks #58995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

doc: add missing <code> blocks #58995

merged 1 commit into from
Jul 10, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 8, 2025

No description provided.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 8, 2025
@aduh95 aduh95 mentioned this pull request Jul 8, 2025
Open
4 tasks
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (1c4fe6d) to head (524ec93).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58995      +/-   ##
==========================================
- Coverage   90.08%   90.06%   -0.02%     
==========================================
  Files         641      641              
  Lines      188718   188718              
  Branches    37022    37022              
==========================================
- Hits       170000   169975      -25     
- Misses      11417    11461      +44     
+ Partials     7301     7282      -19

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Hardanish-Singh
Hardanish-Singh reviewed Jul 8, 2025
View reviewed changes
Copy link

@Hardanish-Singh Hardanish-Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. doc Issues and PRs related to the documentations. and removed needs-ci PRs that need a full CI run. labels Jul 8, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit e3eeba9 into nodejs:main Jul 10, 2025
34 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e3eeba9

@aduh95 aduh95 deleted the code-blocks branch July 10, 2025 18:32
targos pushed a commit that referenced this pull request Jul 17, 2025
@aduh95 @targos
doc: add missing <code> blocks
3924c43 
PR-URL: #58995
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hardanish-Singh Hardanish-Singh Hardanish-Singh left review comments

@lpinca lpinca lpinca approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @lpinca @juanarbol @Hardanish-Singh