-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Open
Labels
async_local_storageAsyncLocalStorageAsyncLocalStoragediag-agendaIssues and PRs to discuss during the meetings of the diagnostics working group.Issues and PRs to discuss during the meetings of the diagnostics working group.
Description
Short after #55552 was merged I notices that this resulted in loosing a lot test for AsyncLocalStore
.
Before AsyncLocalStore
was based on async hooks. There are plenty of tests for async hooks which implict verified that AsyncLocalStore
does what it is expected.
But since #55552 AsyncLocalStore
and async hooks are independent.
I don't think we have to dup them all, but there are some special cases at least in HTTP area (e.g. here) which might require followups.
fyi @nodejs/diagnostics
Edit 21.11.: corrected link to PR
tonivj5
Metadata
Metadata
Assignees
Labels
async_local_storageAsyncLocalStorageAsyncLocalStoragediag-agendaIssues and PRs to discuss during the meetings of the diagnostics working group.Issues and PRs to discuss during the meetings of the diagnostics working group.