test: migrate message tests to js fixtures squashed

projectnoa · projectnoa · commit 2df37deb7ead · 2023-05-23T12:26:15.000-07:00
test: migrate message tests to js fixtures squashed

Add test runners to /parallel dir and fix snapshot

Update test/parallel/test-node-output-tick.mjs

Co-authored-by: Moshe Atlow &lt;moshe@atlow.co.il&gt;

Update test/parallel/test-node-output-promise.mjs

Co-authored-by: Moshe Atlow &lt;moshe@atlow.co.il&gt;

Update test/parallel/test-node-output-assertion.mjs

Co-authored-by: Moshe Atlow &lt;moshe@atlow.co.il&gt;

Update test/parallel/test-node-output-map.mjs

Co-authored-by: Moshe Atlow &lt;moshe@atlow.co.il&gt;

fixed snapshot discrepancy with output-errors.mjs

Corrected test runner name prefix

Removing snapshots that show as 'new' on git diff

Restored deleted files

Deleted files restored
diff --git a/BUILDING.md b/BUILDING.md
@@ -333,10 +333,10 @@ tools/test.py child-process
 ```
 
 You can also execute the tests in a test suite directory
-(such as `test/message`):
+(such as `test/report`):
 
-```bash
-tools/test.py test/message
+```text
+$ tools/test.py test/report
 ```
 
 If you want to check the other options, please refer to the help by using
@@ -347,7 +347,7 @@ tools/test.py --help
 ```
 
 > Note: On Windows you should use `python3` executable.
-> Example: `python3 tools/test.py test/message`
+> Example: `python3 tools/test.py test/report`
 
 You can usually run tests directly with node:
 
diff --git a/test/fixtures/assertion/assert_throws_stack.js b/test/fixtures/assertion/assert_throws_stack.js
@@ -1,6 +1,6 @@
 'use strict';
 
-require('../common');
+require('../../common');
 const assert = require('assert').strict;
 
 assert.throws(() => { throw new Error('foo'); }, { bar: true });
diff --git a/test/fixtures/assertion/assert_throws_stack.snapshot b/test/fixtures/assertion/assert_throws_stack.snapshot
@@ -9,7 +9,8 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
 - Comparison {
 -   bar: true
 - }
-    at Object.<anonymous> (*assert_throws_stack.js:*:*)
+    at *
+    at *
     at *
     at *
     at *
@@ -19,16 +20,16 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
   generatedMessage: true,
   code: 'ERR_ASSERTION',
   actual: Error: foo
-      at assert.throws.bar (*assert_throws_stack.js:*)
-      at getActual (node:assert:*)
-      at Function.throws (node:assert:*)
-      at Object.<anonymous> (*assert_throws_stack.js:*:*)
       at *
       at *
       at *
       at *
       at *
-      at *,
+      at *
+      at *
+      at *
+      at *
+      at node:internal*main*run_main_module:*:*,
   expected: { bar: true },
   operator: 'throws'
 }
diff --git a/test/fixtures/assertion/internal_assert.js b/test/fixtures/assertion/internal_assert.js
@@ -1,7 +1,7 @@
 'use strict';
 
 // Flags: --expose-internals
-require('../common');
+require('../../common');
 
 const assert = require('internal/assert');
 assert(false);
diff --git a/test/fixtures/assertion/internal_assert.snapshot b/test/fixtures/assertion/internal_assert.snapshot
@@ -1,13 +1,13 @@
-node:internal/assert:*
+node:internal*assert:*
     throw new ERR_INTERNAL_ASSERTION(message);
     ^
 
 Error [ERR_INTERNAL_ASSERTION]: This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
-Please open an issue with this stack trace at https://github.com/nodejs/node/issues
+Please open an issue with this stack trace at https:*github.com*nodejs*node*issues
 
-    at new NodeError (node:internal/errors:*:*)
-    at assert (node:internal/assert:*:*)
-    at * (*test*message*internal_assert.js:7:1)
+    at *
+    at *
+    at *
     at *
     at *
     at *
diff --git a/test/fixtures/assertion/internal_assert_fail.js b/test/fixtures/assertion/internal_assert_fail.js
@@ -1,7 +1,7 @@
 'use strict';
 
 // Flags: --expose-internals
-require('../common');
+require('../../common');
 
 const assert = require('internal/assert');
 assert.fail('Unreachable!');
diff --git a/test/fixtures/assertion/internal_assert_fail.snapshot b/test/fixtures/assertion/internal_assert_fail.snapshot
@@ -1,14 +1,14 @@
-node:internal/assert:*
+node:internal*assert:*
   throw new ERR_INTERNAL_ASSERTION(message);
   ^
 
 Error [ERR_INTERNAL_ASSERTION]: Unreachable!
 This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
-Please open an issue with this stack trace at https://github.com/nodejs/node/issues
+Please open an issue with this stack trace at https:*github.com*nodejs*node*issues
 
-    at new NodeError (node:internal/errors:*:*)
-    at Function.fail (node:internal/assert:*:*)
-    at * (*test*message*internal_assert_fail.js:7:8)
+    at *
+    at *
+    at *
     at *
     at *
     at *
diff --git a/test/fixtures/console/core_line_numbers.js b/test/fixtures/console/core_line_numbers.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+require('../../common');
 Error.stackTraceLimit = 3;
 
 const punycode = require('punycode');
diff --git a/test/fixtures/console/eval_messages.js b/test/fixtures/console/eval_messages.js
@@ -21,7 +21,7 @@
 
 'use strict';
 
-require('../common');
+require('../../common');
 
 const spawn = require('child_process').spawn;
 
diff --git a/test/fixtures/console/stdin_messages.js b/test/fixtures/console/stdin_messages.js
@@ -21,7 +21,7 @@
 
 'use strict';
 
-require('../common');
+require('../../common');
 
 const spawn = require('child_process').spawn;
 
diff --git a/test/fixtures/errors/if-error-has-good-stack.js b/test/fixtures/errors/if-error-has-good-stack.js
@@ -1,6 +1,6 @@
 'use strict';
 
-require('../common');
+require('../../common');
 Error.stackTraceLimit = 4;
 
 const assert = require('assert');
diff --git a/test/fixtures/errors/if-error-has-good-stack.snapshot b/test/fixtures/errors/if-error-has-good-stack.snapshot
@@ -3,7 +3,7 @@ node:assert:*
     ^
 
 AssertionError [ERR_ASSERTION]: ifError got unwanted exception: test error
-    at z (*if-error-has-good-stack.js:*:*
+    at z (*if-error-has-good-stack.js:*:*)
     at y (*if-error-has-good-stack.js:*:*)
     at x (*if-error-has-good-stack.js:*:*)
     at Object.<anonymous> (*if-error-has-good-stack.js:*:*)
diff --git a/test/fixtures/errors/test-no-extra-info-on-fatal-exception.js b/test/fixtures/errors/test-no-extra-info-on-fatal-exception.js
@@ -1,7 +1,7 @@
 // Flags: --no-extra-info-on-fatal-exception
 
 'use strict';
-require('../common');
+require('../../common');
 Error.stackTraceLimit = 1;
 
 throw new Error('foo');
diff --git a/test/fixtures/errors/throw_error_with_getter_throw.js b/test/fixtures/errors/throw_error_with_getter_throw.js
@@ -1,5 +1,7 @@
 'use strict';
-require('../common');
+
+require('../../common');
+
 throw {  // eslint-disable-line no-throw-literal
   get stack() {
     throw new Error('weird throw but ok');
diff --git a/test/fixtures/errors/throw_null.js b/test/fixtures/errors/throw_null.js
@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+require('../../common');
 
 // eslint-disable-next-line no-throw-literal
 throw null;
diff --git a/test/fixtures/errors/throw_undefined.js b/test/fixtures/errors/throw_undefined.js
@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+require('../../common');
 
 // eslint-disable-next-line no-throw-literal
 throw undefined;
diff --git a/test/fixtures/errors/timeout_throw.js b/test/fixtures/errors/timeout_throw.js
@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+require('../../common');
 
 setTimeout(function() {
   // eslint-disable-next-line no-undef,no-unused-expressions
diff --git a/test/fixtures/errors/undefined_reference_in_new_context.js b/test/fixtures/errors/undefined_reference_in_new_context.js
@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+require('../../common');
 const vm = require('vm');
 
 console.error('before');
diff --git a/test/fixtures/errors/util-inspect-error-cause.js b/test/fixtures/errors/util-inspect-error-cause.js
@@ -1,6 +1,6 @@
 'use strict';
 
-require('../common');
+require('../../common');
 
 const { inspect } = require('util');
 
diff --git a/test/fixtures/errors/util_inspect_error.js b/test/fixtures/errors/util_inspect_error.js
@@ -1,6 +1,6 @@
 'use strict';
 
-require('../common');
+require('../../common');
 const util = require('util');
 
 const err = new Error('foo\nbar');
diff --git a/test/fixtures/errors/util_inspect_error.snapshot b/test/fixtures/errors/util_inspect_error.snapshot
@@ -1,38 +1,38 @@
 { err:
    Error: foo
    bar
-       at *util_inspect_error*
        at *
        at *
        at *
        at *
        at *
        at *
+       at node:internal*main*run_main_module:*:*,
   nested:
    { err:
       Error: foo
       bar
-          at *util_inspect_error*
           at *
           at *
           at *
           at *
           at *
           at *
+          at node:internal*main*run_main_module:*:* } }
 {
   err: Error: foo
   bar
-      at *util_inspect_error*
       at *
       at *
       at *
       at *
       at *
       at *
+      at node:internal*main*run_main_module:*:*,
   nested: {
     err: Error: foo
     bar
-        at *util_inspect_error*
+        at *
         at *
         at *
         at *
@@ -43,7 +43,7 @@
 }
 { Error: foo
 bar
-    at *util_inspect_error*
+    at *
     at *
     at *
     at *
diff --git a/test/fixtures/errors/v8_warning.js b/test/fixtures/errors/v8_warning.js
@@ -1,6 +1,6 @@
 'use strict';
 
-require('../common');
+require('../../common');
 
 function AsmModule() {
   'use asm';
diff --git a/test/fixtures/map/source_map_enclosing_function.js b/test/fixtures/map/source_map_enclosing_function.js
@@ -0,0 +1,7 @@
+// Flags:  --enable-source-maps
+
+'use strict';
+require('../../common');
+Error.stackTraceLimit = 5;
+
+require('../source-map/enclosing-call-site-min.js');
diff --git a/test/fixtures/map/source_map_enclosing_function.snapshot b/test/fixtures/map/source_map_enclosing_function.snapshot
@@ -2,6 +2,7 @@
   throw err
   ^
 
+
 Error: an error!
     at functionD (*enclosing-call-site.js:16:17)
     at functionC (*enclosing-call-site.js:10:3)
diff --git a/test/fixtures/map/source_map_reference_error_tabs.js b/test/fixtures/map/source_map_reference_error_tabs.js
@@ -1,7 +1,7 @@
 // Flags:  --enable-source-maps
 
 'use strict';
-require('../common');
+require('../../common');
 Error.stackTraceLimit = 2;
 
-require('../fixtures/source-map/tabs.js');
+require('../source-map/tabs.js');
diff --git a/test/fixtures/map/source_map_sourcemapping_url_string.js b/test/fixtures/map/source_map_sourcemapping_url_string.js
@@ -1,11 +1,11 @@
 // Flags:  --enable-source-maps
 
 'use strict';
-require('../common');
+require('../../common');
 Error.stackTraceLimit = 2;
 
 try {
-  require('../fixtures/source-map/typescript-sourcemapping_url_string');
+  require('../source-map/typescript-sourcemapping_url_string');
 } catch (err) {
   setTimeout(() => {
     console.info(err);
diff --git a/test/fixtures/map/source_map_throw_catch.js b/test/fixtures/map/source_map_throw_catch.js
@@ -1,11 +1,11 @@
 // Flags:  --enable-source-maps
 
 'use strict';
-require('../common');
+require('../../common');
 Error.stackTraceLimit = 2;
 
 try {
-  require('../fixtures/source-map/typescript-throw');
+  require('../source-map/typescript-throw');
 } catch (err) {
   setTimeout(() => {
     console.info(err);
diff --git a/test/fixtures/map/source_map_throw_icu.js b/test/fixtures/map/source_map_throw_icu.js
@@ -1,7 +1,7 @@
 // Flags: --enable-source-maps
 
 'use strict';
-require('../common');
+require('../../common');
 Error.stackTraceLimit = 2;
 
-require('../fixtures/source-map/icu');
+require('../source-map/icu');
diff --git a/test/fixtures/map/source_map_throw_set_immediate.js b/test/fixtures/map/source_map_throw_set_immediate.js
@@ -0,0 +1,5 @@
+// Flags:  --enable-source-maps
+
+'use strict';
+require('../../common');
+require('../source-map/uglify-throw');
diff --git a/test/fixtures/promise/promise_unhandled_warn_with_error.js b/test/fixtures/promise/promise_unhandled_warn_with_error.js
@@ -1,7 +1,7 @@
 // Flags: --unhandled-rejections=warn-with-error-code
 'use strict';
 
-require('../common');
+require('../../common');
 const assert = require('assert');
 
 Promise.reject(new Error('alas'));
diff --git a/test/fixtures/promise/unhandled_promise_trace_warnings.js b/test/fixtures/promise/unhandled_promise_trace_warnings.js
@@ -1,5 +1,5 @@
 // Flags: --trace-warnings --unhandled-rejections=warn
 'use strict';
-require('../common');
+require('../../common');
 const p = Promise.reject(new Error('This was rejected'));
 setImmediate(() => p.catch(() => {}));
diff --git a/test/fixtures/tick/max_tick_depth.js b/test/fixtures/tick/max_tick_depth.js
@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+require('../../common');
 
 process.maxTickDepth = 10;
 let i = 20;
diff --git a/test/fixtures/tick/max_tick_depth.snapshot b/test/fixtures/tick/max_tick_depth.snapshot
diff --git a/test/fixtures/tick/nexttick_throw.js b/test/fixtures/tick/nexttick_throw.js
@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+require('../../common');
 
 process.nextTick(function() {
   process.nextTick(function() {
diff --git a/test/parallel/test-node-output-console.mjs b/test/parallel/test-node-output-console.mjs
diff --git a/test/parallel/test-node-output-errors.mjs b/test/parallel/test-node-output-errors.mjs
diff --git a/test/parallel/test-output-assertion.mjs b/test/parallel/test-output-assertion.mjs
diff --git a/test/parallel/test-output-map.mjs b/test/parallel/test-output-map.mjs
diff --git a/test/parallel/test-output-promise.mjs b/test/parallel/test-output-promise.mjs
diff --git a/test/parallel/test-output-tick.mjs b/test/parallel/test-output-tick.mjs
