From f082d0b1a33327bc7a2f9668184ef73dd441c6bd Mon Sep 17 00:00:00 2001 From: James M Snell Date: Wed, 10 Apr 2024 10:03:50 -0700 Subject: [PATCH 1/9] Open Corepack Vote --- votes/initiateNewVote/_EDIT_ME.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/votes/initiateNewVote/_EDIT_ME.yml b/votes/initiateNewVote/_EDIT_ME.yml index c9fac556..44767fb6 100644 --- a/votes/initiateNewVote/_EDIT_ME.yml +++ b/votes/initiateNewVote/_EDIT_ME.yml @@ -3,7 +3,7 @@ # 1. Select a subject for the vote. This can be a question addressed to the TSC # voting members. -subject: REPLACEME +subject: Corepack # 2. You can leave the header instructions as is, or modify them if you see fit. headerInstructions: | @@ -24,8 +24,9 @@ headerInstructions: | # voters express their preference for each candidates, no matter how many # there are. candidates: - - TODO - - TODO + - Status Quo ... Keep distributing corepack with node.js, disabled by default, exactly as it is today + - Keep distributing corepack with node.js, enabled by default + - Stop distributing corepack with node.js # 4. Pass the following to false if it's important to keep the candidates in the # order you define above. Presenting candidates in a fixed order tends to @@ -35,7 +36,9 @@ canShuffleCandidates: true # 5. Insert here a short description of the vote objectives and link to the # issue it was discussed on to give the full context. footerInstructions: | - TBD + The objective of the vote is to determine a basic question: do we continue bundling + corepack with Node.js or not, and if so, do we enable it by default or not. There + are additional questions to resolve that will be handled separately. # 6. Optionally, insert a brief introduction for the vote PR, in the markdown format. prBody: | From b18efc2499e378d7272e50898c6e0c1b020ae9a2 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Wed, 10 Apr 2024 11:35:30 -0700 Subject: [PATCH 2/9] Update votes/initiateNewVote/_EDIT_ME.yml Co-authored-by: Ruy Adorno --- votes/initiateNewVote/_EDIT_ME.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/votes/initiateNewVote/_EDIT_ME.yml b/votes/initiateNewVote/_EDIT_ME.yml index 44767fb6..de0c901f 100644 --- a/votes/initiateNewVote/_EDIT_ME.yml +++ b/votes/initiateNewVote/_EDIT_ME.yml @@ -37,8 +37,9 @@ canShuffleCandidates: true # issue it was discussed on to give the full context. footerInstructions: | The objective of the vote is to determine a basic question: do we continue bundling - corepack with Node.js or not, and if so, do we enable it by default or not. There - are additional questions to resolve that will be handled separately. + the corepack binary with Node.js or not, and if so, do we enable bundling jumper + binaries for its supported package managers (such as yarn and pnpm) by default or not. + There are additional questions to resolve that will be handled separately. # 6. Optionally, insert a brief introduction for the vote PR, in the markdown format. prBody: | From e51a5bf81387f13f2177469687c5a23f1860e4af Mon Sep 17 00:00:00 2001 From: James M Snell Date: Wed, 10 Apr 2024 14:48:18 -0700 Subject: [PATCH 3/9] Update votes/initiateNewVote/_EDIT_ME.yml Co-authored-by: Antoine du Hamel --- votes/initiateNewVote/_EDIT_ME.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/votes/initiateNewVote/_EDIT_ME.yml b/votes/initiateNewVote/_EDIT_ME.yml index de0c901f..d8e6680b 100644 --- a/votes/initiateNewVote/_EDIT_ME.yml +++ b/votes/initiateNewVote/_EDIT_ME.yml @@ -24,9 +24,9 @@ headerInstructions: | # voters express their preference for each candidates, no matter how many # there are. candidates: - - Status Quo ... Keep distributing corepack with node.js, disabled by default, exactly as it is today - - Keep distributing corepack with node.js, enabled by default - - Stop distributing corepack with node.js + - Status Quo: keep distributing `corepack` with Node.js, disabled by default, exactly as it is today. + - Keep distributing `corepack` with Node.js, enabling `yarn` and `pnpm` by default. + - Stop distributing `corepack` with Node.js. # 4. Pass the following to false if it's important to keep the candidates in the # order you define above. Presenting candidates in a fixed order tends to From 9868533af21a434ea210f6fe872f9f8601f00270 Mon Sep 17 00:00:00 2001 From: Marco Ippolito Date: Mon, 3 Mar 2025 11:04:15 +0100 Subject: [PATCH 4/9] Update votes/initiateNewVote/_EDIT_ME.yml Co-authored-by: Antoine du Hamel --- votes/initiateNewVote/_EDIT_ME.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/votes/initiateNewVote/_EDIT_ME.yml b/votes/initiateNewVote/_EDIT_ME.yml index d8e6680b..a0b57662 100644 --- a/votes/initiateNewVote/_EDIT_ME.yml +++ b/votes/initiateNewVote/_EDIT_ME.yml @@ -24,9 +24,10 @@ headerInstructions: | # voters express their preference for each candidates, no matter how many # there are. candidates: - - Status Quo: keep distributing `corepack` with Node.js, disabled by default, exactly as it is today. - - Keep distributing `corepack` with Node.js, enabling `yarn` and `pnpm` by default. - - Stop distributing `corepack` with Node.js. + - "Status Quo: keep distributing Corepack with Node.js, experimental and disabled (i.e. only the `corepack` executable in the distribution), exactly as it is today." + - "Stable and Disabled: keep distributing Corepack disabled (i.e. only the `corepack` executable in the distribution), and mark it stable in a future release line." + - "Stable and Enabled: keep distributing Corepack with Node.js, enabled (i.e. `corepack`, `pnpm`, and `yarn` executables in the distribution), and mark it stable in a future release line." + - "Phase out: stop distributing Corepack (i.e. the distribution will no longer contain a `corepack` executable) on future release lines of Node.js – existing release lines will keep it as experimental." # 4. Pass the following to false if it's important to keep the candidates in the # order you define above. Presenting candidates in a fixed order tends to From e2d8e9ace0128c06ea56d7a5f0469c4b3dc25c4d Mon Sep 17 00:00:00 2001 From: Marco Ippolito Date: Mon, 3 Mar 2025 11:11:25 +0100 Subject: [PATCH 5/9] Update votes/initiateNewVote/_EDIT_ME.yml --- votes/initiateNewVote/_EDIT_ME.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/votes/initiateNewVote/_EDIT_ME.yml b/votes/initiateNewVote/_EDIT_ME.yml index a0b57662..47ce9052 100644 --- a/votes/initiateNewVote/_EDIT_ME.yml +++ b/votes/initiateNewVote/_EDIT_ME.yml @@ -37,10 +37,7 @@ canShuffleCandidates: true # 5. Insert here a short description of the vote objectives and link to the # issue it was discussed on to give the full context. footerInstructions: | - The objective of the vote is to determine a basic question: do we continue bundling - the corepack binary with Node.js or not, and if so, do we enable bundling jumper - binaries for its supported package managers (such as yarn and pnpm) by default or not. - There are additional questions to resolve that will be handled separately. + The objective of the vote is to determine the strategy for Corepack’s distribution in future Node.js releases. # 6. Optionally, insert a brief introduction for the vote PR, in the markdown format. prBody: | From 701d80c9b1de03fa3f03d50b9c104495c3a364a2 Mon Sep 17 00:00:00 2001 From: Marco Ippolito Date: Sun, 9 Mar 2025 14:10:36 +0100 Subject: [PATCH 6/9] Update votes/initiateNewVote/_EDIT_ME.yml Co-authored-by: Antoine du Hamel --- votes/initiateNewVote/_EDIT_ME.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/votes/initiateNewVote/_EDIT_ME.yml b/votes/initiateNewVote/_EDIT_ME.yml index 47ce9052..a83e2b42 100644 --- a/votes/initiateNewVote/_EDIT_ME.yml +++ b/votes/initiateNewVote/_EDIT_ME.yml @@ -37,7 +37,8 @@ canShuffleCandidates: true # 5. Insert here a short description of the vote objectives and link to the # issue it was discussed on to give the full context. footerInstructions: | - The objective of the vote is to determine the strategy for Corepack’s distribution in future Node.js releases. + The objective of the vote is to determine the strategy for Corepack’s distribution + in future Node.js releases. # 6. Optionally, insert a brief introduction for the vote PR, in the markdown format. prBody: | From ec1ea8848599e62ab90decbb49f3c254e13d0ade Mon Sep 17 00:00:00 2001 From: Marco Ippolito Date: Sun, 9 Mar 2025 14:40:14 +0100 Subject: [PATCH 7/9] Update votes/initiateNewVote/_EDIT_ME.yml Co-authored-by: Antoine du Hamel --- votes/initiateNewVote/_EDIT_ME.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/votes/initiateNewVote/_EDIT_ME.yml b/votes/initiateNewVote/_EDIT_ME.yml index a83e2b42..2828f1d8 100644 --- a/votes/initiateNewVote/_EDIT_ME.yml +++ b/votes/initiateNewVote/_EDIT_ME.yml @@ -3,7 +3,7 @@ # 1. Select a subject for the vote. This can be a question addressed to the TSC # voting members. -subject: Corepack +subject: Should Corepack stay in the Node.js distribution? # 2. You can leave the header instructions as is, or modify them if you see fit. headerInstructions: | From a0f2bef87270b20a5ce1200d973cbdf5b9367a6c Mon Sep 17 00:00:00 2001 From: Marco Ippolito Date: Sun, 9 Mar 2025 14:41:54 +0100 Subject: [PATCH 8/9] Update votes/initiateNewVote/_EDIT_ME.yml Co-authored-by: Antoine du Hamel --- votes/initiateNewVote/_EDIT_ME.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/votes/initiateNewVote/_EDIT_ME.yml b/votes/initiateNewVote/_EDIT_ME.yml index 2828f1d8..7d8bdf3a 100644 --- a/votes/initiateNewVote/_EDIT_ME.yml +++ b/votes/initiateNewVote/_EDIT_ME.yml @@ -28,7 +28,7 @@ candidates: - "Stable and Disabled: keep distributing Corepack disabled (i.e. only the `corepack` executable in the distribution), and mark it stable in a future release line." - "Stable and Enabled: keep distributing Corepack with Node.js, enabled (i.e. `corepack`, `pnpm`, and `yarn` executables in the distribution), and mark it stable in a future release line." - "Phase out: stop distributing Corepack (i.e. the distribution will no longer contain a `corepack` executable) on future release lines of Node.js – existing release lines will keep it as experimental." - + - "Phase out later: stop distributing Corepack (i.e. the distribution will no longer contain a `corepack` executable) on future (i.e. 25+) release lines of Node.js – existing release lines as well as the very next (i.e. 24.x) will keep it as experimental." # 4. Pass the following to false if it's important to keep the candidates in the # order you define above. Presenting candidates in a fixed order tends to # give an unfair advantage to the first option. From e411ecd818ecf16dfe858e6d04608f8499b2f6f3 Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Sun, 9 Mar 2025 14:11:47 +0000 Subject: [PATCH 9/9] add line return --- votes/initiateNewVote/_EDIT_ME.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/votes/initiateNewVote/_EDIT_ME.yml b/votes/initiateNewVote/_EDIT_ME.yml index 7d8bdf3a..0b3cc2f0 100644 --- a/votes/initiateNewVote/_EDIT_ME.yml +++ b/votes/initiateNewVote/_EDIT_ME.yml @@ -29,6 +29,7 @@ candidates: - "Stable and Enabled: keep distributing Corepack with Node.js, enabled (i.e. `corepack`, `pnpm`, and `yarn` executables in the distribution), and mark it stable in a future release line." - "Phase out: stop distributing Corepack (i.e. the distribution will no longer contain a `corepack` executable) on future release lines of Node.js – existing release lines will keep it as experimental." - "Phase out later: stop distributing Corepack (i.e. the distribution will no longer contain a `corepack` executable) on future (i.e. 25+) release lines of Node.js – existing release lines as well as the very next (i.e. 24.x) will keep it as experimental." + # 4. Pass the following to false if it's important to keep the candidates in the # order you define above. Presenting candidates in a fixed order tends to # give an unfair advantage to the first option.