Driver logic fixups and additions #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PM_DEVICE_ACTION_TURN_OFF is only ised by power domains. To correctly power down the chip it needs to handle the PM_DEVICE_ACTION_SUSPEND action instead of PM_DEVICE_ACTION_TURN_OFF.
The sensor outputs the adc value as twos complement. Even though it is given in the datasheets example code, performing a xor with 0x800000 is not the correct way to convert the value. See https://en.wikipedia.org/wiki/Two%27s_complement for details.
Owner
|
Hello @lgehreke, thank you for the PR, |
Author
|
I did some research on it. What the xor does is mapping the negative values coming from the chip from [−8388608, 8388607] to [0, 16777215]. For this use case it is perfectly usable. Maybe the "correct" conversion can be added as Kconfig option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixups and additions:
Power management
PM_DEVICE_ACTION_TURN_OFFis only used by power domains. To correctly power down the sensor it needs to react toPM_DEVICE_ACTION_SUSPEND.Twos complement conversion
The sensor outputs the adc value as twos complement. Even though
it is given in the datasheets example code, performing a xor
with 0x800000 is not the correct way to convert the value.
See https://en.wikipedia.org/wiki/Two%27s_complement for details.
Addition