feat(trace): mark parent span in error

nioc · nioc · commit be60cb5ea030 · 2025-01-23T00:31:15.000+01:00
diff --git a/lib/opentelemetry-node.js b/lib/opentelemetry-node.js
@@ -387,6 +387,9 @@ function endSpan (msg, error, nodeDefinition) {
         span.recordException(error)
       }
       span.setStatus({ code: SpanStatusCode.ERROR, message: error })
+      if (parent.parentSpan) {
+        parent.parentSpan.setStatus({ code: SpanStatusCode.ERROR })
+      }
     }
     const localAttributes = parseAttribute(true, msg, nodeDefinition.z, nodeDefinition.type)
     if (localAttributes !== undefined) {
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-opentelemetry",
-  "version": "1.6.1",
+  "version": "1.6.2",
   "description": "Distributed tracing with OpenTelemetry SDK and Prometheus metrics exporter for Node-RED",
   "scripts": {
     "lint": "eslint . --fix"

Original file line number	Diff line number	Diff line change
`@@ -387,6 +387,9 @@ function endSpan (msg, error, nodeDefinition) {`
`387`	`387`	`span.recordException(error)`
`388`	`388`	`}`
`389`	`389`	`span.setStatus({ code: SpanStatusCode.ERROR, message: error })`
	`390`	`+ if (parent.parentSpan) {`
	`391`	`+ parent.parentSpan.setStatus({ code: SpanStatusCode.ERROR })`
	`392`	`+ }`
`390`	`393`	`}`
`391`	`394`	`const localAttributes = parseAttribute(true, msg, nodeDefinition.z, nodeDefinition.type)`
`392`	`395`	`if (localAttributes !== undefined) {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "node-red-contrib-opentelemetry",`
`3`		`- "version": "1.6.1",`
	`3`	`+ "version": "1.6.2",`
`4`	`4`	`"description": "Distributed tracing with OpenTelemetry SDK and Prometheus metrics exporter for Node-RED",`
`5`	`5`	`"scripts": {`
`6`	`6`	`"lint": "eslint . --fix"`