Fatal on windows when Nimble clones to dir ending with dot

[dom96]

 Installing stb_image@>= 2.
Downloading https://gitlab.com/define-private-public/stb_image-Nim.git using git
       Tip: 66 messages have been suppressed, use --verbose to show them.
     Error: Execution failed with exit code 128
        ... Command: git clone --recursive --depth 1 -b 2.5 https://gitlab.com/define-private-public/stb_image-Nim.git C:\
Users\morfe\AppData\Local\Temp\nimble_19748\gitlabcom_defineprivatepublicstbimageNimgit_2.
        ... Output: fatal: could not create work tree dir 'C:\Users\morfe\AppData\Local\Temp\nimble_19748\gitlabcom_define
privatepublicstbimageNimgit_2.': Invalid argument

This is because of https://github.com/dom96/typography/blob/a87b64f328fa0b1e50110e26ec2c14d655ec1f3f/typography.nimble#L16

[genotrance]

Is this just a bad nimble file (versions shouldn't end with .)? If user requested 2. then it should be recorded that way right?

[dom96]

The problem is the directory it's trying to clone to: gitlabcom_defineprivatepublicstbimageNimgit_2.

[genotrance]

Okay, but wouldn't the . also be a problem for .nimble\pkgs\stb_image-2.?

[dom96]

Dunno. I'm not saying this should be allowed. Just saying that is the direct cause of the error.

[dom96]

to be fair, once the package gets cloned it'll have a proper version in its nimble file so it wouldn't fail there. But we should probably disallow version = "2." in nimble files if we don't already

[mantielero]

I am facing the same problem in windows when I do:

C:> nimble install https://github.com/mantielero/VapourSynth.nim
Downloading https://github.com/mantielero/VapourSynth.nim using git
     Error: Execution failed with exit code 128
        ... Command: git clone --recursive --shallow-submodules --depth 1 https://github.com/mantielero/VapourSynth.nim C:\Users\jose\AppData\Local\Temp\nimble_14316\githubcom_mantieleroVapourSynthnim
        ... Output: Cloning into 'C:\Users\jose\AppData\Local\Temp\nimble_14316\githubcom_mantieleroVapourSynthnim'...
        ... fatal: this operation must be run in a work tree
        ... warning: Clone succeeded, but checkout failed.
        ... You can inspect what was checked out with 'git status'
        ... and retry with 'git restore --source=HEAD :/'

I used nim 1.4.3 (nightly) for that.

[mantielero]

I fixed the issue. I explain here what I did (this might help others).

In my case, the problem was that I had an issue with the permissions to the temporal directory. I did not had access to:

C:\Users\jose\AppData\Local\Temp

from the command line.

So the following failed in the command line:

cd %TEMP%

To fix I had to reset the permissions of that folder:

1. Start a console as admin
2. Run something like:

icacls C:\Users\<your_username_here>\AppData\Local\Temp /reset /t /c /l

Now it works.