fix: avoid mktemp #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove patterns of creating a tmpfile (typically in `/tmp`) to only move
it when the operation complete. Instead, the operation is done directly
on the target file, with a possible fallback to delete the file if a
command fails.
The rationale is that `mktemp` creates files in `${TMPDIR:-/tmp}`. On
most systems, `/tmp` is a `tmpfs` filesystem with relatively limited
space available (especially on lower powered CI machines). This can be
an issue if dealing with large artefacts (for example, Rust build artefacts).
Signed-off-by: JP-Ellis <[email protected]>
Collaborator
|
Thanks for the PR 🚀. As seen CI fails on tests. Should check on test results. |
Contributor
Author
|
Yeah all good, seems to be mostly due to the few changes in logging. Should be straightforward to fix |
This removes the stubs for `mktemp` and `mv` as the files are managed in-place. Additionally, the `s3` commands no longer reference `/tmp/tempfile` and instead reference the file directly. Signed-off-by: JP-Ellis <[email protected]>
Contributor
Author
|
Sorry it took a little while, but I've update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove patterns of creating a tmpfile (typically in
/tmp) to only move it when the operation complete. Instead, the operation is done directly on the target file, with a possible fallback to delete the file if a command fails.The rationale is that
mktempcreates files in${TMPDIR:-/tmp}. On most systems,/tmpis atmpfsfilesystem with relatively limited space available (especially on lower powered CI machines). This can be an issue if dealing with large artefacts (for example, Rust build artefacts).Fixes #84