Skip to content

Update docker connect to N1C command #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2025
Merged

Update docker connect to N1C command #905

merged 3 commits into from
Jul 30, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jul 29, 2025

Proposed changes

Based on discrepancy. Bug.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@mjang mjang self-assigned this Jul 29, 2025
@mjang mjang requested a review from a team as a code owner July 29, 2025 20:36
@mjang mjang added the bug Something isn't working label Jul 29, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginx-one NGINX One Console labels Jul 29, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/905/

ADubhlaoich
ADubhlaoich approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjang
Copy link
Contributor Author

mjang commented Jul 30, 2025

I'm taking a thumbsup in an internal chat as a 2nd approval, and merging on that basis.

@mjang mjang merged commit 1485346 into main Jul 30, 2025
10 checks passed
@mjang mjang deleted the mjang-patch-4 branch July 30, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@mattdesmarais mattdesmarais Awaiting requested review from mattdesmarais

@jasonclopper jasonclopper Awaiting requested review from jasonclopper

Assignees

@mjang mjang

Labels
bug Something isn't working documentation Improvements or additions to documentation product/nginx-one NGINX One Console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjang @ADubhlaoich