-
Notifications
You must be signed in to change notification settings - Fork 942
RiboCode - prepare_transcripts, metaplots, ribocode #9485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
pinin4fjords
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Just need some bits and pieces to fix it up
| 'biocontainers/ribocode:1.2.15--pyhfa5458b_0' }" | ||
|
|
||
| input: | ||
| path fasta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inputs and outputs will need to be tuples with meta elements
| path gtf | ||
|
|
||
| output: | ||
| path "annotation" , emit: annotation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metas
|
|
||
| output: | ||
| path "annotation" , emit: annotation | ||
| path "versions.yml" , emit: versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versions will be collected via topic channels from now on (there's a bulk conversion in process). You might as well have that in place now- check out https://github.com/nf-core/modules/blob/master/modules/nf-core/ribodetector/main.nf for how it's done.
|
|
||
| """ | ||
| # nf-core: ensure FASTA is uncompressed | ||
| GENOME="$fasta" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't bake this sort of concern into modules I think, keep things simple, pipelines can input gunzip processes.
| fi | ||
|
|
||
| # Update the GTF | ||
| GTFupdate \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be a separate module
| identifier: "" | ||
|
|
||
| input: | ||
| - fasta: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be updated to allow for the meta structure I indicated above
| "id": "test", | ||
| "single_end": false | ||
| }, | ||
| "test_ORFs_category.pdf:md5,a56356649534ea846fe7aa3aac6684ff" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably shouldn't try to snapshot pdfs, they tend not to be stable over multiple machines because of differences in underlying libraries.
| "id": "test", | ||
| "single_end": false | ||
| }, | ||
| "SRX11780887.Aligned.toTranscriptome.out_psites.hd5:md5,802ec4fe5545dec4fe8affd79716faeb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hd5 is a binary format also likely to work poorly with snapshots
| ext.args = '-f0_percent 0.1 -pv1 1 -pv2 1' | ||
| } | ||
| withName: RIBOCODE_RIBOCODE { | ||
| ext.args = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this if you're not setting anything
|
|
||
| input: | ||
| tuple val(meta), path(bam) | ||
| path annotation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need a tuple with a meta
I had added the three module required for running the RiboCode application for detecting translated regions from Ribo-Seq data. This involves preparing the annotations (
ribocode/prepare), assessing the alignment files (ribocode/metaplots) and finally running the calling (ribocode/ribocode)PR checklist
Closes Very Old Issue
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda