Skip to content

Commit 45be98e

Browse files
authored
Merge pull request #89 from netgen/admin-issues-fixes
Various improvements in admin
2 parents 96ef088 + 94dddc2 commit 45be98e

File tree

11 files changed

+25
-15
lines changed

11 files changed

+25
-15
lines changed

bundle/RemoteMedia/Helper.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,10 @@ public function formatBrowseItem(Value $value)
4747

4848
if ($mediaType === Value::TYPE_IMAGE) {
4949
$browseUrl = $this->provider->buildVariation($value, 'admin', $thumbOptions)->url;
50-
$previewUrl = $value->secure_url;
50+
$previewUrl = $this->provider->buildVariation($value, 'default', 'admin_preview')->url;
5151
} elseif ($mediaType === Value::TYPE_VIDEO) {
5252
$browseUrl = $this->provider->getVideoThumbnail($value, $thumbOptions);
53-
$previewUrl = $this->provider->getVideoThumbnail($value);
53+
$previewUrl = $this->provider->getVideoThumbnail($value, ['content_type_identifier' => 'default', 'variation_name' => 'admin_preview']);
5454
} else {
5555
$browseUrl = '';
5656
$previewUrl = '';

bundle/RemoteMedia/Provider/Cloudinary/CloudinaryProvider.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,12 @@ public function updateResourceContext(string $resourceId, string $resourceType,
284284
*/
285285
public function getVideoThumbnail(Value $value, $options = []): string
286286
{
287+
if (array_key_exists('content_type_identifier', $options) && array_key_exists('variation_name', $options)) {
288+
$options['transformation'] = $this->processConfiguredVariation($value, $options['variation_name'], $options['content_type_identifier']);
289+
unset($options['content_type_identifier']);
290+
unset($options['variation_name']);
291+
}
292+
287293
if (count($options) === 0 || !array_key_exists('resource_type', $options)) {
288294
$options['resource_type'] = 'video';
289295
}

bundle/Resources/config/default_settings.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ system:
44
default:
55
admin_preview:
66
transformations:
7-
- { name: limit, params: [600,600] }
7+
- { name: limit, params: [400,400] }
88
ng_article:
99
test:
1010
transformations:

bundle/Resources/public/css/remotemedia.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bundle/Resources/public/js/remotemedia.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bundle/Resources/views/ezadminui/parts/edit/ngrm_field.html.twig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
type: "{% if field_value %}{{ field_value.resourceType|default('image') }}{% else %}image{% endif %}",
77
{% if not field_value or field_value.mediaType == 'image' %}
88
mediaType: "image",
9-
previewUrl: "{% if field_value %}{{ field_value.secure_url }}{% endif %}",
9+
previewUrl: "{% if field_value %}{{ netgen_remote_media(field_value, 'admin_preview').url }}{% endif %}",
1010
{% elseif field_value.mediaType == 'video' %}
1111
mediaType: "video",
12-
previewUrl: "{{ netgen_remote_video_thumbnail(field_value) }}",
12+
previewUrl: "{{ netgen_remote_video_thumbnail(field_value, {'content_type_identifier': 'default', 'variation_name': 'admin_preview'}) }}",
1313
{% else %}
1414
mediaType: "other",
1515
previewUrl: "",

bundle/ezpublish_legacy/ngremotemedia/design/standard/javascript/remotemedia.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bundle/ezpublish_legacy/ngremotemedia/design/standard/stylesheets/remotemedia.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bundle/ezpublish_legacy/ngremotemedia/design/standard/templates/content/datatype/view/ngremotemedia.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
}
66

77
{if $value.resourceId}
8+
{def $format = 'admin_preview'}
89
{if $value.mediaType|eq('image')}
9-
{def $format = 'admin_preview'}
1010
{def $variation = ngremotemedia($value, $attribute.object.class_identifier, $format)}
1111

1212
{if not(is_set($alt_text))}
@@ -29,7 +29,7 @@
2929

3030
<br/>
3131

32-
{def $thumbnail = videoThumbnail($value)}
32+
{def $thumbnail = videoThumbnail($value, hash('content_type_identifier', $attribute.object.class_identifier, 'variation_name', $format))}
3333
<img src="{$thumbnail}"/>
3434
{else}
3535
<i class="fa fa-book" aria-hidden="true"></i>

bundle/ezpublish_legacy/ngremotemedia/template_operator/ngremotemediaoperator.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,10 @@ function namedParameterList()
104104
'value' => array(
105105
'type' => 'Value',
106106
'required' => true
107+
),
108+
'options' => array(
109+
'type' => 'array',
110+
'required' => false
107111
)
108112
),
109113
'ngremotevideo' => array(
@@ -146,7 +150,7 @@ function modify(
146150
} elseif ($operatorName === 'ng_remote_croppable') {
147151
$operatorValue = $this->isCroppable($namedParameters['class_identifier']);
148152
} elseif ($operatorName === 'videoThumbnail') {
149-
$operatorValue = $this->videoThumbnail($namedParameters['value']);
153+
$operatorValue = $this->videoThumbnail($namedParameters['value'], $namedParameters['options']);
150154
} elseif ($operatorName === 'ngremotevideo') {
151155
$operatorValue = $this->getvideoTag(
152156
$namedParameters['value'],
@@ -228,12 +232,12 @@ function isCroppable($class_identifier)
228232
return !empty($variationResolver->getCroppbableVariations($class_identifier));
229233
}
230234

231-
function videoThumbnail($value)
235+
function videoThumbnail($value, $options = [])
232236
{
233237
$container = ezpKernel::instance()->getServiceContainer();
234238
$provider = $container->get( 'netgen_remote_media.provider' );
235239

236-
return $provider->getVideoThumbnail($value);
240+
return $provider->getVideoThumbnail($value, $options);
237241
}
238242

239243
function getVideoTag($value, $availableFormats, $format)

0 commit comments

Comments
 (0)