You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Resolves#531.
I am unsure about:
- the name of the `throwException` vs `throwThrottlerException` vs
`throwThrottlingException` method. In the end I decided to use
`throwThrottlingException` because it's more precise than
`throwException` and `throwThrottlerException` sounds like one is
always throwing `ThrottlerException`, which is not the case when
overriding the method (but not a strong opinion).
- the line with "eslint-disable-next-line...". I added `context` as
a parameter because of your comment @jmcdo29, but since I see no
point in using `context` for the default case, I had to disable
eslint for the line. I don't know if this is against any practices
of this project.
0 commit comments