ci: the review's corrections — the stub artifact, cmd comments, the guards

Three fixes from the branch review, one of them release-blocking:

- the export stub was uploaded under the name of the file it was kept in
  (tic80-export), and upload-artifact names the file in the artifact by its
  basename — package.sh looks for a file called tic80 in there, so all five
  of its checks would have missed and the release packaging would have failed
  after the whole matrix. The binary now goes into a directory of its own as
  stub/tic80[.exe], which is what the artifact carries
- the Windows Build step runs under cmd, where a line starting with # is a
  command, not a comment: the three comment lines an earlier commit put there
  were executed, and with the copy after them their failure was swallowed.
  They are rem lines now, and both the build and the copy end in
  `|| exit /b 1`
- the distinctness guards pass quietly when a file is missing (cmp returns 2
  and the `if` is simply false, while the "all distinct" line still prints):
  the native loops assert they collected twelve binaries, the web loop checks
  its twelve wasm files exist before comparing them

Author: nesbox

.github/workflows/build.yml

@@ -38,10 +38,14 @@ jobs:
         run: |
           cd build
           cmake -G "Visual Studio 17 2022" -DBUILD_SDLGPU=On -DBUILD_STATIC=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_WITH_ALL=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 ..
-          cmake --build . --config Release --parallel
-          # the universal export stub is this same binary (console.c appends the
-          # cart to it), so keep it before Build Pro overwrites it below
-          copy /Y bin\tic80.exe "%GITHUB_WORKSPACE%\tic80-export.exe"
+          cmake --build . --config Release --parallel || exit /b 1
+          rem The universal export stub is this same binary (console.c appends
+          rem the cart to it), so keep it before Build Pro overwrites it below.
+          rem It goes into a directory of its own: upload-artifact names the file
+          rem in the artifact by its basename, and package.sh looks for tic80.exe
+          rem in there — a file called tic80-export.exe would fail packaging.
+          if not exist "%GITHUB_WORKSPACE%\stub" mkdir "%GITHUB_WORKSPACE%\stub"
+          copy /Y bin\tic80.exe "%GITHUB_WORKSPACE%\stub\tic80.exe" || exit /b 1
 
       - name: Deploy
         uses: actions/upload-artifact@v6
@@ -69,7 +73,7 @@ jobs:
         with:
           name: "tic80-windows-export"
           path: |
-            tic80-export.exe
+            stub/tic80.exe
 
       # The per-language stubs a PRO alone export asks for
       # (/export/<ver>/<system><lang>, console.c exportGame): one binary per
@@ -110,6 +114,10 @@ jobs:
           # have bash 3.2, where `declare -A` is an invalid option and fails
           # the step (which is how the first version of this guard behaved)
           files=("$GITHUB_WORKSPACE"/stubs/*)
+          if [ ${#files[@]} -ne 12 ]; then
+            echo "expected 12 stubs, found ${#files[@]}" >&2
+            exit 1
+          fi
           for ((i = 0; i < ${#files[@]}; i++)); do
             for ((j = i + 1; j < ${#files[@]}; j++)); do
               if cmp -s "${files[i]}" "${files[j]}"; then
@@ -171,9 +179,13 @@ jobs:
           cd build
           cmake -G Ninja -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_BUILD_TYPE=Release -DBUILD_SDLGPU=On -DBUILD_STATIC=ON -DBUILD_WITH_ALL=ON ..
           cmake --build . --parallel
-          # the universal export stub is this same binary (console.c appends the
-          # cart to it), so keep it before Build Pro overwrites it below
-          cp bin/tic80 "$GITHUB_WORKSPACE/tic80-export"
+          # The universal export stub is this same binary (console.c appends the
+          # cart to it), so keep it before Build Pro overwrites it below. It goes
+          # into a directory of its own: upload-artifact names the file in the
+          # artifact by its basename, and package.sh looks for a file called
+          # tic80 in there — one called tic80-export would fail packaging.
+          mkdir -p "$GITHUB_WORKSPACE/stub"
+          cp bin/tic80 "$GITHUB_WORKSPACE/stub/tic80"
 
       - name: Export help (learn.md)
         run: |
@@ -208,7 +220,7 @@ jobs:
         with:
           name: "tic80-linux-gcc12-export"
           path: |
-            tic80-export
+            stub/tic80
 
       # The per-language stubs a PRO alone export asks for
       # (/export/<ver>/<system><lang>, console.c exportGame): one binary per
@@ -249,6 +261,10 @@ jobs:
           # have bash 3.2, where `declare -A` is an invalid option and fails
           # the step (which is how the first version of this guard behaved)
           files=("$GITHUB_WORKSPACE"/stubs/*)
+          if [ ${#files[@]} -ne 12 ]; then
+            echo "expected 12 stubs, found ${#files[@]}" >&2
+            exit 1
+          fi
           for ((i = 0; i < ${#files[@]}; i++)); do
             for ((j = i + 1; j < ${#files[@]}; j++)); do
               if cmp -s "${files[i]}" "${files[j]}"; then
@@ -310,9 +326,13 @@ jobs:
           cd build
           cmake -G Ninja -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_BUILD_TYPE=Release -DBUILD_SDLGPU=On -DBUILD_STATIC=ON -DBUILD_WITH_ALL=ON ..
           cmake --build . --parallel
-          # the universal export stub is this same binary (console.c appends the
-          # cart to it), so keep it before Build Pro overwrites it below
-          cp bin/tic80 "$GITHUB_WORKSPACE/tic80-export"
+          # The universal export stub is this same binary (console.c appends the
+          # cart to it), so keep it before Build Pro overwrites it below. It goes
+          # into a directory of its own: upload-artifact names the file in the
+          # artifact by its basename, and package.sh looks for a file called
+          # tic80 in there — one called tic80-export would fail packaging.
+          mkdir -p "$GITHUB_WORKSPACE/stub"
+          cp bin/tic80 "$GITHUB_WORKSPACE/stub/tic80"
 
       - name: Deploy
         uses: actions/upload-artifact@v6
@@ -335,7 +355,7 @@ jobs:
         with:
           name: "tic80-linux-arm64-gcc12-export"
           path: |
-            tic80-export
+            stub/tic80
 
       # The per-language stubs a PRO alone export asks for
       # (/export/<ver>/<system><lang>, console.c exportGame): one binary per
@@ -376,6 +396,10 @@ jobs:
           # have bash 3.2, where `declare -A` is an invalid option and fails
           # the step (which is how the first version of this guard behaved)
           files=("$GITHUB_WORKSPACE"/stubs/*)
+          if [ ${#files[@]} -ne 12 ]; then
+            echo "expected 12 stubs, found ${#files[@]}" >&2
+            exit 1
+          fi
           for ((i = 0; i < ${#files[@]}; i++)); do
             for ((j = i + 1; j < ${#files[@]}; j++)); do
               if cmp -s "${files[i]}" "${files[j]}"; then
@@ -493,9 +517,13 @@ jobs:
           cd build
           cmake -G Ninja -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_BUILD_TYPE=Release -DBUILD_STATIC=ON -DBUILD_SDLGPU=On -DBUILD_WITH_ALL=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 ..
           cmake --build . --parallel
-          # the universal export stub is this same binary (console.c appends the
-          # cart to it), so keep it before Build Pro overwrites it below
-          cp bin/tic80 "$GITHUB_WORKSPACE/tic80-export"
+          # The universal export stub is this same binary (console.c appends the
+          # cart to it), so keep it before Build Pro overwrites it below. It goes
+          # into a directory of its own: upload-artifact names the file in the
+          # artifact by its basename, and package.sh looks for a file called
+          # tic80 in there — one called tic80-export would fail packaging.
+          mkdir -p "$GITHUB_WORKSPACE/stub"
+          cp bin/tic80 "$GITHUB_WORKSPACE/stub/tic80"
 
       - name: Deploy
         uses: actions/upload-artifact@v6
@@ -518,7 +546,7 @@ jobs:
         with:
           name: "tic80-macos-arm64-export"
           path: |
-            tic80-export
+            stub/tic80
 
       # The per-language stubs a PRO alone export asks for
       # (/export/<ver>/<system><lang>, console.c exportGame): one binary per
@@ -559,6 +587,10 @@ jobs:
           # have bash 3.2, where `declare -A` is an invalid option and fails
           # the step (which is how the first version of this guard behaved)
           files=("$GITHUB_WORKSPACE"/stubs/*)
+          if [ ${#files[@]} -ne 12 ]; then
+            echo "expected 12 stubs, found ${#files[@]}" >&2
+            exit 1
+          fi
           for ((i = 0; i < ${#files[@]}; i++)); do
             for ((j = i + 1; j < ${#files[@]}; j++)); do
               if cmp -s "${files[i]}" "${files[j]}"; then
@@ -618,9 +650,13 @@ jobs:
           cd build
           cmake -G Ninja -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DCMAKE_BUILD_TYPE=Release -DBUILD_STATIC=ON -DBUILD_SDLGPU=On -DBUILD_WITH_ALL=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 ..
           cmake --build . --parallel
-          # the universal export stub is this same binary (console.c appends the
-          # cart to it), so keep it before Build Pro overwrites it below
-          cp bin/tic80 "$GITHUB_WORKSPACE/tic80-export"
+          # The universal export stub is this same binary (console.c appends the
+          # cart to it), so keep it before Build Pro overwrites it below. It goes
+          # into a directory of its own: upload-artifact names the file in the
+          # artifact by its basename, and package.sh looks for a file called
+          # tic80 in there — one called tic80-export would fail packaging.
+          mkdir -p "$GITHUB_WORKSPACE/stub"
+          cp bin/tic80 "$GITHUB_WORKSPACE/stub/tic80"
 
       - name: Deploy
         uses: actions/upload-artifact@v6
@@ -643,7 +679,7 @@ jobs:
         with:
           name: "tic80-macos-export"
           path: |
-            tic80-export
+            stub/tic80
 
       # The per-language stubs a PRO alone export asks for
       # (/export/<ver>/<system><lang>, console.c exportGame): one binary per
@@ -684,6 +720,10 @@ jobs:
           # have bash 3.2, where `declare -A` is an invalid option and fails
           # the step (which is how the first version of this guard behaved)
           files=("$GITHUB_WORKSPACE"/stubs/*)
+          if [ ${#files[@]} -ne 12 ]; then
+            echo "expected 12 stubs, found ${#files[@]}" >&2
+            exit 1
+          fi
           for ((i = 0; i < ${#files[@]}; i++)); do
             for ((j = i + 1; j < ${#files[@]}; j++)); do
               if cmp -s "${files[i]}" "${files[j]}"; then
@@ -792,6 +832,9 @@ jobs:
           # the native jobs run on their binaries: a wasm stub carries one
           # runtime, so twelve of them cannot be alike.
           files=("$GITHUB_WORKSPACE"/build/bin/tic80{lua,ruby,js,moon,yue,fennel,scheme,squirrel,wren,wasm,janet,python}.wasm)
+          for f in "${files[@]}"; do
+            if [ ! -f "$f" ]; then echo "missing stub: $f" >&2; exit 1; fi
+          done
           for ((i = 0; i < ${#files[@]}; i++)); do
             for ((j = i + 1; j < ${#files[@]}; j++)); do
               if cmp -s "${files[i]}" "${files[j]}"; then