Compilation Error in Cardinal Make Step: HYPRE Incompatible Pointer Type

[WayneX-Wong]

Hello everyone!

I'm encountering a compilation error while building Cardinal (without MOOSE's conda environment) after successfully building PETSc and libMesh. The build fails during make with the following incompatible pointer type errors like:

/home/lagrange/cardinal/contrib/nekRS/3rd_party/hypre/src/distributed_ls/Euclid/getRow_dh.c:26:50: error: passing argument 4 of ‘HYPRE_ParCSRMatrixGetRow’ from incompatible pointer type [-Wincompatible-pointer-types]
   26 |   ierr = HYPRE_ParCSRMatrixGetRow(mat, row, len, ind, val);
      |                                                  ^~~
      |                                                  |
      |                                                  HYPRE_Int ** {aka int **}

build_log.txt

Could this be a logic issue within the HYPRE code itself, or a problem of compiler version incompatibility?

Details:​​

• ​​Environment:​​

System: [Ubuntu 25.04]
Compiler: [gcc 14.2.0]

• ​​Investigation Done:​​

Searched hypre’s GitHub issues for similar errors (none found).
Checked Cardinal’s discussion forum for related reports (no matches).

[bpatto10]

Wayne,

I get the same errors on my desktop using Ubuntu 25.04 and gcc-14. If I compile on my notebook using Linux Mint (gcc-13), it will successfully compile and generate a cardinal-opt executable. I suspect that gcc-14 has clamped down on deviations from the ansi standard, and the hypre code needs to be updated.

Regards,
Bruce

[bpatto10]

Wayne

Go to $HOME/cardinal/contrib/nekRS/3rd_party/hypre/src, and edit the CMakeCache.txt file, line 186 to this:

set(HYPRE_WITH_EXTRA_CFLAGS "-Wno-error=incompatible-pointer-types" CACHE STRING "Define extra CC compile flags")

Go to the directory cmbuild (still in src) and type cmake ..
and then make

These last two steps may not be necessary, but I did then anyway.
Then go back to the cardinal main directory and type make -j8

I was able to successfully build cardinal-opt using gcc-14. Note that we are only disabling the incompatible pointers error for the hypre build and no where else in cardinal.

I got this idea from https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
in the section:

-Wno-incompatible-pointer-types (C and Objective-C only)

Do not warn when there is a conversion between pointers that have incompatible types. This warning is for cases not covered by -Wno-pointer-sign, which warns for pointer argument passing or assignment with different signedness.

By default, in C99 and later dialects of C, GCC treats this issue as an error. The error can be downgraded to a warning using -fpermissive (along with certain other errors), or for this error alone, with -Wno-error=incompatible-pointer-types.

This warning is upgraded to an error by -pedantic-errors.

I hope it works for your system as well.

-Bruce