stoi: no conversion on Emscripten builds.

[MonkeTGG]

Compiled the Emscripten build, but crashes with std::invalid_argument stoi: no conversion.
I did change the CMakeLists.txt for it to build with a .html file aswell, if that could cause anything.
Doesn't happen on Linux, and Android builds.

Sorry if this is a really stupid error.

[BrentDaMage]

Can you provide a callstack for the error?

[MonkeTGG]

stack: "___throw_exception_with_stack_trace@http://localhost:8000/nbcraft.js:8992:11\n@http://localhost:8000/nbcraft.wasm:wasm-function[17972]:0x30e58d\n@http://localhost:8000/nbcraft.wasm:wasm-function[17957]:0x30e0d1\n@http://localhost:8000/nbcraft.wasm:wasm-function[17956]:0x30e065\n@http://localhost:8000/nbcraft.wasm:wasm-function[17954]:0x30dfc3\n@http://localhost:8000/nbcraft.wasm:wasm-function[17953]:0x30dee2\n@http://localhost:8000/nbcraft.wasm:wasm-function[555]:0xc1a1\ncreateExportWrapper/<@http://localhost:8000/nbcraft.js:3594:12\ncallMain@http://localhost:8000/nbcraft.js:22524:28\ndoRun@http://localhost:8000/nbcraft.js:22572:32\nrun/<@http://localhost:8000/nbcraft.js:22579:7\n"

got a different result in chrome

Error: std::invalid_argument,stoi: no conversion
at ___throw_exception_with_stack_trace (http://localhost:8000/nbcraft.js:8992:11)
at http://localhost:8000/nbcraft.wasm:wasm-function[17972]:0x30e58d
at http://localhost:8000/nbcraft.wasm:wasm-function[17957]:0x30e0d1
at http://localhost:8000/nbcraft.wasm:wasm-function[17956]:0x30e065
at http://localhost:8000/nbcraft.wasm:wasm-function[17954]:0x30dfc3
at http://localhost:8000/nbcraft.wasm:wasm-function[17953]:0x30dee2
at http://localhost:8000/nbcraft.wasm:wasm-function[555]:0xc1a1
at http://localhost:8000/nbcraft.js:3594:12
at callMain (http://localhost:8000/nbcraft.js:22524:15)
at doRun (http://localhost:8000/nbcraft.js:22572:24)
​​

[MonkeTGG]

probably not what you want, so how do i get the callstack? do i have to add it to the cpp code?

[BrentDaMage]

That's technically a call stack, but it lacks the function names, since I guess it wasn't build with them enabled. If possible, could you do an Emscripten build with debug enabled, and try again? Hopefully then it should have some function names.

[MonkeTGG]

if you could tell me, how do i compile with debug mode?

[MonkeTGG]

nvm i figured it out

Error: std::invalid_argument,stoi: no conversion
at ___throw_exception_with_stack_trace (http://localhost:8000/nbcraft.js:8992:11)
at nbcraft.wasm.__cxa_throw (http://localhost:8000/nbcraft.wasm:wasm-function[17972]:0x30e58d)
at nbcraft.wasm.std::__2::__throw_invalid_argument[abi:ne210108](char const*) (http://localhost:8000/nbcraft.wasm:wasm-function[17957]:0x30e0d1)
at nbcraft.wasm.std::__2::(anonymous namespace)::throw_from_string_invalid_arg(std::__2::basic_string<char, std::__2::char_traits, std::__2::allocator> const&) (http://localhost:8000/nbcraft.wasm:wasm-function[17956]:0x30e065)
at nbcraft.wasm.long std::__2::(anonymous namespace)::as_integer_helper<long, std::__2::basic_string<char, std::__2::char_traits, std::__2::allocator>, long ()(char const, char**, int)>(std::__2::basic_string<char, std::__2::char_traits, std::__2::allocator> const&, std::__2::basic_string<char, std::__2::char_traits, std::__2::allocator> const&, unsigned long*, int, long ()(char const, char**, int)) (http://localhost:8000/nbcraft.wasm:wasm-function[17954]:0x30dfc3)
at nbcraft.wasm.std::__2::stoi(std::__2::basic_string<char, std::__2::char_traits, std::__2::allocator> const&, unsigned long*, int) (http://localhost:8000/nbcraft.wasm:wasm-function[17953]:0x30dee2)
at nbcraft.wasm.main (http://localhost:8000/nbcraft.wasm:wasm-function[555]:0xc1a1)
at http://localhost:8000/nbcraft.js:3594:12
at callMain (http://localhost:8000/nbcraft.js:22524:15)
at doRun (http://localhost:8000/nbcraft.js:22572:24)

This is what I got after building with -DCMAKE_BUILD_TYPE=Debug, and a few others.

[BrentDaMage]

Try changing

	// Window Size
#ifdef __EMSCRIPTEN__
	Minecraft::width = std::stoi(argv[1]);
	Minecraft::height = std::stoi(argv[2]);
#endif

to

	// Window Size
#ifdef __EMSCRIPTEN__
	Minecraft::width = std::stoi(argv[0]);
	Minecraft::height = std::stoi(argv[1]);
#endif

[MonkeTGG]

Exact same error. Forcing it to use a preset resolution worked however. Though still kind of annoying that it doesn't auto resize.

[MonkeTGG]

It now crashes on trying to load, or create a world. I don't know which one.

Probably something to do with the Emscripten FS, Same crash on Firefox. Or maybe WebGL.

[BrentDaMage]

Exact same error. Forcing it to use a preset resolution worked however. Though still kind of annoying that it doesn't auto resize.

Can you have it print the contents of the parameter array? I'm not very familiar with Emscripten, so I'm not sure what on earth it's passing here for its arguments that wouldn't be integers.

[TheBrokenRail]

I did change the CMakeLists.txt for it to build with a .html file aswell

This is your problem. ReMCPE has its own HTML file that does things like set argv to the correct values. You're using the default Emscripten file which does not do any of that. I haven't checked in a long time, but there is a WASM build script that should do this for you (and it is tested with the CI).

[TheBrokenRail]

And the max number of textures is set by this (frankly horrifying) line of code:

GLImmediate.MAX_TEXTURES = Math.min(Module['GL_MAX_TEXTURE_IMAGE_UNITS'] || GLctx.getParameter(GLctx.MAX_TEXTURE_IMAGE_UNITS), 28);

The issues with GL_TEXTURE0 should be solvable by specifying GL_MAX_TEXTURE_IMAGE_UNITS in wasm_shell.html's Module.

[MonkeTGG]

So just like,

GL_MAX_TEXTURE_IMAGE_UNITS = 999999999;?

Because it isn't working for me.