Add in opt-out configuration

Author: LeStarch

Os/Posix/Task.cpp

@@ -121,12 +121,12 @@ int set_task_name(pthread_t thread, const Os::Task::Arguments& arguments) {
 // pthread_setname_np is a non-POSIX function.
 // Limit its use to builds that involve glibc, on Linux, with _GNU_SOURCE defined.
 // That's the circumstance in which we expect this feature to work.
-#if defined(TGT_OS_TYPE_LINUX) && defined(__GLIBC__) && defined(_GNU_SOURCE)
+#if defined(TGT_OS_TYPE_LINUX) && defined(__GLIBC__) && defined(_GNU_SOURCE) && POSIX_THREADS_ENABLE_NAMES
 
-    // Construct a sixteen char long version of the task name
-    const FwSizeType PTHREAD_NAME_LENGTH = 16;
-    char name_sixteen_capped[PTHREAD_NAME_LENGTH];
-    Fw::StringUtils::string_copy(name_sixteen_capped, arguments.m_name.toChar(), PTHREAD_NAME_LENGTH);
+    // Construct a sixteen char long version of the task name. This length is fixed by the posix thread
+    // specification and is a constant.
+    char name_sixteen_capped[PosixTask::PTHREAD_NAME_LENGTH];
+    Fw::StringUtils::string_copy(name_sixteen_capped, arguments.m_name.toChar(), sizeof(name_sixteen_capped));
 
     status = pthread_setname_np(thread, name_sixteen_capped);
 #else

Os/Posix/Task.hpp

@@ -33,6 +33,7 @@ struct PosixTaskHandle : public TaskHandle {
 //! Posix task implementation as driven by pthreads implementation
 class PosixTask : public TaskInterface {
   public:
+    const FwSizeType PTHREAD_NAME_LENGTH = 16;  //!< Length of pthread name
     //! Enumeration of permission expectations
     enum PermissionExpectation {
         EXPECT_PERMISSION,    //!< Expect that you hold necessary permissions

default/config/FpConfig.h

@@ -148,6 +148,12 @@ extern "C" {
 #define FW_AMPCS_COMPATIBLE 0  //!< Whether or not JPL AMPCS ground system support is enabled.
 #endif
 
+// Posix thread names are limited to 16 characters, this can lead to collisions. In the event of a
+// collision, set this to 0.
+#ifndef POSIX_THREADS_ENABLE_NAMES
+#define POSIX_THREADS_ENABLE_NAMES 0  //!< Enable/Disable assigning names to threads
+#endif
+
 // *** NOTE configuration checks are in Fw/Cfg/ConfigCheck.cpp in order to have
 // the type definitions in Fw/Types/BasicTypes available.
 #ifdef __cplusplus